From 861f3fb5a66d3705b545f61b61a623d478419ca7 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Tue, 11 Apr 2023 06:00:23 -0700 Subject: [PATCH] Fix description of bug in 1990/westley Add to README.md that one thing (a crash without an arg) is at this time not a bug but a feature. Fix the statement that a negative number causes the entry to enter an infinite loop. Instead any input that's not a number > 0 will cause the program to enter an infinite loop. --- 1990/westley/Makefile | 2 ++ 1990/westley/README.md | 7 +++++-- bugs.md | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/1990/westley/Makefile b/1990/westley/Makefile index a305416b1..82b953470 100644 --- a/1990/westley/Makefile +++ b/1990/westley/Makefile @@ -128,6 +128,8 @@ all: data ${TARGET} supernova deep_magic magic charon pluto ${PROG}: ${PROG}.c + @echo "NOTE: this will very likely crash without an arg and will enter an infinite loop" + @echo "with an arg that is not a number > 0." ${CC} ${CFLAGS} $< -o $@ ${LIBS} # alternative executable diff --git a/1990/westley/README.md b/1990/westley/README.md index a58aef290..aa12f16a2 100644 --- a/1990/westley/README.md +++ b/1990/westley/README.md @@ -24,8 +24,11 @@ systems. It had `1s` in places for a short int which was changed to just `1`. Since it's instructional to see the differences he has provided an alternate version with the original code. See below. Thank you Cody for your assistance! -NOTE: this entry will segfault without an arg and will enter an infinite loop if -input is not a positive number. +NOTE: this program will enter an infinite loop if input is not a number > 0. + +### INABIAF - it's not a bug it's a feature :-) + +NOTE: this entry will very likely crash or do something else without an arg. ## Try: diff --git a/bugs.md b/bugs.md index 58ef1ad07..bfef50dce 100644 --- a/bugs.md +++ b/bugs.md @@ -537,8 +537,8 @@ fixing so it should not be fixed. ## STATUS: known bug - please help us fix -However a negative number will make the program enter an infinite loop. This -will be fixed in time but it's noted here for now. +However any input not a number > 0 will make the program enter an infinite loop. +This will be fixed in time but it's noted here for now. # 1991