From fd57e523bfc869f42e85c87080836ead66d7a28b Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 12 Jan 2024 09:24:50 -0800 Subject: [PATCH] Add 1990/tbr to bugs.md (INABIAF) --- 1990/tbr/README.md | 25 +++++++++++++++---------- bugs.md | 10 ++++++++++ 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/1990/tbr/README.md b/1990/tbr/README.md index d355c95cc..3c6b3e2e9 100644 --- a/1990/tbr/README.md +++ b/1990/tbr/README.md @@ -4,7 +4,19 @@ make all ``` -There is an [alternate version](#alternate-code) to this program. +The authors provided another version of this program. See the [alternate +version](#alternate-code) section below. + + +### Bugs and (Mis)features: + +The current status of this entry is: + +``` +STATUS: INABIAF - please **DO NOT** fix +``` + +For more detailed information see [1990 tbr in bugs.md](/bugs.md#1990-tbr). ### A note about the fixes of this entry in 2023: @@ -21,7 +33,7 @@ $ warning: this program uses gets(), which is unsafe. which kind of hid the prompt. Thus the entry was changed to use `fgets(3)` which is referred to later in this file. -Also `exit(3)` returns void but the entry was using it in a binary expression so +Also `exit(3)` returns `void` but the entry was using it in a binary expression so this entry would not compile in modern systems. This fix is also referred to below, in the [alternate version](#alternate-code) section. @@ -58,13 +70,6 @@ vi tbr.c What happens if you try using `cd -` to return to previous directory? What about `cd` with no args? -This is supposed to happen. As is written in the -[The Jargon File](http://catb.org/jargon/html/F/feature.html): - -``` -That's not a bug, that's a feature. -``` - The authors include a section called [BUGS](#bugs) that, because they were documented, are not considered bugs as such in the context of the contest. @@ -87,7 +92,7 @@ r(o,0)D o)D*f):4,wait(0):(o?dup2(*f,0)D*f)D o):*i?1 D e(x){x<0?write(2,"?\n$ "-x/4,2),x+1||(exit(1),0):5;} ``` -and in the [alternate source](tbr.alt.c). It has the `exit()` returns void fix +and in the [alternate source](tbr.alt.c). It has the `exit()` returns `void` fix as well as the `gets()` to `fgets()` fix applied to it to make it functionally equivalent like the authors intended. diff --git a/bugs.md b/bugs.md index 55deb8dac..8e3788e78 100644 --- a/bugs.md +++ b/bugs.md @@ -727,6 +727,16 @@ options used, seemingly, it has to write to disk the tarball which seems to defeat the purpose. This would ideally be fixed. +## 1990 tbr + +### STATUS: INABIAF - please **DO NOT** fix +### Source code: [1990/tbr/tbr.c](1990/tbr/tbr.c) +### Information: [1990/tbr/README.md](1990/tbr/README.md) + +The authors provided a list of features in the +[BUGS](/1990/tbr/README.md#bugs) section in their remarks. + + ## 1990 theorem ### STATUS: INABIAF - please **DO NOT** fix