multi: add debug logs for edge policy flow

This commit adds more logs around the ChannelUpdate->edge policy process
flow.
This commit is contained in:
yyforyongyu committed 2025-01-17 00:17:23 +08:00
1 parent e0a920af44
commit 001e5599b6
8 files changed
+43 -10

No files matched your search

+9 -5
View File
@@ -808,6 +808,8 @@ func (d *AuthenticatedGossiper) stop() {
func (d *AuthenticatedGossiper) ProcessRemoteAnnouncement(msg lnwire.Message, func (d *AuthenticatedGossiper) ProcessRemoteAnnouncement(msg lnwire.Message,
peer lnpeer.Peer) chan error { peer lnpeer.Peer) chan error {
log.Debugf("Processing remote msg %T from peer=%x", msg, peer.PubKey())
errChan := make(chan error, 1) errChan := make(chan error, 1)
// For messages in the known set of channel series queries, we'll // For messages in the known set of channel series queries, we'll
@@ -2371,7 +2373,8 @@ func (d *AuthenticatedGossiper) handleNodeAnnouncement(nMsg *networkMsg,
timestamp := time.Unix(int64(nodeAnn.Timestamp), 0) timestamp := time.Unix(int64(nodeAnn.Timestamp), 0)
log.Debugf("Processing NodeAnnouncement: peer=%v, timestamp=%v, "+ log.Debugf("Processing NodeAnnouncement: peer=%v, timestamp=%v, "+
"node=%x", nMsg.peer, timestamp, nodeAnn.NodeID) "node=%x, source=%x", nMsg.peer, timestamp, nodeAnn.NodeID,
nMsg.source.SerializeCompressed())
// We'll quickly ask the router if it already has a newer update for // We'll quickly ask the router if it already has a newer update for
// this node so we can skip validating signatures if not required. // this node so we can skip validating signatures if not required.
@@ -2430,7 +2433,8 @@ func (d *AuthenticatedGossiper) handleNodeAnnouncement(nMsg *networkMsg,
// TODO(roasbeef): get rid of the above // TODO(roasbeef): get rid of the above
log.Debugf("Processed NodeAnnouncement: peer=%v, timestamp=%v, "+ log.Debugf("Processed NodeAnnouncement: peer=%v, timestamp=%v, "+
"node=%x", nMsg.peer, timestamp, nodeAnn.NodeID) "node=%x, source=%x", nMsg.peer, timestamp, nodeAnn.NodeID,
nMsg.source.SerializeCompressed())
return announcements, true return announcements, true
} }
@@ -3034,9 +3038,9 @@ func (d *AuthenticatedGossiper) handleChanUpdate(nMsg *networkMsg,
edgeToUpdate = e2 edgeToUpdate = e2
} }
log.Debugf("Validating ChannelUpdate: channel=%v, from node=%x, has "+ log.Debugf("Validating ChannelUpdate: channel=%v, for node=%x, has "+
"edge=%v", chanInfo.ChannelID, pubKey.SerializeCompressed(), "edge policy=%v", chanInfo.ChannelID,
edgeToUpdate != nil) pubKey.SerializeCompressed(), edgeToUpdate != nil)
// Validate the channel announcement with the expected public key and // Validate the channel announcement with the expected public key and
// channel capacity. In the case of an invalid channel update, we'll // channel capacity. In the case of an invalid channel update, we'll
+2 -2
View File
@@ -529,8 +529,8 @@ func (m *SyncManager) createGossipSyncer(peer lnpeer.Peer) *GossipSyncer {
s.setSyncState(chansSynced) s.setSyncState(chansSynced)
s.setSyncType(PassiveSync) s.setSyncType(PassiveSync)
log.Debugf("Created new GossipSyncer[state=%s type=%s] for peer=%v", log.Debugf("Created new GossipSyncer[state=%s type=%s] for peer=%x",
s.syncState(), s.SyncType(), peer) s.syncState(), s.SyncType(), peer.PubKey())
return s return s
} }
+3 -3
View File
@@ -1342,9 +1342,9 @@ func (g *GossipSyncer) ApplyGossipFilter(filter *lnwire.GossipTimestampRange) er
return err return err
} }
log.Infof("GossipSyncer(%x): applying new update horizon: start=%v, "+ log.Infof("GossipSyncer(%x): applying new remote update horizon: "+
"end=%v, backlog_size=%v", g.cfg.peerPub[:], startTime, endTime, "start=%v, end=%v, backlog_size=%v", g.cfg.peerPub[:],
len(newUpdatestoSend)) startTime, endTime, len(newUpdatestoSend))
// If we don't have any to send, then we can return early. // If we don't have any to send, then we can return early.
if len(newUpdatestoSend) == 0 { if len(newUpdatestoSend) == 0 {
+3
View File
@@ -1400,6 +1400,9 @@ func (b *Builder) processUpdate(msg interface{},
msg.ChannelID) msg.ChannelID)
} }
log.Debugf("Found edge1Timestamp=%v, edge2Timestamp=%v",
edge1Timestamp, edge2Timestamp)
// As edges are directional edge node has a unique policy for // As edges are directional edge node has a unique policy for
// the direction of the edge they control. Therefore, we first // the direction of the edge they control. Therefore, we first
// check if we already have the most up-to-date information for // check if we already have the most up-to-date information for
+4
View File
@@ -2797,6 +2797,10 @@ func (c *ChannelGraph) UpdateEdgePolicy(edge *models.ChannelEdgePolicy,
tx, edge, c.graphCache, tx, edge, c.graphCache,
) )
if err != nil {
log.Errorf("UpdateEdgePolicy faild: %v", err)
}
// Silence ErrEdgeNotFound so that the batch can // Silence ErrEdgeNotFound so that the batch can
// succeed, but propagate the error via local state. // succeed, but propagate the error via local state.
if errors.Is(err, ErrEdgeNotFound) { if errors.Is(err, ErrEdgeNotFound) {
+8
View File
@@ -228,6 +228,9 @@ func (c *GraphCache) UpdatePolicy(policy *models.ChannelEdgePolicy, fromNode,
var inboundFee lnwire.Fee var inboundFee lnwire.Fee
_, err := policy.ExtraOpaqueData.ExtractRecords(&inboundFee) _, err := policy.ExtraOpaqueData.ExtractRecords(&inboundFee)
if err != nil { if err != nil {
log.Errorf("Failed to extract records from edge policy %v: %v",
policy.ChannelID, err)
return return
} }
@@ -236,11 +239,16 @@ func (c *GraphCache) UpdatePolicy(policy *models.ChannelEdgePolicy, fromNode,
updatePolicy := func(nodeKey route.Vertex) { updatePolicy := func(nodeKey route.Vertex) {
if len(c.nodeChannels[nodeKey]) == 0 { if len(c.nodeChannels[nodeKey]) == 0 {
log.Warnf("Node=%v not found in graph cache", nodeKey)
return return
} }
channel, ok := c.nodeChannels[nodeKey][policy.ChannelID] channel, ok := c.nodeChannels[nodeKey][policy.ChannelID]
if !ok { if !ok {
log.Warnf("Channel=%v not found in graph cache",
policy.ChannelID)
return return
} }
+8
View File
@@ -1,6 +1,7 @@
package models package models
import ( import (
"fmt"
"time" "time"
"github.com/btcsuite/btcd/btcec/v2/ecdsa" "github.com/btcsuite/btcd/btcec/v2/ecdsa"
@@ -113,3 +114,10 @@ func (c *ChannelEdgePolicy) ComputeFee(
return c.FeeBaseMSat + (amt*c.FeeProportionalMillionths)/feeRateParts return c.FeeBaseMSat + (amt*c.FeeProportionalMillionths)/feeRateParts
} }
// String returns a human-readable version of the channel edge policy.
func (c *ChannelEdgePolicy) String() string {
return fmt.Sprintf("ChannelID=%v, MessageFlags=%v, ChannelFlags=%v, "+
"LastUpdate=%v", c.ChannelID, c.MessageFlags, c.ChannelFlags,
c.LastUpdate)
}
+6
View File
@@ -59,6 +59,9 @@ func (u *nodeEdgeUnifier) addPolicy(fromNode route.Vertex,
// Skip channels if there is an outgoing channel restriction. // Skip channels if there is an outgoing channel restriction.
if localChan && u.outChanRestr != nil { if localChan && u.outChanRestr != nil {
if _, ok := u.outChanRestr[edge.ChannelID]; !ok { if _, ok := u.outChanRestr[edge.ChannelID]; !ok {
log.Debugf("Skipped adding policy for restricted edge "+
"%v", edge.ChannelID)
return return
} }
} }
@@ -100,6 +103,9 @@ func (u *nodeEdgeUnifier) addGraphPolicies(g Graph) error {
// Note that we are searching backwards so this node would have // Note that we are searching backwards so this node would have
// come prior to the pivot node in the route. // come prior to the pivot node in the route.
if channel.InPolicy == nil { if channel.InPolicy == nil {
log.Debugf("Skipped adding edge %v due to nil policy",
channel.ChannelID)
return nil return nil
} }