multi: add unsafedisconnect as a dev config

This commit adds a new dev config `unsafedisconnect` as we sometimes
want to disconnect nodes in our itests.

lncfg/dev.go

@@ -24,6 +24,17 @@ func (d *DevConfig) ChannelReadyWait() time.Duration {
 	return 0
 }
 
+// GetUnsafeDisconnect returns the config value, which is always true for
+// production build.
+//
+// TODO(yy): this is a temporary solution to allow users to reconnect peers to
+// trigger a reestablishiment for the active channels. Once a new dedicated RPC
+// is added to realize that functionality, this function should return false to
+// forbidden disconnecting peers while there are active channels.
+func (d *DevConfig) GetUnsafeDisconnect() bool {
+	return true
+}
+
 // GetReservationTimeout returns the config value for `ReservationTimeout`.
 func (d *DevConfig) GetReservationTimeout() time.Duration {
 	return DefaultReservationTimeout

lncfg/dev_integration.go

@@ -22,6 +22,7 @@ type DevConfig struct {
 	ProcessChannelReadyWait time.Duration `long:"processchannelreadywait" description:"Time to sleep before processing remote node's channel_ready message."`
 	ReservationTimeout      time.Duration `long:"reservationtimeout" description:"The maximum time we keep a pending channel open flow in memory."`
 	ZombieSweeperInterval   time.Duration `long:"zombiesweeperinterval" description:"The time interval at which channel opening flows are evaluated for zombie status."`
+	UnsafeDisconnect        bool          `long:"unsafedisconnect" description:"Allows the rpcserver to intentionally disconnect from peers with open channels."`
 }
 
 // ChannelReadyWait returns the config value `ProcessChannelReadyWait`.
@@ -46,3 +47,8 @@ func (d *DevConfig) GetZombieSweeperInterval() time.Duration {
 
 	return d.ZombieSweeperInterval
 }
+
+// ChannelReadyWait returns the config value `UnsafeDisconnect`.
+func (d *DevConfig) GetUnsafeDisconnect() bool {
+	return d.UnsafeDisconnect
+}