Merge pull request #2761 from halseth/reliable-payments-router-state-machine

[reliable payments] router payment state machine

htlcswitch/link_test.go

@@ -3889,8 +3889,7 @@ func TestChannelLinkAcceptDuplicatePayment(t *testing.T) {
 	}
 
 	// With the invoice now added to Carol's registry, we'll send the
-	// payment. It should succeed w/o any issues as it has been crafted
-	// properly.
+	// payment.
 	err = n.aliceServer.htlcSwitch.SendHTLC(
 		n.firstBobChannelLink.ShortChanID(), pid, htlc,
 	)
@@ -3905,6 +3904,16 @@ func TestChannelLinkAcceptDuplicatePayment(t *testing.T) {
 		t.Fatalf("unable to get payment result: %v", err)
 	}
 
+	// Now, if we attempt to send the payment *again* it should be rejected
+	// as it's a duplicate request.
+	err = n.aliceServer.htlcSwitch.SendHTLC(
+		n.firstBobChannelLink.ShortChanID(), pid, htlc,
+	)
+	if err != ErrPaymentIDAlreadyExists {
+		t.Fatalf("ErrPaymentIDAlreadyExists should have been "+
+			"received got: %v", err)
+	}
+
 	select {
 	case result, ok := <-resultChan:
 		if !ok {
@@ -3917,15 +3926,6 @@ func TestChannelLinkAcceptDuplicatePayment(t *testing.T) {
 	case <-time.After(5 * time.Second):
 		t.Fatalf("payment result did not arrive")
 	}
-
-	// Now, if we attempt to send the payment *again* it should be rejected
-	// as it's a duplicate request.
-	err = n.aliceServer.htlcSwitch.SendHTLC(
-		n.firstBobChannelLink.ShortChanID(), pid, htlc,
-	)
-	if err != ErrAlreadyPaid {
-		t.Fatalf("ErrAlreadyPaid should have been received got: %v", err)
-	}
 }
 
 // TestChannelLinkAcceptOverpay tests that if we create an invoice for sender,