Merge pull request #2030 from halseth/authsig-len

Validate own node announcement, signature length

channeldb/graph.go

@@ -2839,6 +2839,12 @@ func putLightningNode(nodeBucket *bbolt.Bucket, aliasBucket *bbolt.Bucket,
 		}
 	}
 
+	sigLen := len(node.AuthSigBytes)
+	if sigLen > 80 {
+		return fmt.Errorf("max sig len allowed is 80, had %v",
+			sigLen)
+	}
+
 	err = wire.WriteVarBytes(&b, 0, node.AuthSigBytes)
 	if err != nil {
 		return err

discovery/gossiper.go

@@ -1577,7 +1577,6 @@ func (d *AuthenticatedGossiper) processNetworkAnnouncement(
 	case *lnwire.NodeAnnouncement:
 		timestamp := time.Unix(int64(msg.Timestamp), 0)
 
-		if nMsg.isRemote {
 		// We'll quickly ask the router if it already has a
 		// newer update for this node so we can skip validating
 		// signatures if not required.
@@ -1593,7 +1592,6 @@ func (d *AuthenticatedGossiper) processNetworkAnnouncement(
 			nMsg.err <- err
 			return nil
 		}
-		}
 
 		features := lnwire.NewFeatureVector(
 			msg.Features, lnwire.GlobalFeatures,