multi: make tlv onion compulsory

feature/default_sets.go

@@ -18,7 +18,7 @@ var defaultSetDesc = setDesc{
 		SetInit:    {}, // I
 		SetNodeAnn: {}, // N
 	},
-	lnwire.TLVOnionPayloadOptional: {
+	lnwire.TLVOnionPayloadRequired: {
 		SetInit:         {}, // I
 		SetNodeAnn:      {}, // N
 		SetInvoice:      {}, // 9

feature/deps_test.go

@@ -33,7 +33,7 @@ var depTests = []depTest{
 	{
 		name: "one dep optional",
 		raw: lnwire.NewRawFeatureVector(
-			lnwire.TLVOnionPayloadOptional,
+			lnwire.TLVOnionPayloadRequired,
 			lnwire.PaymentAddrOptional,
 		),
 	},
@@ -61,7 +61,7 @@ var depTests = []depTest{
 	{
 		name: "two dep optional",
 		raw: lnwire.NewRawFeatureVector(
-			lnwire.TLVOnionPayloadOptional,
+			lnwire.TLVOnionPayloadRequired,
 			lnwire.PaymentAddrOptional,
 			lnwire.MPPOptional,
 		),
@@ -93,7 +93,7 @@ var depTests = []depTest{
 	{
 		name: "two dep first missing optional",
 		raw: lnwire.NewRawFeatureVector(
-			lnwire.TLVOnionPayloadOptional,
+			lnwire.TLVOnionPayloadRequired,
 			lnwire.MPPOptional,
 		),
 		expErr: ErrMissingFeatureDep{lnwire.PaymentAddrOptional},
@@ -110,7 +110,7 @@ var depTests = []depTest{
 		name: "forest optional",
 		raw: lnwire.NewRawFeatureVector(
 			lnwire.GossipQueriesOptional,
-			lnwire.TLVOnionPayloadOptional,
+			lnwire.TLVOnionPayloadRequired,
 			lnwire.PaymentAddrOptional,
 			lnwire.MPPOptional,
 		),
@@ -128,7 +128,7 @@ var depTests = []depTest{
 		name: "broken forest optional",
 		raw: lnwire.NewRawFeatureVector(
 			lnwire.GossipQueriesOptional,
-			lnwire.TLVOnionPayloadOptional,
+			lnwire.TLVOnionPayloadRequired,
 			lnwire.MPPOptional,
 		),
 		expErr: ErrMissingFeatureDep{lnwire.PaymentAddrOptional},

feature/manager_internal_test.go

@@ -19,7 +19,7 @@ var testSetDesc = setDesc{
 	lnwire.DataLossProtectRequired: {
 		SetNodeAnn: {}, // I
 	},
-	lnwire.TLVOnionPayloadOptional: {
+	lnwire.TLVOnionPayloadRequired: {
 		SetInit:    {}, // I
 		SetNodeAnn: {}, // N
 	},
@@ -104,6 +104,7 @@ func testManager(t *testing.T, test managerTest) {
 		// Assert that the manager properly unset the configured feature
 		// bits from all sets.
 		if test.cfg.NoTLVOnion {
+			assertUnset(lnwire.TLVOnionPayloadRequired)
 			assertUnset(lnwire.TLVOnionPayloadOptional)
 		}
 		if test.cfg.NoStaticRemoteKey {