Merge pull request #9525 from ellemouton/graph10

graph: Restrict interface to update channel proof instead of entire channel
This commit is contained in:
Oliver Gugger authored and GitHub committed 2025-02-18 11:34:38 -06:00
commit 31418e4b85
3 files changed
+16 -28

No files matched your search

+11 -14
View File
@@ -1317,19 +1317,17 @@ func (c *ChannelGraph) HasChannelEdge(
return upd1Time, upd2Time, exists, isZombie, nil
}
// UpdateChannelEdge retrieves and update edge of the graph database. Method
// only reserved for updating an edge info after its already been created.
// In order to maintain this constraints, we return an error in the scenario
// that an edge info hasn't yet been created yet, but someone attempts to update
// it.
func (c *ChannelGraph) UpdateChannelEdge(edge *models.ChannelEdgeInfo) error {
// AddEdgeProof sets the proof of an existing edge in the graph database.
func (c *ChannelGraph) AddEdgeProof(chanID lnwire.ShortChannelID,
proof *models.ChannelAuthProof) error {
// Construct the channel's primary key which is the 8-byte channel ID.
var chanKey [8]byte
binary.BigEndian.PutUint64(chanKey[:], edge.ChannelID)
binary.BigEndian.PutUint64(chanKey[:], chanID.ToUint64())
return kvdb.Update(c.db, func(tx kvdb.RwTx) error {
edges := tx.ReadWriteBucket(edgeBucket)
if edge == nil {
if edges == nil {
return ErrEdgeNotFound
}
@@ -1338,15 +1336,14 @@ func (c *ChannelGraph) UpdateChannelEdge(edge *models.ChannelEdgeInfo) error {
return ErrEdgeNotFound
}
if edgeInfo := edgeIndex.Get(chanKey[:]); edgeInfo == nil {
return ErrEdgeNotFound
edge, err := fetchChanEdgeInfo(edgeIndex, chanKey[:])
if err != nil {
return err
}
if c.graphCache != nil {
c.graphCache.UpdateChannel(edge)
}
edge.AuthProof = proof
return putChanEdgeInfo(edgeIndex, edge, chanKey)
return putChanEdgeInfo(edgeIndex, &edge, chanKey)
}, func() {})
}