From 3c759ef08106d00845d5c306854d00e68cb264ea Mon Sep 17 00:00:00 2001
From: Abdullahi Yunus <abdoollahikbk@gmail.com>
Date: Mon, 31 Mar 2025 21:14:32 +0100
Subject: [PATCH] fn: remove flaky test

In this commit, we remove TestPropForEachConcOutperformsMapWhenExpensive
as it's flaky and causes the CI to fail. The previous commit intro-
duced a replacement, which benchmarked the functions.
---
 fn/slice_test.go | 42 ------------------------------------------
 1 file changed, 42 deletions(-)

diff --git a/fn/slice_test.go b/fn/slice_test.go
index 7070431fc..7f44708e2 100644
--- a/fn/slice_test.go
+++ b/fn/slice_test.go
@@ -300,48 +300,6 @@ func TestPropForEachConcMapIsomorphism(t *testing.T) {
 	}
 }
 
-// TestPropForEachConcOutperformsMapWhenExpensive ensures the property that
-// ForEachConc will beat Map in a race in circumstances where the computation in
-// the argument closure is expensive.
-func TestPropForEachConcOutperformsMapWhenExpensive(t *testing.T) {
-	f := func(incSize int, s []int) bool {
-		if len(s) < 2 {
-			// Intuitively we don't expect the extra overhead of
-			// ForEachConc to justify itself for list sizes of 1 or
-			// 0.
-			return true
-		}
-
-		inc := func(i int) int {
-			time.Sleep(time.Millisecond)
-			return i + incSize
-		}
-		c := make(chan bool, 1)
-
-		go func() {
-			Map(s, inc)
-			select {
-			case c <- false:
-			default:
-			}
-		}()
-
-		go func() {
-			ForEachConc(s, inc)
-			select {
-			case c <- true:
-			default:
-			}
-		}()
-
-		return <-c
-	}
-
-	if err := quick.Check(f, nil); err != nil {
-		t.Fatal(err)
-	}
-}
-
 func TestPropFindIdxFindIdentity(t *testing.T) {
 	f := func(div, mod uint8, s []uint8) bool {
 		if div == 0 || div == 1 {