lnwallet: don't ignore any returned error from PublishTransaction

lnwallet/wallet.go

@@ -5,7 +5,6 @@ import (
 	"crypto/sha256"
 	"fmt"
 	"net"
-	"strings"
 	"sync"
 	"sync/atomic"
 
@@ -1114,12 +1113,9 @@ func (l *LightningWallet) handleFundingCounterPartySigs(msg *addCounterPartySigs
 
 	// Broadcast the finalized funding transaction to the network.
 	if err := l.PublishTransaction(fundingTx); err != nil {
-		// TODO(roasbeef): need to make this into a concrete error
+		msg.err <- err
-		if !strings.Contains(err.Error(), "already have") {
+		msg.completeChan <- nil
-			msg.err <- err
+		return
-			msg.completeChan <- nil
-			return
-		}
 	}
 
 	msg.completeChan <- res.partialState