mirror/lnd
1
0 Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

lnwallet/btcwallet: fix bug in implementation of GetUxo

Browse Source 
This commit fixes a bug within the btcwallet implementation of the
BlockChainIO interface. The exact nature of the bug was a rounding
error that would only manifest if the value of the UTXO was below 1
BTC.

The tests within this package currently test channels with mostly whole
values of BTC, as a result the bug went unnoticed until now.

The fix itself is trivial: convert to an int64 AFTER performing the
multiplication to convert to satoshis from Bitcoin.
This commit is contained in:
Olaoluwa Osuntokun committed 2016-12-27 16:43:51 -08:00
1 parent 78ce39692e
commit 4a0a657eb0
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
lnwallet/btcwallet/blockchain.go
+1 -1
View File
@@ -32,7 +32,7 @@ func (b *BtcWallet) GetUtxo(txid *wire.ShaHash, index uint32) (*wire.TxOut, erro
return &wire.TxOut{ return &wire.TxOut{
// Sadly, gettxout returns the output value in BTC // Sadly, gettxout returns the output value in BTC
// instead of satoshis. // instead of satoshis.
Value: int64(txout.Value) * 1e8, Value: int64(txout.Value * 1e8),
PkScript: pkScript, PkScript: pkScript,
}, nil }, nil
} }