From 5c5997935deea575e5ef68a15bf58d887591cc90 Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Sat, 27 Aug 2022 15:04:10 +0800 Subject: [PATCH] chanbackup: replace defer cleanup with `t.Cleanup` Signed-off-by: Eng Zer Jun --- chanbackup/backupfile_test.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/chanbackup/backupfile_test.go b/chanbackup/backupfile_test.go index db379b6f2..1bc94f38a 100644 --- a/chanbackup/backupfile_test.go +++ b/chanbackup/backupfile_test.go @@ -95,11 +95,6 @@ func TestUpdateAndSwap(t *testing.T) { }, } for i, testCase := range testCases { - // Ensure that all created files are removed at the end of the - // test case. - defer os.Remove(testCase.fileName) - defer os.Remove(testCase.tempFileName) - backupFile := NewMultiFile(testCase.fileName) // To start with, we'll make a random byte slice that'll pose @@ -112,10 +107,11 @@ func TestUpdateAndSwap(t *testing.T) { // If the old temporary file is meant to exist, then we'll // create it now as an empty file. if testCase.oldTempExists { - _, err := os.Create(testCase.tempFileName) + f, err := os.Create(testCase.tempFileName) if err != nil { t.Fatalf("unable to create temp file: %v", err) } + require.NoError(t, f.Close()) // TODO(roasbeef): mock out fs calls? }