From 7cf5b5be028b5f997e531c982c5fb0f79482f45e Mon Sep 17 00:00:00 2001
From: Elle Mouton <elle.mouton@gmail.com>
Date: Wed, 5 Feb 2025 11:29:07 +0200
Subject: [PATCH] graph: remove unused ForEachNode method from Builder

And from various interfaces where it is not needed.
---
 graph/builder.go    | 12 ------------
 graph/interfaces.go |  9 ---------
 2 files changed, 21 deletions(-)

diff --git a/graph/builder.go b/graph/builder.go
index 57f00c02a..25d44b826 100644
--- a/graph/builder.go
+++ b/graph/builder.go
@@ -1555,18 +1555,6 @@ func (b *Builder) FetchLightningNode(
 	return b.cfg.Graph.FetchLightningNode(node)
 }
 
-// ForEachNode is used to iterate over every node in router topology.
-//
-// NOTE: This method is part of the ChannelGraphSource interface.
-func (b *Builder) ForEachNode(
-	cb func(*models.LightningNode) error) error {
-
-	return b.cfg.Graph.ForEachNode(
-		func(_ kvdb.RTx, n *models.LightningNode) error {
-			return cb(n)
-		})
-}
-
 // ForAllOutgoingChannels is used to iterate over all outgoing channels owned by
 // the router.
 //
diff --git a/graph/interfaces.go b/graph/interfaces.go
index eb7f56603..10ca200f3 100644
--- a/graph/interfaces.go
+++ b/graph/interfaces.go
@@ -85,9 +85,6 @@ type ChannelGraphSource interface {
 	// public key. channeldb.ErrGraphNodeNotFound is returned if the node
 	// doesn't exist within the graph.
 	FetchLightningNode(route.Vertex) (*models.LightningNode, error)
-
-	// ForEachNode is used to iterate over every node in the known graph.
-	ForEachNode(func(node *models.LightningNode) error) error
 }
 
 // DB is an interface describing a persisted Lightning Network graph.
@@ -241,12 +238,6 @@ type DB interface {
 	FetchLightningNode(nodePub route.Vertex) (*models.LightningNode,
 		error)
 
-	// ForEachNode iterates through all the stored vertices/nodes in the
-	// graph, executing the passed callback with each node encountered. If
-	// the callback returns an error, then the transaction is aborted and
-	// the iteration stops early.
-	ForEachNode(cb func(kvdb.RTx, *models.LightningNode) error) error
-
 	// ForEachNodeChannel iterates through all channels of the given node,
 	// executing the passed callback with an edge info structure and the
 	// policies of each end of the channel. The first edge policy is the