Merge pull request #10167 from starius/go124

multi: bump Go to 1.24.6

.github/actions/setup-go/action.yml

@@ -52,8 +52,8 @@ runs:
         # The key is used to create and later look up the cache. It's made of
         # four parts:  
         # - The base part is made from the OS name, Go version and a
-        #   job-specified key prefix. Example: `linux-go-1.23.12-unit-test-`.
-        #   It ensures that a job running on Linux with Go 1.23 only looks for
+        #   job-specified key prefix. Example: `linux-go-1.24.6-unit-test-`.
+        #   It ensures that a job running on Linux with Go 1.24 only looks for
         #   caches from the same environment.
         # - The unique part is the `hashFiles('**/go.sum')`, which calculates a
         #   hash (a fingerprint) of the go.sum file. 

.github/workflows/main.yml

@@ -40,7 +40,7 @@ env:
 
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  GO_VERSION: 1.23.12
+  GO_VERSION: 1.24.6
 
 jobs:
   static-checks:

.github/workflows/release.yaml

@@ -12,7 +12,7 @@ defaults:
 env:
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  GO_VERSION: 1.23.12
+  GO_VERSION: 1.24.6
 
 jobs:
   ########################

.golangci.yml

@@ -1,7 +1,7 @@
 run:
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  go: "1.23.12"
+  go: "1.24.6"
 
   # Abort after 10 minutes.
   timeout: 10m

Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.23.12-alpine as builder
+FROM golang:1.24.6-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.

Makefile

@@ -28,7 +28,7 @@ ACTIVE_GO_VERSION_MINOR := $(shell echo $(ACTIVE_GO_VERSION) | cut -d. -f2)
 # GO_VERSION is the Go version used for the release build, docker files, and
 # GitHub Actions. This is the reference version for the project. All other Go
 # versions are checked against this version.
-GO_VERSION = 1.23.12
+GO_VERSION = 1.24.6
 
 GOBUILD := $(GOCC) build -v
 GOINSTALL := $(GOCC) install -v

accessman_test.go

@@ -1,7 +1,6 @@
 package lnd
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -490,7 +489,7 @@ func TestAssignPeerPermsBypassExisting(t *testing.T) {
 func TestHasPeer(t *testing.T) {
 	t.Parallel()
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create a testing accessMan.
 	a := &accessMan{
@@ -708,7 +707,7 @@ func TestAddPeerAccessOutbound(t *testing.T) {
 // accessman's internal state based on the peer's status.
 func TestRemovePeerAccess(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create a testing accessMan.
 	a := &accessMan{

autopilot/betweenness_centrality_test.go

@@ -1,7 +1,6 @@
 package autopilot
 
 import (
-	"context"
 	"fmt"
 	"testing"
 
@@ -32,7 +31,7 @@ func TestBetweennessCentralityMetricConstruction(t *testing.T) {
 // Tests that empty graph results in empty centrality result.
 func TestBetweennessCentralityEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	centralityMetric, err := NewBetweennessCentralityMetric(1)
 	require.NoError(
@@ -64,7 +63,7 @@ func TestBetweennessCentralityEmptyGraph(t *testing.T) {
 // Test betweenness centrality calculating using an example graph.
 func TestBetweennessCentralityWithNonEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	workers := []int{1, 3, 9, 100}
 

autopilot/externalscoreattach_test.go

@@ -1,7 +1,6 @@
 package autopilot_test
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -23,7 +22,7 @@ func randKey() (*btcec.PublicKey, error) {
 // ExternalScoreAttachment correctly reflects the scores we set last.
 func TestSetNodeScores(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	const name = "externalscore"
 

autopilot/prefattach_test.go

@@ -76,7 +76,7 @@ var chanGraphs = []struct {
 // empty graph, the NodeSores function always returns a score of 0.
 func TestPrefAttachmentSelectEmptyGraph(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	prefAttach := NewPrefAttachment()
 
 	// Create a random public key, which we will query to get a score for.
@@ -116,7 +116,7 @@ func TestPrefAttachmentSelectEmptyGraph(t *testing.T) {
 // and the funds are appropriately allocated across each peer.
 func TestPrefAttachmentSelectTwoVertexes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 
@@ -203,7 +203,7 @@ func TestPrefAttachmentSelectTwoVertexes(t *testing.T) {
 // allocate all funds to each vertex (up to the max channel size).
 func TestPrefAttachmentSelectGreedyAllocation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 
@@ -316,7 +316,7 @@ func TestPrefAttachmentSelectGreedyAllocation(t *testing.T) {
 // of zero during scoring.
 func TestPrefAttachmentSelectSkipNodes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	prand.Seed(time.Now().Unix())
 

autopilot/top_centrality_test.go

@@ -1,7 +1,6 @@
 package autopilot
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -59,7 +58,7 @@ func testTopCentrality(t *testing.T, graph testGraph,
 		// Attempt to get centrality scores and expect
 		// that the result equals with the expected set.
 		scores, err := topCentrality.NodeScores(
-			context.Background(), graph, channels, chanSize, nodes,
+			t.Context(), graph, channels, chanSize, nodes,
 		)
 
 		require.NoError(t, err)

batch/batch_test.go

@@ -1,7 +1,6 @@
 package batch
 
 import (
-	"context"
 	"database/sql"
 	"encoding/binary"
 	"errors"
@@ -31,7 +30,7 @@ var batchTestIntervals = []time.Duration{
 // TestRetry tests the retry logic of the batch scheduler.
 func TestRetry(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	dbDir := t.TempDir()
 
@@ -99,7 +98,7 @@ func TestRetry(t *testing.T) {
 // and then continue to add a write transaction to the same batch.
 func TestReadOnly(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	t.Run("bbolt-ReadWrite", func(t *testing.T) {
 		db, err := walletdb.Create(
@@ -455,7 +454,7 @@ func BenchmarkBoltBatching(b *testing.B) {
 	// batchTest benches the performance of the batch scheduler configured
 	// with/without the LazyAdd option and with the given commit interval.
 	batchTest := func(b *testing.B, lazy bool, interval time.Duration) {
-		ctx := context.Background()
+		ctx := b.Context()
 
 		db := setUpDB(b)
 
@@ -549,7 +548,7 @@ func benchmarkSQLBatching(b *testing.B, sqlite bool) {
 		)
 	}
 
-	ctx := context.Background()
+	ctx := b.Context()
 	opts := sqldb.WriteTxOpt()
 
 	// writeRecord is a helper that adds a single new invoice to the

chanacceptor/rpcacceptor.go

@@ -548,7 +548,7 @@ func (r *RPCAcceptor) validateAcceptorResponse(dustLimit btcutil.Amount,
 
 	// If we reject the channel, and have a custom error, then we use it.
 	case haveCustomError:
-		return false, fmt.Errorf(req.Error), nil, nil
+		return false, fmt.Errorf("%s", req.Error), nil, nil
 
 	// Otherwise, we have rejected the channel with no custom error, so we
 	// just use a generic error to fail the channel.

chanbackup/backup_test.go

@@ -121,8 +121,7 @@ func TestFetchBackupForChan(t *testing.T) {
 	}
 	for i, testCase := range testCases {
 		_, err := FetchBackupForChan(
-			context.Background(), testCase.chanPoint, chanSource,
-			chanSource,
+			t.Context(), testCase.chanPoint, chanSource, chanSource,
 		)
 		switch {
 		// If this is a valid test case, and we failed, then we'll
@@ -143,7 +142,7 @@ func TestFetchBackupForChan(t *testing.T) {
 // channel source for all channels and construct a Single for each channel.
 func TestFetchStaticChanBackups(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll make the set of channels that we want to seed the
 	// channel source with. Both channels will be fully populated in the

chanbackup/pubsub_test.go

@@ -81,7 +81,7 @@ func (m *mockChannelNotifier) SubscribeChans(_ context.Context,
 // channel subscription, then the entire sub-swapper will fail to start.
 func TestNewSubSwapperSubscribeFail(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	keyRing := &lnencrypt.MockKeyRing{}
 
@@ -159,7 +159,7 @@ func TestSubSwapperIdempotentStartStop(t *testing.T) {
 
 	swapper := newMockSwapper(keyRing)
 	subSwapper, err := NewSubSwapper(
-		context.Background(), nil, &chanNotifier, keyRing, swapper,
+		t.Context(), nil, &chanNotifier, keyRing, swapper,
 	)
 	require.NoError(t, err, "unable to init subSwapper")
 
@@ -226,8 +226,7 @@ func TestSubSwapperUpdater(t *testing.T) {
 	// With our channel set created, we'll make a fresh sub swapper
 	// instance to begin our test.
 	subSwapper, err := NewSubSwapper(
-		context.Background(), initialChanSet, chanNotifier, keyRing,
-		swapper,
+		t.Context(), initialChanSet, chanNotifier, keyRing, swapper,
 	)
 	require.NoError(t, err, "unable to make swapper")
 	if err := subSwapper.Start(); err != nil {

channeldb/addr_source_test.go

@@ -20,7 +20,7 @@ var (
 // deduplicates the results of a set of AddrSource implementations.
 func TestMultiAddrSource(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	var pk1 = newTestPubKey(t)
 

channeldb/db_test.go

@@ -1,7 +1,6 @@
 package channeldb
 
 import (
-	"context"
 	"image/color"
 	"math"
 	"math/rand"
@@ -181,7 +180,7 @@ func TestFetchClosedChannelForID(t *testing.T) {
 // channel db and graph db.
 func TestMultiSourceAddrsForNode(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	fullDB, err := MakeTestDB(t)
 	require.NoError(t, err, "unable to make test database")

channeldb/migration_01_to_11/zpay32/bech32.go

@@ -76,7 +76,8 @@ func decodeBech32(bech string) (string, []byte, error) {
 			moreInfo = fmt.Sprintf("Expected %v, got %v.",
 				expected, checksum)
 		}
-		return "", nil, fmt.Errorf("checksum failed. " + moreInfo)
+
+		return "", nil, fmt.Errorf("checksum failed. %s", moreInfo)
 	}
 
 	// We exclude the last 6 bytes, which is the checksum.

cluster/etcd_elector_test.go

@@ -46,7 +46,7 @@ func TestEtcdElector(t *testing.T) {
 	require.NoError(t, err)
 	t.Cleanup(cleanup)
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 	defer cancel()
 
 	const (
@@ -70,7 +70,7 @@ func TestEtcdElector(t *testing.T) {
 	ch := make(chan *etcdLeaderElector)
 
 	wg.Add(2)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	go func() {
 		defer wg.Done()

contractcourt/breach_arbitrator_test.go

@@ -2070,7 +2070,7 @@ func assertBrarCleanup(t *testing.T, brar *BreachArbitrator,
 
 	}, 5*time.Second)
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 }
 

contractcourt/chain_watcher_test.go

@@ -173,7 +173,7 @@ func TestChainWatcherRemoteUnilateralClosePendingCommit(t *testing.T) {
 
 	// With the HTLC added, we'll now manually initiate a state transition
 	// from Alice to Bob.
-	testQuit, testQuitFunc := context.WithCancel(context.Background())
+	testQuit, testQuitFunc := context.WithCancel(t.Context())
 	t.Cleanup(testQuitFunc)
 	_, err = aliceChannel.SignNextCommitment(testQuit)
 	require.NoError(t, err)

dev.Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.23.12-alpine AS builder
+FROM golang:1.24.6-alpine AS builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

discovery/gossiper_test.go

@@ -1024,7 +1024,7 @@ func createTestCtx(t *testing.T, startHeight uint32, isChanPeer bool) (
 // the router subsystem.
 func TestProcessAnnouncement(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	timestamp := testTimestamp
 	tCtx, err := createTestCtx(t, 0, false)
@@ -1140,7 +1140,7 @@ func TestProcessAnnouncement(t *testing.T) {
 // propagated to the router subsystem.
 func TestPrematureAnnouncement(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	timestamp := testTimestamp
 
@@ -1176,7 +1176,7 @@ func TestPrematureAnnouncement(t *testing.T) {
 // properly processes partial and fully announcement signatures message.
 func TestSignatureAnnouncementLocalFirst(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -1355,7 +1355,7 @@ func TestSignatureAnnouncementLocalFirst(t *testing.T) {
 // processes announcement with unknown channel ids.
 func TestOrphanSignatureAnnouncement(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -1547,7 +1547,7 @@ func TestOrphanSignatureAnnouncement(t *testing.T) {
 // assembled.
 func TestSignatureAnnouncementRetryAtStartup(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -1783,7 +1783,7 @@ out:
 // the full proof (ChannelAnnouncement) to the remote peer.
 func TestSignatureAnnouncementFullProofWhenRemoteProof(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -2225,7 +2225,7 @@ func TestDeDuplicatedAnnouncements(t *testing.T) {
 // announcements for nodes who do not intend to publicly advertise themselves.
 func TestForwardPrivateNodeAnnouncement(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	const (
 		startingHeight = 100
@@ -2334,7 +2334,7 @@ func TestForwardPrivateNodeAnnouncement(t *testing.T) {
 // zombie edges.
 func TestRejectZombieEdge(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll start by creating our test context with a batch of
 	// announcements.
@@ -2436,7 +2436,7 @@ func TestRejectZombieEdge(t *testing.T) {
 // becomes live by receiving a fresh update.
 func TestProcessZombieEdgeNowLive(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll start by creating our test context with a batch of
 	// announcements.
@@ -2594,7 +2594,7 @@ func TestProcessZombieEdgeNowLive(t *testing.T) {
 // be reprocessed later, after our ChannelAnnouncement.
 func TestReceiveRemoteChannelUpdateFirst(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -2798,7 +2798,7 @@ func TestReceiveRemoteChannelUpdateFirst(t *testing.T) {
 // currently know of.
 func TestExtraDataChannelAnnouncementValidation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 0, false)
 	require.NoError(t, err, "can't create context")
@@ -2835,7 +2835,7 @@ func TestExtraDataChannelAnnouncementValidation(t *testing.T) {
 // know of.
 func TestExtraDataChannelUpdateValidation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	timestamp := testTimestamp
 	tCtx, err := createTestCtx(t, 0, false)
@@ -2896,7 +2896,7 @@ func TestExtraDataChannelUpdateValidation(t *testing.T) {
 // currently know of.
 func TestExtraDataNodeAnnouncementValidation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 0, false)
 	require.NoError(t, err, "can't create context")
@@ -2969,7 +2969,7 @@ func assertProcessAnnouncement(t *testing.T, result chan error) {
 // the retransmit ticker ticks.
 func TestRetransmit(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -3079,7 +3079,7 @@ func TestRetransmit(t *testing.T) {
 // no existing channels in the graph do not get forwarded.
 func TestNodeAnnouncementNoChannels(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 0, false)
 	require.NoError(t, err, "can't create context")
@@ -3171,7 +3171,7 @@ func TestNodeAnnouncementNoChannels(t *testing.T) {
 // validate the msg flags and max HTLC field of a ChannelUpdate.
 func TestOptionalFieldsChannelUpdateValidation(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 0, false)
 	require.NoError(t, err, "can't create context")
@@ -3269,7 +3269,7 @@ func TestOptionalFieldsChannelUpdateValidation(t *testing.T) {
 // channel is always sent upon the remote party reconnecting.
 func TestSendChannelUpdateReliably(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll start by creating our test context and a batch of
 	// announcements.
@@ -3587,7 +3587,7 @@ func sendRemoteMsg(t *testing.T, ctx *testCtx, msg lnwire.Message,
 
 	select {
 	case err := <-ctx.gossiper.ProcessRemoteAnnouncement(
-		context.Background(), msg, remotePeer,
+		t.Context(), msg, remotePeer,
 	):
 		if err != nil {
 			t.Fatalf("unable to process channel msg: %v", err)
@@ -3718,7 +3718,7 @@ out:
 	// policy of all of them.
 	const newTimeLockDelta = 100
 	var edgesToUpdate []EdgeWithInfo
-	err = ctx.router.ForAllOutgoingChannels(context.Background(), func(
+	err = ctx.router.ForAllOutgoingChannels(t.Context(), func(
 		info *models.ChannelEdgeInfo,
 		edge *models.ChannelEdgePolicy) error {
 
@@ -3986,7 +3986,7 @@ func (m *SyncManager) markGraphSyncing() {
 // initial historical sync has completed.
 func TestBroadcastAnnsAfterGraphSynced(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 10, false)
 	require.NoError(t, err, "can't create context")
@@ -4064,7 +4064,7 @@ func TestBroadcastAnnsAfterGraphSynced(t *testing.T) {
 // is tested by TestRateLimitChannelUpdates.
 func TestRateLimitDeDup(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create our test harness.
 	const blockHeight = 100
@@ -4261,7 +4261,7 @@ func TestRateLimitDeDup(t *testing.T) {
 // channel updates.
 func TestRateLimitChannelUpdates(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create our test harness.
 	const blockHeight = 100
@@ -4416,7 +4416,7 @@ func TestRateLimitChannelUpdates(t *testing.T) {
 // about our own channels when coming from a remote peer.
 func TestIgnoreOwnAnnouncement(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -4563,7 +4563,7 @@ func TestIgnoreOwnAnnouncement(t *testing.T) {
 // error.
 func TestRejectCacheChannelAnn(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, proofMatureDelta, false)
 	require.NoError(t, err, "can't create context")
@@ -4644,7 +4644,7 @@ func TestFutureMsgCacheEviction(t *testing.T) {
 // channel announcements are banned properly.
 func TestChanAnnBanningNonChanPeer(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 1000, false)
 	require.NoError(t, err, "can't create context")
@@ -4739,7 +4739,7 @@ func TestChanAnnBanningNonChanPeer(t *testing.T) {
 // get disconnected.
 func TestChanAnnBanningChanPeer(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tCtx, err := createTestCtx(t, 1000, true)
 	require.NoError(t, err, "can't create context")
@@ -4832,7 +4832,7 @@ func assertChanChainRejection(t *testing.T, ctx *testCtx,
 	}
 
 	_, added := ctx.gossiper.handleChanAnnouncement(
-		context.Background(), nMsg, edge,
+		t.Context(), nMsg, edge,
 	)
 	require.False(t, added)
 

discovery/reliable_sender_test.go

@@ -71,7 +71,7 @@ func assertMsgsSent(t *testing.T, msgChan chan lnwire.Message,
 // a peer while taking into account its connection lifecycle works as expected.
 func TestReliableSenderFlow(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	reliableSender := newTestReliableSender(t)
 
@@ -188,7 +188,7 @@ func TestReliableSenderFlow(t *testing.T) {
 // them as stale.
 func TestReliableSenderStaleMessages(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	reliableSender := newTestReliableSender(t)
 

discovery/syncer_atomic_test.go

@@ -15,7 +15,7 @@ import (
 // backlog at a time using the atomic flag.
 func TestGossipSyncerSingleBacklogSend(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Track how many goroutines are actively sending.
 	var (

discovery/syncer_test.go

@@ -232,7 +232,7 @@ func newTestSyncer(hID lnwire.ShortChannelID,
 // doesn't have a horizon set, then we won't send any incoming messages to it.
 func TestGossipSyncerFilterGossipMsgsNoHorizon(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -278,7 +278,7 @@ func unixStamp(a int64) uint32 {
 // channel ann that already has a channel update on disk.
 func TestGossipSyncerFilterGossipMsgsAllInMemory(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -421,7 +421,7 @@ func TestGossipSyncerFilterGossipMsgsAllInMemory(t *testing.T) {
 // messages which are within their desired time horizon.
 func TestGossipSyncerApplyNoHistoricalGossipFilter(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -473,7 +473,7 @@ func TestGossipSyncerApplyNoHistoricalGossipFilter(t *testing.T) {
 	// filter.
 	err := <-errChan
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 }
 
@@ -482,7 +482,7 @@ func TestGossipSyncerApplyNoHistoricalGossipFilter(t *testing.T) {
 // within their desired time horizon.
 func TestGossipSyncerApplyGossipFilter(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -602,7 +602,7 @@ func TestGossipSyncerApplyGossipFilter(t *testing.T) {
 // channels and complete=0.
 func TestGossipSyncerQueryChannelRangeWrongChainHash(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -655,7 +655,7 @@ func TestGossipSyncerQueryChannelRangeWrongChainHash(t *testing.T) {
 // complete=0.
 func TestGossipSyncerReplyShortChanIDsWrongChainHash(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -705,7 +705,7 @@ func TestGossipSyncerReplyShortChanIDsWrongChainHash(t *testing.T) {
 // announcements, as well as an ending ReplyShortChanIDsEnd message.
 func TestGossipSyncerReplyShortChanIDs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -811,7 +811,7 @@ func TestGossipSyncerReplyShortChanIDs(t *testing.T) {
 // the remote peer.
 func TestGossipSyncerReplyChanRangeQuery(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll use a smaller chunk size so we can easily test all the edge
 	// cases.
@@ -983,7 +983,7 @@ func TestGossipSyncerReplyChanRangeQuery(t *testing.T) {
 // executed with the correct block range.
 func TestGossipSyncerReplyChanRangeQueryBlockRange(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First create our test gossip syncer that will handle and
 	// respond to the test queries
@@ -1097,7 +1097,7 @@ func TestGossipSyncerReplyChanRangeQueryBlockRange(t *testing.T) {
 // back a single response that signals completion.
 func TestGossipSyncerReplyChanRangeQueryNoNewChans(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll now create our test gossip syncer that will shortly respond to
 	// our canned query.
@@ -1177,7 +1177,7 @@ func TestGossipSyncerReplyChanRangeQueryNoNewChans(t *testing.T) {
 // channel ID, we properly generate an correct initial channel range response.
 func TestGossipSyncerGenChanRangeQuery(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -1238,7 +1238,7 @@ func TestGossipSyncerProcessChanRangeReply(t *testing.T) {
 // each reply instead.
 func testGossipSyncerProcessChanRangeReply(t *testing.T, legacy bool) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create a GossipSyncer instance with a canned sendToPeer
 	// message to allow us to intercept their potential sends.
@@ -1499,7 +1499,7 @@ func TestGossipSyncerSynchronizeChanIDs(t *testing.T) {
 
 	for i := 0; i < chunkSize*2; i += 2 {
 		// With our set up complete, we'll request a sync of chan ID's.
-		done := syncer.synchronizeChanIDs(context.Background())
+		done := syncer.synchronizeChanIDs(t.Context())
 
 		// At this point, we shouldn't yet be done as only 2 items
 		// should have been queried for.
@@ -1546,7 +1546,7 @@ func TestGossipSyncerSynchronizeChanIDs(t *testing.T) {
 	}
 
 	// If we issue another query, the syncer should tell us that it's done.
-	done := syncer.synchronizeChanIDs(context.Background())
+	done := syncer.synchronizeChanIDs(t.Context())
 	if done {
 		t.Fatalf("syncer should be finished!")
 	}

docker/btcd/Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.23.12-alpine as builder
+FROM golang:1.24.6-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docs/INSTALL.md

@@ -93,7 +93,7 @@ following build dependencies are required:
 
 ### Installing Go
 
-`lnd` is written in Go, with a minimum version of `1.23.12` (or, in case this
+`lnd` is written in Go, with a minimum version of `1.24.6` (or, in case this
 document gets out of date, whatever the Go version in the main `go.mod` file
 requires). To install, run one of the following commands for your OS:
 
@@ -101,16 +101,16 @@ requires). To install, run one of the following commands for your OS:
   <summary>Linux (x86-64)</summary>
 
   ```
-  wget https://dl.google.com/go/go1.23.12.linux-amd64.tar.gz
-  sha256sum go1.23.12.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
+  wget https://dl.google.com/go/go1.24.6.linux-amd64.tar.gz
+  sha256sum go1.24.6.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
   ```
 
   The final output of the command above should be
-  `d3847fef834e9db11bf64e3fb34db9c04db14e068eeb064f49af747010454f90`. If it
+  `bbca37cc395c974ffa4893ee35819ad23ebb27426df87af92e93a9ec66ef8712`. If it
   isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
   this version of Go. If it matches, then proceed to install Go:
   ```
-  sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf go1.23.12.linux-amd64.tar.gz
+  sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf go1.24.6.linux-amd64.tar.gz
   export PATH=$PATH:/usr/local/go/bin
   ```
 </details>
@@ -119,16 +119,16 @@ requires). To install, run one of the following commands for your OS:
   <summary>Linux (ARMv6)</summary>
 
   ```
-  wget https://dl.google.com/go/go1.23.12.linux-armv6l.tar.gz
-  sha256sum go1.23.12.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
+  wget https://dl.google.com/go/go1.24.6.linux-armv6l.tar.gz
+  sha256sum go1.24.6.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
   ```
 
   The final output of the command above should be
-  `9704eba01401a3793f54fac162164b9c5d8cc6f3cab5cee72684bb72294d9f41`. If it
+  `7feb4d25f5e72f94fda81c99d4adb6630dfa2c35211e0819417d53af6e71809e`. If it
   isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
   this version of Go. If it matches, then proceed to install Go:
   ```
-  sudo rm -rf /usr/local/go && tar -C /usr/local -xzf go1.23.12.linux-armv6l.tar.gz
+  sudo rm -rf /usr/local/go && tar -C /usr/local -xzf go1.24.6.linux-armv6l.tar.gz
   export PATH=$PATH:/usr/local/go/bin
   ```
 

fn/context_guard_test.go

@@ -20,7 +20,7 @@ func TestContextGuard(t *testing.T) {
 	t.Run("Parent context is cancelled", func(t *testing.T) {
 		t.Parallel()
 		var (
-			ctx, cancel = context.WithCancel(context.Background())
+			ctx, cancel = context.WithCancel(t.Context())
 			g           = NewContextGuard()
 		)
 
@@ -42,7 +42,7 @@ func TestContextGuard(t *testing.T) {
 	t.Run("Derived context is cancelled", func(t *testing.T) {
 		t.Parallel()
 		var (
-			ctx = context.Background()
+			ctx = t.Context()
 			g   = NewContextGuard()
 		)
 
@@ -66,7 +66,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx = context.Background()
+			ctx = t.Context()
 			g   = NewContextGuard()
 		)
 		ctxc, _ := g.Create(ctx)
@@ -87,7 +87,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx, cancel = context.WithCancel(context.Background())
+			ctx, cancel = context.WithCancel(t.Context())
 			g           = NewContextGuard()
 		)
 		cancel()
@@ -107,7 +107,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx = context.Background()
+			ctx = t.Context()
 			g   = NewContextGuard()
 		)
 
@@ -130,7 +130,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx, cancel = context.WithCancel(context.Background())
+			ctx, cancel = context.WithCancel(t.Context())
 			g           = NewContextGuard()
 			task        = make(chan struct{})
 			done        = make(chan struct{})
@@ -172,7 +172,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx  = context.Background()
+			ctx  = t.Context()
 			g    = NewContextGuard()
 			task = make(chan struct{})
 			done = make(chan struct{})
@@ -218,7 +218,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx  = context.Background()
+			ctx  = t.Context()
 			g    = NewContextGuard()
 			task = make(chan struct{})
 			done = make(chan struct{})
@@ -316,7 +316,7 @@ func TestContextGuard(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx     = context.Background()
+			ctx     = t.Context()
 			g       = NewContextGuard()
 			task    = make(chan struct{})
 			done    = make(chan struct{})
@@ -452,7 +452,7 @@ func TestContextGuardCountGoroutines(t *testing.T) {
 
 	g := NewContextGuard()
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	// Count goroutines before contexts are created.
 	count1 := runtime.NumGoroutine()

fn/goroutine_manager_test.go

@@ -18,7 +18,7 @@ func TestGoroutineManager(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx      = context.Background()
+			ctx      = t.Context()
 			m        = NewGoroutineManager()
 			taskChan = make(chan struct{})
 		)
@@ -61,7 +61,7 @@ func TestGoroutineManager(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx      = context.Background()
+			ctx      = t.Context()
 			m        = NewGoroutineManager()
 			taskChan = make(chan struct{})
 		)
@@ -114,7 +114,7 @@ func TestGoroutineManager(t *testing.T) {
 		t.Parallel()
 
 		var (
-			ctx      = context.Background()
+			ctx      = t.Context()
 			m        = NewGoroutineManager()
 			stopChan = make(chan struct{})
 		)

funding/batch_test.go

@@ -359,7 +359,7 @@ func TestBatchFund(t *testing.T) {
 				MinConfs:    1,
 			}
 			updates, err := h.batcher.BatchFund(
-				context.Background(), req,
+				t.Context(), req,
 			)
 
 			if tc.failUpdate1 || tc.failUpdate2 || tc.failPublish {

go.mod

@@ -54,7 +54,6 @@ require (
 	golang.org/x/crypto v0.37.0
 	golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8
 	golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028
-	golang.org/x/net v0.39.0
 	golang.org/x/sync v0.13.0
 	golang.org/x/term v0.31.0
 	golang.org/x/time v0.3.0
@@ -182,6 +181,7 @@ require (
 	go.uber.org/multierr v1.6.0 // indirect
 	go.uber.org/zap v1.17.0 // indirect
 	golang.org/x/mod v0.17.0 // indirect
+	golang.org/x/net v0.39.0 // indirect
 	golang.org/x/sys v0.32.0 // indirect
 	golang.org/x/text v0.24.0 // indirect
 	golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
@@ -220,6 +220,6 @@ replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-d
 // If you change this please also update docs/INSTALL.md and GO_VERSION in
 // Makefile (then run `make lint` to see where else it needs to be updated as
 // well).
-go 1.23.12
+go 1.24.6
 
 retract v0.0.2

graph/builder_test.go

@@ -2,7 +2,6 @@ package graph
 
 import (
 	"bytes"
-	"context"
 	"crypto/sha256"
 	"encoding/hex"
 	"encoding/json"
@@ -44,7 +43,7 @@ const (
 // info was added to the database.
 func TestAddProof(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	ctx := createTestCtxSingleNode(t, 0)
 
@@ -109,7 +108,7 @@ func TestIgnoreNodeAnnouncement(t *testing.T) {
 	}
 	copy(node.PubKeyBytes[:], pub.SerializeCompressed())
 
-	err := ctx.builder.AddNode(context.Background(), node)
+	err := ctx.builder.AddNode(t.Context(), node)
 	if !IsError(err, ErrIgnored) {
 		t.Fatalf("expected to get ErrIgnore, instead got: %v", err)
 	}
@@ -119,7 +118,7 @@ func TestIgnoreNodeAnnouncement(t *testing.T) {
 // ignore a channel policy for a channel not in the graph.
 func TestIgnoreChannelEdgePolicyForUnknownChannel(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 
@@ -194,7 +193,7 @@ func TestIgnoreChannelEdgePolicyForUnknownChannel(t *testing.T) {
 // confirmed on the stale chain, and resync to the main chain.
 func TestWakeUpOnStaleBranch(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -354,7 +353,7 @@ func TestWakeUpOnStaleBranch(t *testing.T) {
 	// Give time to process new blocks.
 	time.Sleep(time.Millisecond * 500)
 
-	selfNode, err := ctx.graph.SourceNode(context.Background())
+	selfNode, err := ctx.graph.SourceNode(t.Context())
 	require.NoError(t, err)
 
 	// Create new router with same graph database.
@@ -408,7 +407,7 @@ func TestWakeUpOnStaleBranch(t *testing.T) {
 // it is active.
 func TestDisconnectedBlocks(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -609,7 +608,7 @@ func TestDisconnectedBlocks(t *testing.T) {
 // ChannelRouter, then the channels are properly pruned.
 func TestChansClosedOfflinePruneGraph(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -1037,7 +1036,7 @@ func testPruneChannelGraphDoubleDisabled(t *testing.T, assumeValid bool) {
 // node announcements.
 func TestIsStaleNode(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -1095,7 +1094,7 @@ func TestIsStaleNode(t *testing.T) {
 		Features:             testFeatures,
 	}
 	copy(n1.PubKeyBytes[:], priv1.PubKey().SerializeCompressed())
-	if err := ctx.builder.AddNode(context.Background(), n1); err != nil {
+	if err := ctx.builder.AddNode(t.Context(), n1); err != nil {
 		t.Fatalf("could not add node: %v", err)
 	}
 
@@ -1117,7 +1116,7 @@ func TestIsStaleNode(t *testing.T) {
 // channel announcements.
 func TestIsKnownEdge(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -1167,7 +1166,7 @@ func TestIsKnownEdge(t *testing.T) {
 // stale channel edge update announcements.
 func TestIsStaleEdgePolicy(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxFromFile(t, startingBlockHeight, basicGraphFilePath)
@@ -1359,7 +1358,7 @@ func createTestCtxFromFile(t *testing.T,
 func parseTestGraph(t *testing.T, useCache bool, path string) (
 	*testGraphInstance, error) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graphJSON, err := os.ReadFile(path)
 	if err != nil {
@@ -1751,7 +1750,7 @@ func createTestGraphFromChannels(t *testing.T, useCache bool,
 	testChannels []*testChannel, source string) (*testGraphInstance,
 	error) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll use this fake address for the IP address of all the nodes in
 	// our tests. This value isn't needed for path finding so it doesn't

graph/db/benchmark_test.go

@@ -189,7 +189,7 @@ func sqlSQLite(t testing.TB, dbPath, file string) BatchedSQLQueries {
 // database for testing purposes.
 func kvdbPostgres(t testing.TB, dsn string) kvdb.Backend {
 	kvStore, err := kvdb.Open(
-		kvdb.PostgresBackendName, context.Background(),
+		kvdb.PostgresBackendName, t.Context(),
 		&postgres.Config{
 			Dsn:            dsn,
 			MaxConnections: testMaxPostgresConnections,
@@ -217,7 +217,7 @@ func connectKVDBPostgres(t testing.TB, dsn string) V1Store {
 func kvdbSqlite(t testing.TB, dbPath, fileName string) kvdb.Backend {
 	sqlbase.Init(testMaxSQLiteConnections)
 	kvStore, err := kvdb.Open(
-		kvdb.SqliteBackendName, context.Background(),
+		kvdb.SqliteBackendName, t.Context(),
 		&sqlite.Config{
 			BusyTimeout:    testSQLBusyTimeout,
 			MaxConnections: testMaxSQLiteConnections,
@@ -273,7 +273,7 @@ func newKVStore(t testing.TB, backend kvdb.Backend) V1Store {
 // provided sqldb.DB instance.
 func newSQLExecutor(t testing.TB, db sqldb.DB) BatchedSQLQueries {
 	err := db.ApplyAllMigrations(
-		context.Background(), sqldb.GetMigrations(),
+		t.Context(), sqldb.GetMigrations(),
 	)
 	require.NoError(t, err)
 
@@ -317,7 +317,7 @@ func newSQLStore(t testing.TB, cfg *sqldb.QueryConfig,
 //     very long to sync the graph.
 func TestPopulateDBs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// NOTE: uncomment the line below to run this test locally, then provide
 	// the desired source database (and make sure the destination Postgres
@@ -539,7 +539,7 @@ func TestPopulateViaMigration(t *testing.T) {
 
 	// Use the graph migration to populate the SQL graph from the
 	// kvdb graph.
-	ctx := context.Background()
+	ctx := t.Context()
 	err := dstSQL.ExecTx(
 		ctx, sqldb.WriteTxOpt(), func(queries SQLQueries) error {
 			return MigrateGraphToSQL(
@@ -556,7 +556,7 @@ func TestPopulateViaMigration(t *testing.T) {
 // syncGraph synchronizes the source graph with the destination graph by
 // copying all nodes and channels from the source to the destination.
 func syncGraph(t *testing.T, src, dest *ChannelGraph) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	var (
 		s = rate.Sometimes{
@@ -683,7 +683,7 @@ func syncGraph(t *testing.T, src, dest *ChannelGraph) {
 // NOTE: the TestPopulateDBs test helper can be used to populate a set of test
 // DBs from a single source db.
 func BenchmarkCacheLoading(b *testing.B) {
-	ctx := context.Background()
+	ctx := b.Context()
 
 	tests := []dbConnection{
 		kvdbBBoltConn,
@@ -723,7 +723,7 @@ func BenchmarkCacheLoading(b *testing.B) {
 // NOTE: the TestPopulateDBs test helper can be used to populate a set of test
 // DBs from a single source db.
 func BenchmarkGraphReadMethods(b *testing.B) {
-	ctx := context.Background()
+	ctx := b.Context()
 
 	backends := []dbConnection{
 		kvdbBBoltConn,
@@ -900,7 +900,7 @@ func BenchmarkFindOptimalSQLQueryConfig(b *testing.B) {
 	for _, size := range testSizes {
 		b.Run(fmt.Sprintf("%s-%s-%d", configOption, dbName, size),
 			func(b *testing.B) {
-				ctx := context.Background()
+				ctx := b.Context()
 
 				cfg := sqldb.DefaultSQLiteConfig()
 				if testPostgres {

graph/db/graph_test.go

@@ -100,7 +100,7 @@ func createTestVertex(t testing.TB) *models.LightningNode {
 // TestNodeInsertionAndDeletion tests the CRUD operations for a LightningNode.
 func TestNodeInsertionAndDeletion(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -276,7 +276,7 @@ func TestNodeInsertionAndDeletion(t *testing.T) {
 // only the pubkey is known to the database.
 func TestPartialNode(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -344,7 +344,7 @@ func TestPartialNode(t *testing.T) {
 // TestAliasLookup tests the alias lookup functionality of the graph store.
 func TestAliasLookup(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -375,7 +375,7 @@ func TestAliasLookup(t *testing.T) {
 // TestSourceNode tests the source node functionality of the graph store.
 func TestSourceNode(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -402,7 +402,7 @@ func TestSourceNode(t *testing.T) {
 // TestEdgeInsertionDeletion tests the basic CRUD operations for channel edges.
 func TestEdgeInsertionDeletion(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -527,7 +527,7 @@ func createEdge(height, txIndex uint32, txPosition uint16, outPointIndex uint32,
 // database is what we expect after calling DisconnectBlockAtHeight.
 func TestDisconnectBlockAtHeight(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -818,7 +818,7 @@ func createChannelEdge(node1, node2 *models.LightningNode,
 
 func TestEdgeInfoUpdates(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -914,7 +914,7 @@ func TestEdgeInfoUpdates(t *testing.T) {
 // TestEdgePolicyCRUD tests basic CRUD operations for edge policies.
 func TestEdgePolicyCRUD(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1208,7 +1208,7 @@ func newEdgePolicy(chanID uint64, updateTime int64) *models.ChannelEdgePolicy {
 // TestAddEdgeProof tests the ability to add an edge proof to an existing edge.
 func TestAddEdgeProof(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1267,7 +1267,7 @@ func TestAddEdgeProof(t *testing.T) {
 // correctly iterates through the channels of the set source node.
 func TestForEachSourceNodeChannel(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1356,7 +1356,7 @@ func TestForEachSourceNodeChannel(t *testing.T) {
 
 func TestGraphTraversal(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1455,7 +1455,7 @@ func TestGraphTraversal(t *testing.T) {
 // working correctly.
 func TestGraphTraversalCacheable(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1582,7 +1582,7 @@ func TestGraphCacheTraversal(t *testing.T) {
 func fillTestGraph(t testing.TB, graph *ChannelGraph, numNodes,
 	numChannels int) (map[uint64]struct{}, []*models.LightningNode) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	nodes := make([]*models.LightningNode, numNodes)
 	nodeIndex := map[string]struct{}{}
@@ -1694,7 +1694,7 @@ func assertPruneTip(t *testing.T, graph *ChannelGraph,
 func assertNumChans(t *testing.T, graph *ChannelGraph, n int) {
 	numChans := 0
 	err := graph.ForEachChannel(
-		context.Background(), func(*models.ChannelEdgeInfo,
+		t.Context(), func(*models.ChannelEdgeInfo,
 			*models.ChannelEdgePolicy,
 			*models.ChannelEdgePolicy) error {
 
@@ -1710,7 +1710,7 @@ func assertNumChans(t *testing.T, graph *ChannelGraph, n int) {
 
 func assertNumNodes(t *testing.T, graph *ChannelGraph, n int) {
 	numNodes := 0
-	err := graph.ForEachNode(context.Background(),
+	err := graph.ForEachNode(t.Context(),
 		func(_ *models.LightningNode) error {
 			numNodes++
 
@@ -1772,7 +1772,7 @@ func assertChanViewEqualChanPoints(t *testing.T, a []EdgePoint,
 
 func TestGraphPruning(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -1963,7 +1963,7 @@ func TestGraphPruning(t *testing.T) {
 // known channel ID in the database.
 func TestHighestChanID(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -2023,7 +2023,7 @@ func TestHighestChanID(t *testing.T) {
 // insertion of a new edge, the edge update index is updated properly.
 func TestChanUpdatesInHorizon(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -2181,7 +2181,7 @@ func TestChanUpdatesInHorizon(t *testing.T) {
 // the most recent node updates within a particular time horizon.
 func TestNodeUpdatesInHorizon(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -2352,7 +2352,7 @@ func TestFilterKnownChanIDsZombieRevival(t *testing.T) {
 // know of on disk.
 func TestFilterKnownChanIDs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -2535,7 +2535,7 @@ func TestStressTestChannelGraphAPI(t *testing.T) {
 		t.Skipf("Skipping test in short mode")
 	}
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -2824,7 +2824,7 @@ func TestStressTestChannelGraphAPI(t *testing.T) {
 // set of short channel ID's for a given block range.
 func TestFilterChannelRange(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3043,7 +3043,7 @@ func TestFilterChannelRange(t *testing.T) {
 // of ChannelEdge structs for a given set of short channel ID's.
 func TestFetchChanInfos(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3146,7 +3146,7 @@ func TestFetchChanInfos(t *testing.T) {
 // both sides.
 func TestIncompleteChannelPolicies(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3239,7 +3239,7 @@ func TestIncompleteChannelPolicies(t *testing.T) {
 // up.
 func TestChannelEdgePruningUpdateIndexDeletion(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3387,7 +3387,7 @@ func TestChannelEdgePruningUpdateIndexDeletion(t *testing.T) {
 // PruneSyncState method.
 func TestPruneGraphNodes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3453,7 +3453,7 @@ func TestPruneGraphNodes(t *testing.T) {
 // database, then shell edges are created for each node if needed.
 func TestAddChannelEdgeShellNodes(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3492,7 +3492,7 @@ func TestAddChannelEdgeShellNodes(t *testing.T) {
 // well.
 func TestNodePruningUpdateIndexDeletion(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3553,7 +3553,7 @@ func nextUpdateTime() time.Time {
 // public within the network graph.
 func TestNodeIsPublic(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll start off the test by creating a small network of 3
 	// participants with the following graph:
@@ -3688,7 +3688,7 @@ func TestNodeIsPublic(t *testing.T) {
 // DisabledChannelIDs is correct.
 func TestDisabledChannelIDs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3773,7 +3773,7 @@ func TestDisabledChannelIDs(t *testing.T) {
 // receive the proper update.
 func TestEdgePolicyMissingMaxHTLC(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -3916,7 +3916,7 @@ func assertNumZombies(t *testing.T, graph *ChannelGraph, expZombies uint64) {
 // TestGraphZombieIndex ensures that we can mark edges correctly as zombie/live.
 func TestGraphZombieIndex(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll start by creating our test graph along with a test edge.
 	graph := MakeTestGraph(t)
@@ -4103,7 +4103,7 @@ func TestComputeFee(t *testing.T) {
 // executes multiple AddChannelEdge requests in a single txn.
 func TestBatchedAddChannelEdge(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -4180,7 +4180,7 @@ func TestBatchedAddChannelEdge(t *testing.T) {
 // executes multiple UpdateEdgePolicy requests in a single txn.
 func TestBatchedUpdateEdgePolicy(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -4233,7 +4233,7 @@ func TestBatchedUpdateEdgePolicy(t *testing.T) {
 // allocations and the total memory consumed by the full graph traversal.
 func BenchmarkForEachChannel(b *testing.B) {
 	graph := MakeTestGraph(b)
-	ctx := context.Background()
+	ctx := b.Context()
 
 	const numNodes = 100
 	const numChannels = 4
@@ -4286,7 +4286,7 @@ func BenchmarkForEachChannel(b *testing.B) {
 // method works as expected, and is able to handle nil self edges.
 func TestGraphCacheForEachNodeChannel(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graph := MakeTestGraph(t)
 
@@ -4448,7 +4448,7 @@ var testNodeAnn = "01012674c2e7ef68c73a086b7de2603f4ef1567358df84bb4edaa06c" +
 // that the two messages are equal.
 func TestLightningNodePersistence(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create a new test graph instance.
 	graph := MakeTestGraph(t)

graph/db/sql_migration_test.go

@@ -5,7 +5,6 @@ package graphdb
 import (
 	"bytes"
 	"cmp"
-	"context"
 	"crypto/rand"
 	"errors"
 	"fmt"
@@ -65,7 +64,7 @@ var (
 // ensure that the migration can handle this.
 func TestMigrateGraphToSQL(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	dbFixture := NewTestDBFixture(t)
 
@@ -459,7 +458,7 @@ func assertInSync(t *testing.T, kvDB *KVStore, sqlDB *SQLStore,
 func fetchAllNodes(t *testing.T, store V1Store) []*models.LightningNode {
 	nodes := make([]*models.LightningNode, 0)
 
-	err := store.ForEachNode(context.Background(),
+	err := store.ForEachNode(t.Context(),
 		func(node *models.LightningNode) error {
 
 			// Call PubKey to ensure the objects cached pubkey is set so that
@@ -489,7 +488,7 @@ func fetchAllNodes(t *testing.T, store V1Store) []*models.LightningNode {
 
 // fetchSourceNode retrieves the source node from the given store.
 func fetchSourceNode(t *testing.T, store V1Store) *models.LightningNode {
-	node, err := store.SourceNode(context.Background())
+	node, err := store.SourceNode(t.Context())
 	if errors.Is(err, ErrSourceNodeNotSet) {
 		return nil
 	} else {
@@ -527,7 +526,7 @@ func (c chanSet) CountPolicies() int {
 // fetchAllChannelsAndPolicies retrieves all channels and their policies
 // from the given store and returns them sorted by their channel ID.
 func fetchAllChannelsAndPolicies(t *testing.T, store V1Store) chanSet {
-	ctx := context.Background()
+	ctx := t.Context()
 	channels := make(chanSet, 0)
 	err := store.ForEachChannel(ctx, func(info *models.ChannelEdgeInfo,
 		p1 *models.ChannelEdgePolicy,
@@ -572,7 +571,7 @@ func checkKVPruneLogEntries(t *testing.T, kv *KVStore, sql *SQLStore,
 	err := forEachPruneLogEntry(
 		kv.db, func(height uint32, hash *chainhash.Hash) error {
 			sqlHash, err := sql.db.GetPruneHashByHeight(
-				context.Background(), int64(height),
+				t.Context(), int64(height),
 			)
 			require.NoError(t, err)
 			require.Equal(t, hash[:], sqlHash)
@@ -804,7 +803,7 @@ func makeTestPolicy(chanID uint64, toNode route.Vertex, isNode1 bool,
 // and set the "fileName" variable to the name of the channel database file you
 // want to use for the migration test.
 func TestMigrationWithChannelDB(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// NOTE: comment this line out to run the test.
 	t.Skipf("skipping test meant for local debugging only")
@@ -923,7 +922,7 @@ func TestMigrationWithChannelDB(t *testing.T) {
 // will differ slightly.
 func TestSQLMigrationEdgeCases(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	var invalidTLVData = []byte{0x01, 0x02, 0x03}
 
@@ -1183,7 +1182,7 @@ func TestSQLMigrationEdgeCases(t *testing.T) {
 func runTestMigration(t *testing.T, populateKV func(t *testing.T, db *KVStore),
 	expState dbState) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Set up our source kvdb DB.
 	kvDB := setUpKVStore(t)
@@ -1278,7 +1277,7 @@ func TestMigrateGraphToSQLRapid(t *testing.T) {
 func testMigrateGraphToSQLRapidOnce(t *testing.T, rt *rapid.T,
 	dbFixture *sqldb.TestPgFixture, maxNumNodes, maxNumChannels int) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Set up our source kvdb DB.
 	kvDB := setUpKVStore(t)

graph/notifications_test.go

@@ -2,7 +2,6 @@ package graph
 
 import (
 	"bytes"
-	"context"
 	"encoding/hex"
 	"fmt"
 	"image/color"
@@ -422,7 +421,7 @@ func (m *mockChainView) FilterBlock(blockHash *chainhash.Hash) (*chainview.Filte
 // a proper notification is sent of to all registered clients.
 func TestEdgeUpdateNotification(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	ctx := createTestCtxSingleNode(t, 0)
 
@@ -611,7 +610,7 @@ func TestEdgeUpdateNotification(t *testing.T) {
 // attributes with new data.
 func TestNodeUpdateNotification(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -795,7 +794,7 @@ func TestNodeUpdateNotification(t *testing.T) {
 // when the client wishes to exit.
 func TestNotificationCancellation(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -879,7 +878,7 @@ func TestNotificationCancellation(t *testing.T) {
 // properly dispatched to all registered clients.
 func TestChannelCloseNotification(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxSingleNode(t, startingBlockHeight)
@@ -1067,7 +1066,7 @@ func createTestCtxSingleNode(t *testing.T,
 	sourceNode := createTestNode(t)
 
 	require.NoError(t,
-		graph.SetSourceNode(context.Background(), sourceNode),
+		graph.SetSourceNode(t.Context(), sourceNode),
 		"failed to set source node",
 	)
 
@@ -1083,7 +1082,7 @@ func createTestCtxSingleNode(t *testing.T,
 func (c *testCtx) RestartBuilder(t *testing.T) {
 	c.chainView.Reset()
 
-	selfNode, err := c.graph.SourceNode(context.Background())
+	selfNode, err := c.graph.SourceNode(t.Context())
 	require.NoError(t, err)
 
 	// With the chainView reset, we'll now re-create the builder itself, and
@@ -1156,7 +1155,7 @@ func createTestCtxFromGraphInstanceAssumeValid(t *testing.T,
 		ConfChan:  make(chan *chainntnfs.TxConfirmation),
 	}
 
-	selfnode, err := graphInstance.graph.SourceNode(context.Background())
+	selfnode, err := graphInstance.graph.SourceNode(t.Context())
 	require.NoError(t, err)
 
 	graphBuilder, err := NewBuilder(&Config{

healthcheck/go.mod

@@ -24,4 +24,4 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
-go 1.23.12
+go 1.24.6

htlcswitch/link.go

@@ -1801,7 +1801,7 @@ func (l *channelLink) handleUpstreamMsg(ctx context.Context,
 	case *lnwire.Stfu:
 		err = l.handleStfu(msg)
 		if err != nil {
-			l.stfuFailf("handleStfu: %v", err.Error())
+			l.stfuFailf("handleStfu: %v", err)
 		}
 
 	// In the case where we receive a warning message from our peer, just
@@ -3126,7 +3126,7 @@ func (l *channelLink) processRemoteAdds(fwdPkg *channeldb.FwdPkg) {
 			if err != nil {
 				l.failf(LinkFailureError{
 					code: ErrInternalError,
-				}, err.Error()) //nolint
+				}, "%v", err)
 
 				return
 			}
@@ -3795,7 +3795,7 @@ func (l *channelLink) handleQuiescenceReq(req StfuReq) error {
 
 	err := l.quiescer.SendOwedStfu()
 	if err != nil {
-		l.stfuFailf("SendOwedStfu: %s", err.Error())
+		l.stfuFailf("SendOwedStfu: %v", err)
 		res := fn.Err[lntypes.ChannelParty](err)
 		req.Resolve(res)
 	}
@@ -3989,7 +3989,7 @@ func (l *channelLink) processRemoteUpdateAddHTLC(
 				FailureAction:    LinkFailureDisconnect,
 				PermanentFailure: false,
 				Warning:          true,
-			}, err.Error(),
+			}, "%v", err,
 		)
 
 		return err
@@ -4004,7 +4004,7 @@ func (l *channelLink) processRemoteUpdateAddHTLC(
 		err := errors.New("blinding point included when route " +
 			"blinding is disabled")
 
-		l.failf(LinkFailureError{code: ErrInvalidUpdate}, err.Error())
+		l.failf(LinkFailureError{code: ErrInvalidUpdate}, "%v", err)
 
 		return err
 	}
@@ -4015,7 +4015,7 @@ func (l *channelLink) processRemoteUpdateAddHTLC(
 	if l.isOverexposedWithHtlc(msg, true) {
 		err := errors.New("peer sent us an HTLC that exceeded our " +
 			"max fee exposure")
-		l.failf(LinkFailureError{code: ErrInternalError}, err.Error())
+		l.failf(LinkFailureError{code: ErrInternalError}, "%v", err)
 
 		return err
 	}
@@ -4059,7 +4059,7 @@ func (l *channelLink) processRemoteUpdateFulfillHTLC(
 
 	if !lockedin {
 		err := errors.New("unable to handle upstream settle")
-		l.failf(LinkFailureError{code: ErrInvalidUpdate}, err.Error())
+		l.failf(LinkFailureError{code: ErrInvalidUpdate}, "%v", err)
 
 		return err
 	}
@@ -4367,7 +4367,7 @@ func (l *channelLink) processRemoteCommitSig(ctx context.Context,
 	if l.noDanglingUpdates(lntypes.Local) {
 		err = l.quiescer.SendOwedStfu()
 		if err != nil {
-			l.stfuFailf("sendOwedStfu: %v", err.Error())
+			l.stfuFailf("sendOwedStfu: %v", err)
 		}
 	}
 

htlcswitch/link_isolated_test.go

@@ -95,7 +95,7 @@ func (l *linkTestContext) receiveHtlcAliceToBob() {
 func (l *linkTestContext) sendCommitSigBobToAlice(expHtlcs int) {
 	l.t.Helper()
 
-	testQuit, testQuitFunc := context.WithCancel(context.Background())
+	testQuit, testQuitFunc := context.WithCancel(l.t.Context())
 	defer testQuitFunc()
 	sigs, err := l.bobChannel.SignNextCommitment(testQuit)
 	if err != nil {

htlcswitch/link_test.go

@@ -498,7 +498,7 @@ func TestChannelLinkSingleHopPayment(t *testing.T) {
 	// Check that alice invoice was settled and bandwidth of HTLC
 	// links was changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State != invpkg.ContractSettled {
@@ -618,7 +618,7 @@ func testChannelLinkMultiHopPayment(t *testing.T,
 	// Check that Carol invoice was settled and bandwidth of HTLC
 	// links were changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State != invpkg.ContractSettled {
@@ -811,7 +811,7 @@ func testChannelLinkInboundFee(t *testing.T, //nolint:thelper
 	// Check that Carol invoice was settled and bandwidth of HTLC
 	// links were changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	require.Equal(t, invpkg.ContractSettled, invoice.State,
@@ -929,7 +929,7 @@ func TestChannelLinkCancelFullCommitment(t *testing.T) {
 		// to settle.
 		err = wait.NoError(func() error {
 			return n.bobServer.registry.SettleHodlInvoice(
-				context.Background(), preimage,
+				t.Context(), preimage,
 			)
 		}, time.Minute)
 		if err != nil {
@@ -1397,7 +1397,7 @@ func TestUpdateForwardingPolicy(t *testing.T) {
 	// Carol's invoice should now be shown as settled as the payment
 	// succeeded.
 	invoice, err := n.carolServer.registry.LookupInvoice(
-		context.Background(), payResp,
+		t.Context(), payResp,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State != invpkg.ContractSettled {
@@ -1553,7 +1553,7 @@ func TestChannelLinkMultiHopInsufficientPayment(t *testing.T) {
 	// Check that alice invoice wasn't settled and bandwidth of htlc
 	// links hasn't been changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State == invpkg.ContractSettled {
@@ -1733,7 +1733,7 @@ func TestChannelLinkMultiHopUnknownNextHop(t *testing.T) {
 	// Check that alice invoice wasn't settled and bandwidth of htlc
 	// links hasn't been changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State == invpkg.ContractSettled {
@@ -1843,7 +1843,7 @@ func TestChannelLinkMultiHopDecodeError(t *testing.T) {
 	// Check that alice invoice wasn't settled and bandwidth of htlc
 	// links hasn't been changed.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State == invpkg.ContractSettled {
@@ -2716,7 +2716,7 @@ func TestChannelLinkBandwidthConsistency(t *testing.T) {
 	)
 	require.NoError(t, err, "unable to create payment")
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	// We must add the invoice to the registry, such that Alice expects
 	// this payment.
 	err = coreLink.cfg.Registry.(*mockInvoiceRegistry).AddInvoice(
@@ -4067,7 +4067,7 @@ func TestChannelRetransmission(t *testing.T) {
 			// Check that alice invoice wasn't settled and
 			// bandwidth of htlc links hasn't been changed.
 			invoice, err = receiver.registry.LookupInvoice(
-				context.Background(), rhash,
+				t.Context(), rhash,
 			)
 			if err != nil {
 				err = fmt.Errorf(
@@ -4552,7 +4552,7 @@ func TestChannelLinkAcceptDuplicatePayment(t *testing.T) {
 	}
 
 	err = n.carolServer.registry.AddInvoice(
-		context.Background(), *invoice, htlc.PaymentHash,
+		t.Context(), *invoice, htlc.PaymentHash,
 	)
 	require.NoError(t, err, "unable to add invoice in carol registry")
 
@@ -4642,7 +4642,7 @@ func TestChannelLinkAcceptOverpay(t *testing.T) {
 	// Even though we sent 2x what was asked for, Carol should still have
 	// accepted the payment and marked it as settled.
 	invoice, err := receiver.registry.LookupInvoice(
-		context.Background(), rhash,
+		t.Context(), rhash,
 	)
 	require.NoError(t, err, "unable to get invoice")
 	if invoice.State != invpkg.ContractSettled {
@@ -4973,7 +4973,7 @@ func generateHtlc(t *testing.T, coreLink *channelLink,
 	// We must add the invoice to the registry, such that Alice
 	// expects this payment.
 	err := coreLink.cfg.Registry.(*mockInvoiceRegistry).AddInvoice(
-		context.Background(), *invoice, htlc.PaymentHash,
+		t.Context(), *invoice, htlc.PaymentHash,
 	)
 	require.NoError(t, err, "unable to add invoice to registry")
 
@@ -5933,7 +5933,7 @@ func TestChannelLinkFail(t *testing.T) {
 				// Sign a commitment that will include
 				// signature for the HTLC just sent.
 				quitCtx, done := c.cg.Create(
-					context.Background(),
+					t.Context(),
 				)
 				defer done()
 
@@ -5982,7 +5982,7 @@ func TestChannelLinkFail(t *testing.T) {
 				// Sign a commitment that will include
 				// signature for the HTLC just sent.
 				quitCtx, done := c.cg.Create(
-					context.Background(),
+					t.Context(),
 				)
 				defer done()
 
@@ -6388,7 +6388,7 @@ func TestChannelLinkCanceledInvoice(t *testing.T) {
 
 	// Cancel the invoice at bob's end.
 	hash := invoice.Terms.PaymentPreimage.Hash()
-	err = n.bobServer.registry.CancelInvoice(context.Background(), hash)
+	err = n.bobServer.registry.CancelInvoice(t.Context(), hash)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -6506,7 +6506,7 @@ func TestChannelLinkHoldInvoiceSettle(t *testing.T) {
 	}
 
 	err = ctx.n.bobServer.registry.SettleHodlInvoice(
-		context.Background(), ctx.preimage,
+		t.Context(), ctx.preimage,
 	)
 	if err != nil {
 		t.Fatal(err)
@@ -6552,7 +6552,7 @@ func TestChannelLinkHoldInvoiceCancel(t *testing.T) {
 	}
 
 	err = ctx.n.bobServer.registry.CancelInvoice(
-		context.Background(), ctx.hash,
+		t.Context(), ctx.hash,
 	)
 	if err != nil {
 		t.Fatal(err)
@@ -6608,7 +6608,7 @@ func TestChannelLinkHoldInvoiceRestart(t *testing.T) {
 	// We must add the invoice to the registry, such that Alice
 	// expects this payment.
 	err = registry.AddInvoice(
-		context.Background(), *invoice, htlc.PaymentHash,
+		t.Context(), *invoice, htlc.PaymentHash,
 	)
 	require.NoError(t, err, "unable to add invoice to registry")
 
@@ -6644,7 +6644,7 @@ func TestChannelLinkHoldInvoiceRestart(t *testing.T) {
 	<-registry.settleChan
 
 	// Settle the invoice with the preimage.
-	err = registry.SettleHodlInvoice(context.Background(), *preimage)
+	err = registry.SettleHodlInvoice(t.Context(), *preimage)
 	require.NoError(t, err, "settle hodl invoice")
 
 	// Expect alice to send a settle and commitsig message to bob.
@@ -6703,7 +6703,7 @@ func TestChannelLinkRevocationWindowRegular(t *testing.T) {
 	htlc1, invoice1 := generateHtlcAndInvoice(t, 0)
 	htlc2, invoice2 := generateHtlcAndInvoice(t, 1)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	// We must add the invoice to the registry, such that Alice
 	// expects this payment.
 	err = registry.AddInvoice(ctxb, *invoice1, htlc1.PaymentHash)
@@ -6789,7 +6789,7 @@ func TestChannelLinkRevocationWindowHodl(t *testing.T) {
 	invoice2.Terms.PaymentPreimage = nil
 	invoice2.HodlInvoice = true
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	// We must add the invoices to the registry, such that Alice
 	// expects the payments.
 	err = registry.AddInvoice(ctxb, *invoice1, htlc1.PaymentHash)
@@ -7106,7 +7106,7 @@ func TestPipelineSettle(t *testing.T) {
 	// Add the invoice to Alice's registry so she expects it.
 	aliceReg := alice.coreLink.cfg.Registry.(*mockInvoiceRegistry)
 	err = aliceReg.AddInvoice(
-		context.Background(), *invoice1, htlc1.PaymentHash,
+		t.Context(), *invoice1, htlc1.PaymentHash,
 	)
 	require.NoError(t, err)
 

htlcswitch/switch_test.go

@@ -1,7 +1,6 @@
 package htlcswitch
 
 import (
-	"context"
 	"crypto/rand"
 	"crypto/sha256"
 	"errors"
@@ -1087,11 +1086,11 @@ func TestSwitchForwardFailAfterFullAdd(t *testing.T) {
 	// Now we will restart bob, leaving the forwarding decision for this
 	// htlc is in the half-added state.
 	if err := s.Stop(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	if err := cdb.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb2 := channeldb.OpenForTesting(t, tempPath)
@@ -1139,7 +1138,7 @@ func TestSwitchForwardFailAfterFullAdd(t *testing.T) {
 
 	// Send the fail packet from the remote peer through the switch.
 	if err := s2.ForwardPackets(nil, fail); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	// Pull packet from alice's link, as it should have gone through
@@ -1273,11 +1272,11 @@ func TestSwitchForwardSettleAfterFullAdd(t *testing.T) {
 	// Now we will restart bob, leaving the forwarding decision for this
 	// htlc is in the half-added state.
 	if err := s.Stop(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	if err := cdb.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb2 := channeldb.OpenForTesting(t, tempPath)
@@ -1327,7 +1326,7 @@ func TestSwitchForwardSettleAfterFullAdd(t *testing.T) {
 
 	// Send the settle packet from the remote peer through the switch.
 	if err := s2.ForwardPackets(nil, settle); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	// Pull packet from alice's link, as it should have gone through
@@ -1454,11 +1453,11 @@ func TestSwitchForwardDropAfterFullAdd(t *testing.T) {
 	// Now we will restart bob, leaving the forwarding decision for this
 	// htlc is in the half-added state.
 	if err := s.Stop(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	if err := cdb.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb2 := channeldb.OpenForTesting(t, tempPath)
@@ -1601,11 +1600,11 @@ func TestSwitchForwardFailAfterHalfAdd(t *testing.T) {
 	// Now we will restart bob, leaving the forwarding decision for this
 	// htlc is in the half-added state.
 	if err := s.Stop(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	if err := cdb.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb2 := channeldb.OpenForTesting(t, tempPath)
@@ -1753,11 +1752,11 @@ func TestSwitchForwardCircuitPersistence(t *testing.T) {
 	}
 
 	if err := s.Stop(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	if err := cdb.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb2 := channeldb.OpenForTesting(t, tempPath)
@@ -1847,7 +1846,7 @@ func TestSwitchForwardCircuitPersistence(t *testing.T) {
 	}
 
 	if err := cdb2.Close(); err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 
 	cdb3 := channeldb.OpenForTesting(t, tempPath)
@@ -3547,7 +3546,7 @@ func (n *threeHopNetwork) sendThreeHopPayment(t *testing.T) (*lnwire.UpdateAddHT
 	}
 
 	err = n.carolServer.registry.AddInvoice(
-		context.Background(), *invoice, htlc.PaymentHash,
+		t.Context(), *invoice, htlc.PaymentHash,
 	)
 	require.NoError(t, err, "unable to add invoice in carol registry")
 
@@ -3869,7 +3868,7 @@ func (c *interceptableSwitchTestContext) createTestPacket() *htlcPacket {
 
 func (c *interceptableSwitchTestContext) finish() {
 	if err := c.s.Stop(); err != nil {
-		c.t.Fatalf(err.Error())
+		c.t.Fatal(err)
 	}
 }
 

invoices/invoiceregistry_test.go

@@ -1,7 +1,6 @@
 package invoices_test
 
 import (
-	"context"
 	"crypto/rand"
 	"database/sql"
 	"fmt"
@@ -194,7 +193,7 @@ func testSettleInvoice(t *testing.T,
 
 	ctx := newTestContext(t, nil, makeDB)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.Nil(t, err)
 	defer allSubscriptions.Cancel()
@@ -383,7 +382,7 @@ func testCancelInvoiceImpl(t *testing.T, gc bool,
 	cfg.GcCanceledInvoicesOnTheFly = gc
 	ctx := newTestContext(t, &cfg, makeDB)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.Nil(t, err)
 	defer allSubscriptions.Cancel()
@@ -547,7 +546,7 @@ func testSettleHoldInvoice(t *testing.T,
 	require.NoError(t, err)
 	defer registry.Stop()
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	allSubscriptions, err := registry.SubscribeNotifications(ctxb, 0, 0)
 	require.Nil(t, err)
 	defer allSubscriptions.Cancel()
@@ -720,7 +719,7 @@ func testCancelHoldInvoice(t *testing.T,
 		require.NoError(t, registry.Stop())
 	})
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Add the invoice.
 	invoice := newInvoice(t, true, false)
@@ -824,7 +823,7 @@ func testKeySendImpl(t *testing.T, keySendEnabled bool,
 	ctx := newTestContext(t, &cfg, makeDB)
 
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(
-		context.Background(), 0, 0,
+		t.Context(), 0, 0,
 	)
 	require.NoError(t, err)
 	defer allSubscriptions.Cancel()
@@ -959,7 +958,7 @@ func testHoldKeysendImpl(t *testing.T, timeoutKeysend bool,
 	cfg.KeysendHoldTime = holdDuration
 	ctx := newTestContext(t, &cfg, makeDB)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.NoError(t, err)
 	defer allSubscriptions.Cancel()
@@ -1047,7 +1046,7 @@ func testMppPayment(t *testing.T,
 	defer timeout()()
 
 	ctx := newTestContext(t, nil, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Add the invoice.
 	testInvoice := newInvoice(t, false, false)
@@ -1143,7 +1142,7 @@ func testMppPaymentWithOverpayment(t *testing.T,
 
 	t.Parallel()
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	f := func(overpaymentRand uint64) bool {
 		ctx := newTestContext(t, nil, makeDB)
 
@@ -1241,7 +1240,7 @@ func testInvoiceExpiryWithRegistry(t *testing.T,
 		t, testTime, 0, numExpired, numPending,
 	)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	var expectedCancellations []lntypes.Hash
 	expiredInvoices := existingInvoices.expiredInvoices
@@ -1351,7 +1350,7 @@ func testOldInvoiceRemovalOnStart(t *testing.T,
 		t, testTime, 0, numExpired, numPending,
 	)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	i := 0
 	for paymentHash, invoice := range existingInvoices.expiredInvoices {
@@ -1443,7 +1442,7 @@ func testHeightExpiryWithRegistryImpl(t *testing.T, numParts int, settle bool,
 	testInvoice.HodlInvoice = true
 	testInvoice.PaymentRequest = []byte{1, 2, 3}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err := ctx.registry.AddInvoice(
 		ctxb, testInvoice, testInvoicePaymentHash,
 	)
@@ -1554,7 +1553,7 @@ func testMultipleSetHeightExpiry(t *testing.T,
 	// Add a hold invoice.
 	testInvoice := newInvoice(t, true, false)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err := ctx.registry.AddInvoice(
 		ctxb, testInvoice, testInvoicePaymentHash,
 	)
@@ -1646,7 +1645,7 @@ func testSettleInvoicePaymentAddrRequired(t *testing.T,
 	t.Parallel()
 
 	ctx := newTestContext(t, nil, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.NoError(t, err)
@@ -1738,7 +1737,7 @@ func testSettleInvoicePaymentAddrRequiredOptionalGrace(t *testing.T,
 	t.Parallel()
 
 	ctx := newTestContext(t, nil, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.NoError(t, err)
@@ -1946,7 +1945,7 @@ func testSpontaneousAmpPaymentImpl(
 	cfg := defaultRegistryConfig()
 	cfg.AcceptAMP = ampEnabled
 	ctx := newTestContext(t, &cfg, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	allSubscriptions, err := ctx.registry.SubscribeNotifications(ctxb, 0, 0)
 	require.Nil(t, err)
@@ -2132,7 +2131,7 @@ func testFailPartialMPPPaymentExternal(t *testing.T,
 	// Add an invoice which we are going to pay via a MPP set.
 	testInvoice := newInvoice(t, false, false)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err := ctx.registry.AddInvoice(
 		ctxb, testInvoice, testInvoicePaymentHash,
 	)
@@ -2243,7 +2242,7 @@ func testFailPartialAMPPayment(t *testing.T,
 	t.Parallel()
 
 	ctx := newTestContext(t, nil, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const (
 		expiry    = uint32(testCurrentHeight + 20)
@@ -2449,7 +2448,7 @@ func testCancelAMPInvoicePendingHTLCs(t *testing.T,
 	t.Parallel()
 
 	ctx := newTestContext(t, nil, makeDB)
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const (
 		expiry    = uint32(testCurrentHeight + 20)

invoices/invoices_test.go

@@ -1,7 +1,6 @@
 package invoices_test
 
 import (
-	"context"
 	"crypto/rand"
 	"database/sql"
 	"fmt"
@@ -373,7 +372,7 @@ func testInvoiceWorkflowImpl(t *testing.T, test invWorkflowTest,
 		ref = invpkg.InvoiceRefByHash(payHash)
 	}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	// Add the invoice to the database, this should succeed as there aren't
 	// any existing invoices within the database with the same payment
 	// hash.
@@ -498,7 +497,7 @@ func testAddDuplicatePayAddr(t *testing.T,
 	require.NoError(t, err)
 	invoice2.Terms.PaymentAddr = invoice1.Terms.PaymentAddr
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// First insert should succeed.
 	inv1Hash := invoice1.Terms.PaymentPreimage.Hash()
@@ -529,7 +528,7 @@ func testAddDuplicateKeysendPayAddr(t *testing.T,
 	require.NoError(t, err)
 	invoice2.Terms.PaymentAddr = invpkg.BlankPayAddr
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Inserting both should succeed without a duplicate payment address
 	// failure.
@@ -573,7 +572,7 @@ func testFailInvoiceLookupMPPPayAddrOnly(t *testing.T,
 	payHash := invoice.Terms.PaymentPreimage.Hash()
 	payAddr := invoice.Terms.PaymentAddr
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err = db.AddInvoice(ctxb, invoice, payHash)
 	require.NoError(t, err)
 
@@ -601,7 +600,7 @@ func testInvRefEquivocation(t *testing.T,
 	invoice1, err := randInvoice(1000)
 	require.NoError(t, err)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	inv1Hash := invoice1.Terms.PaymentPreimage.Hash()
 	_, err = db.AddInvoice(ctxb, invoice1, inv1Hash)
 	require.NoError(t, err)
@@ -651,7 +650,7 @@ func testInvoiceCancelSingleHtlc(t *testing.T,
 		},
 	}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	if _, err := db.AddInvoice(ctxb, testInvoice, paymentHash); err != nil {
 		t.Fatalf("unable to find invoice: %v", err)
 	}
@@ -729,7 +728,7 @@ func testInvoiceCancelSingleHtlcAMP(t *testing.T,
 	// preimages.
 	invoice.Terms.Features = ampFeatures
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	preimage := *invoice.Terms.PaymentPreimage
 	payHash := preimage.Hash()
 	_, err = db.AddInvoice(ctxb, invoice, payHash)
@@ -898,7 +897,7 @@ func testInvoiceAddTimeSeries(t *testing.T,
 	t.Parallel()
 	db := makeDB(t)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err := db.InvoicesAddedSince(ctxb, 0)
 	require.NoError(t, err)
 
@@ -1073,7 +1072,7 @@ func testSettleIndexAmpPayments(t *testing.T,
 
 	// Add the invoice to the DB, we use a dummy payment hash here but the
 	// invoice will have a valid payment address set.
-	ctxb := context.Background()
+	ctxb := t.Context()
 	preimage := *testInvoice.Terms.PaymentPreimage
 	payHash := preimage.Hash()
 	_, err = db.AddInvoice(ctxb, testInvoice, payHash)
@@ -1236,7 +1235,7 @@ func testFetchPendingInvoices(t *testing.T,
 	t.Parallel()
 	db := makeDB(t)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Make sure that fetching pending invoices from an empty database
 	// returns an empty result and no errors.
@@ -1305,7 +1304,7 @@ func testDuplicateSettleInvoice(t *testing.T,
 
 	payHash := invoice.Terms.PaymentPreimage.Hash()
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	if _, err := db.AddInvoice(ctxb, invoice, payHash); err != nil {
 		t.Fatalf("unable to add invoice %v", err)
 	}
@@ -1372,7 +1371,7 @@ func testQueryInvoices(t *testing.T,
 		pendingInvoices []invpkg.Invoice
 	)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	for i := 1; i <= numInvoices; i++ {
 		amt := lnwire.MilliSatoshi(i)
 		invoice, err := randInvoice(amt)
@@ -1813,7 +1812,7 @@ func testCustomRecords(t *testing.T,
 		},
 	}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	if _, err := db.AddInvoice(ctxb, testInvoice, paymentHash); err != nil {
 		t.Fatalf("unable to add invoice: %v", err)
 	}
@@ -1893,7 +1892,7 @@ func testInvoiceHtlcAMPFieldsImpl(t *testing.T, isAMP bool,
 		testInvoice.Terms.Features = ampFeatures
 	}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	payHash := testInvoice.Terms.PaymentPreimage.Hash()
 	_, err = db.AddInvoice(ctxb, testInvoice, payHash)
 	require.Nil(t, err)
@@ -2101,7 +2100,7 @@ func testAddInvoiceWithHTLCs(t *testing.T,
 	testInvoice.Htlcs[key] = &invpkg.InvoiceHTLC{}
 
 	payHash := testInvoice.Terms.PaymentPreimage.Hash()
-	_, err = db.AddInvoice(context.Background(), testInvoice, payHash)
+	_, err = db.AddInvoice(t.Context(), testInvoice, payHash)
 	require.Equal(t, invpkg.ErrInvoiceHasHtlcs, err)
 }
 
@@ -2121,7 +2120,7 @@ func testSetIDIndex(t *testing.T, makeDB func(t *testing.T) invpkg.InvoiceDB) {
 	// preimages.
 	invoice.Terms.Features = ampFeatures
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	preimage := *invoice.Terms.PaymentPreimage
 	payHash := preimage.Hash()
 	_, err = db.AddInvoice(ctxb, invoice, payHash)
@@ -2460,7 +2459,7 @@ func testUnexpectedInvoicePreimage(t *testing.T,
 	invoice, err := randInvoice(lnwire.MilliSatoshi(100))
 	require.NoError(t, err)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Add a random invoice indexed by payment hash and payment addr.
 	paymentHash := invoice.Terms.PaymentPreimage.Hash()
@@ -2530,7 +2529,7 @@ func testUpdateHTLCPreimagesImpl(t *testing.T, test updateHTLCPreimageTestCase,
 	// preimages.
 	invoice.Terms.Features = ampFeatures
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	_, err = db.AddInvoice(ctxb, invoice, payHash)
 	require.Nil(t, err)
 
@@ -2594,7 +2593,7 @@ func testDeleteInvoices(t *testing.T,
 	numInvoices := 3
 	invoicesToDelete := make([]invpkg.InvoiceDeleteRef, numInvoices)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	for i := 0; i < numInvoices; i++ {
 		invoice, err := randInvoice(lnwire.MilliSatoshi(i + 1))
 		require.NoError(t, err)
@@ -2689,7 +2688,7 @@ func testDeleteCanceledInvoices(t *testing.T,
 	}
 
 	// Test deletion of canceled invoices when there are none.
-	ctxb := context.Background()
+	ctxb := t.Context()
 	require.NoError(t, db.DeleteCanceledInvoices(ctxb))
 
 	// Add some invoices to the test db.
@@ -2750,7 +2749,7 @@ func testAddInvoiceInvalidFeatureDeps(t *testing.T,
 	)
 
 	hash := invoice.Terms.PaymentPreimage.Hash()
-	_, err = db.AddInvoice(context.Background(), invoice, hash)
+	_, err = db.AddInvoice(t.Context(), invoice, hash)
 	require.Error(t, err, feature.NewErrMissingFeatureDep(
 		lnwire.PaymentAddrOptional,
 	))

invoices/kv_sql_migration_test.go

@@ -1,7 +1,6 @@
 package invoices_test
 
 import (
-	"context"
 	"database/sql"
 	"os"
 	"path"
@@ -67,7 +66,7 @@ func TestMigrationWithChannelDB(t *testing.T) {
 		sqlite bool) {
 
 		sqlInvoiceStore, sqlStore := makeSQLDB(t, sqlite)
-		ctxb := context.Background()
+		ctxb := t.Context()
 
 		const batchSize = 11
 		err := sqlStore.ExecTx(
@@ -163,7 +162,7 @@ func TestMigrationWithChannelDB(t *testing.T) {
 
 				sqliteBackend, err := kvdb.Open(
 					kvdb.SqliteBackendName,
-					context.Background(),
+					t.Context(),
 					sqliteConfig, test.dbPath,
 					lncfg.SqliteChannelDBName,
 					lncfg.NSChannelDB,

invoices/sql_migration_test.go

@@ -1,7 +1,6 @@
 package invoices
 
 import (
-	"context"
 	crand "crypto/rand"
 	"database/sql"
 	"math/rand"
@@ -305,7 +304,7 @@ func TestMigrateSingleInvoiceRapid(t *testing.T) {
 func testMigrateSingleInvoiceRapid(t *rapid.T, store *SQLStore, mpp bool,
 	amp bool) {
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	invoices := make(map[lntypes.Hash]*Invoice)
 
 	for i := 0; i < 100; i++ {

itest/lnd_channel_funding_fund_max_test.go

@@ -1,7 +1,6 @@
 package itest
 
 import (
-	"context"
 	"errors"
 	"testing"
 
@@ -65,7 +64,7 @@ func testChannelFundMaxError(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -155,7 +154,7 @@ func testChannelFundMaxWalletAmount(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -220,7 +219,7 @@ func testChannelFundMaxAnchorReserve(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)

itest/lnd_channel_funding_utxo_selection_test.go

@@ -1,7 +1,6 @@
 package itest
 
 import (
-	"context"
 	"errors"
 	"fmt"
 	"testing"
@@ -104,7 +103,7 @@ func testChannelUtxoSelectionError(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -198,7 +197,7 @@ func testUtxoSelectionSelectedValidChanSize(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -240,7 +239,7 @@ func testUtxoSelectionSelectedValidChanReserve(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -281,7 +280,7 @@ func testUtxoSelectionReserveFromSelected(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -325,7 +324,7 @@ func testUtxoSelectionFundmax(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -364,7 +363,7 @@ func testUtxoSelectionFundmaxReserve(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)
@@ -404,7 +403,7 @@ func testUtxoSelectionReuseUTXO(ht *lntest.HarnessTest) {
 
 	// Calculate reserve amount for one channel.
 	reserveResp, _ := alice.RPC.WalletKit.RequiredReserve(
-		context.Background(), &walletrpc.RequiredReserveRequest{
+		ht.Context(), &walletrpc.RequiredReserveRequest{
 			AdditionalPublicChannels: 1,
 		},
 	)

itest/lnd_funding_test.go

@@ -1,7 +1,6 @@
 package itest
 
 import (
-	"context"
 	"fmt"
 	"testing"
 
@@ -1164,7 +1163,7 @@ func ensurePolicy(ht *lntest.HarnessTest, alice, peer *node.HarnessNode,
 
 	channel := ht.AssertChannelExists(peer, chanPoint)
 	policy, err := peer.RPC.LN.GetChanInfo(
-		context.Background(), &lnrpc.ChanInfoRequest{
+		ht.Context(), &lnrpc.ChanInfoRequest{
 			ChanId: channel.ChanId,
 		},
 	)

itest/lnd_graph_migration_test.go

@@ -21,7 +21,7 @@ func testGraphMigration(ht *lntest.HarnessTest) {
 		ht.Skip("not running with test_native_sql tag")
 	}
 
-	ctx := context.Background()
+	ctx := ht.Context()
 	alice := ht.NewNodeWithCoins("Alice", nil)
 
 	// Make sure we run the test with SQLite or Postgres.

itest/lnd_invoice_acceptor_test.go

@@ -1,7 +1,6 @@
 package itest
 
 import (
-	"context"
 	"time"
 
 	"github.com/btcsuite/btcd/btcutil"
@@ -47,7 +46,7 @@ func testInvoiceHtlcModifierBasic(ht *lntest.HarnessTest) {
 	// Make sure we get an error if we try to register a second modifier and
 	// then try to use it (the error won't be returned on connect, only on
 	// the first _read_ interaction on the stream).
-	mod2, err := carol.RPC.Invoice.HtlcModifier(context.Background())
+	mod2, err := carol.RPC.Invoice.HtlcModifier(ht.Context())
 	require.NoError(ht, err)
 	_, err = mod2.Recv()
 	require.ErrorContains(

itest/lnd_misc_test.go

@@ -1400,7 +1400,7 @@ func testGRPCNotFound(ht *lntest.HarnessTest) {
 // during a reorg. A reorg notification is produced after a reorg affects the
 // block which has produced a spending notification for this registration.
 func testReorgNotifications(ht *lntest.HarnessTest) {
-	ctxb := context.Background()
+	ctxb := ht.Context()
 	const timeout = wait.DefaultTimeout
 
 	alice := ht.NewNodeWithCoins("Alice", nil)
@@ -1599,7 +1599,7 @@ func testReorgNotifications(ht *lntest.HarnessTest) {
 func testEstimateFee(ht *lntest.HarnessTest) {
 	alice := ht.NewNode("Alice", nil)
 
-	ctx := context.Background()
+	ctx := ht.Context()
 
 	testCases := []struct {
 		name        string

itest/lnd_payment_test.go

@@ -1081,7 +1081,7 @@ func sendPaymentInterceptAndCancel(ht *lntest.HarnessTest,
 
 	// We initiate a payment from Alice and define the payment context
 	// cancellable.
-	ctx, cancelPaymentContext := context.WithCancel(context.Background())
+	ctx, cancelPaymentContext := context.WithCancel(ht.Context())
 	var paymentStream rpc.PaymentClient
 	go func() {
 		req := &routerrpc.SendPaymentRequest{

itest/lnd_route_blinding_test.go

@@ -335,7 +335,7 @@ type blindedForwardTest struct {
 func newBlindedForwardTest(ht *lntest.HarnessTest) (context.Context,
 	*blindedForwardTest) {
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(ht.Context())
 
 	return ctx, &blindedForwardTest{
 		ht:       ht,

itest/lnd_rpc_middleware_interceptor_test.go

@@ -220,7 +220,7 @@ func middlewareInterceptionTest(t *testing.T,
 
 	// Everything we test here should be executed in a matter of
 	// milliseconds, so we can use one single timeout context for all calls.
-	ctxb := context.Background()
+	ctxb := t.Context()
 	ctxc, cancel := context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
 
@@ -372,7 +372,7 @@ func middlewareResponseManipulationTest(t *testing.T,
 
 	// Everything we test here should be executed in a matter of
 	// milliseconds, so we can use one single timeout context for all calls.
-	ctxb := context.Background()
+	ctxb := t.Context()
 	ctxc, cancel := context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
 
@@ -489,7 +489,7 @@ func middlewareRequestManipulationTest(t *testing.T, node *node.HarnessNode,
 
 	// Everything we test here should be executed in a matter of
 	// milliseconds, so we can use one single timeout context for all calls.
-	ctxb := context.Background()
+	ctxb := t.Context()
 	ctxc, cancel := context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
 
@@ -582,7 +582,7 @@ func middlewareMandatoryTest(ht *lntest.HarnessTest, node *node.HarnessNode) {
 	err = node.WaitUntilServerActive()
 	require.NoError(ht, err)
 
-	ctxb := context.Background()
+	ctxb := ht.Context()
 	ctxc, cancel := context.WithTimeout(ctxb, defaultTimeout)
 	defer cancel()
 

itest/lnd_signer_test.go

@@ -2,7 +2,6 @@ package itest
 
 import (
 	"bytes"
-	"context"
 	"crypto/sha256"
 
 	"github.com/btcsuite/btcd/btcec/v2"
@@ -500,7 +499,7 @@ func runSignVerifyMessage(ht *lntest.HarnessTest, alice *node.HarnessNode) {
 
 	expectedErr := "tag can only be used when the Schnorr signature " +
 		"option is set"
-	ctxt := context.Background()
+	ctxt := ht.Context()
 	_, err := alice.RPC.Signer.SignMessage(ctxt, signMsgReq)
 	require.ErrorContains(ht, err, expectedErr)
 

kvdb/etcd/commit_queue_test.go

@@ -40,7 +40,7 @@ func TestCommitQueue(t *testing.T) {
 		}
 	}
 
-	ctx := context.Background()
+	ctx := t.Context()
 	ctx, cancel := context.WithCancel(ctx)
 	q := NewCommitQueue(ctx)
 	defer q.Stop()

kvdb/etcd/db_test.go

@@ -19,7 +19,7 @@ func TestDump(t *testing.T) {
 
 	f := NewEtcdTestFixture(t)
 
-	db, err := newEtcdBackend(context.Background(), f.BackendConfig())
+	db, err := newEtcdBackend(t.Context(), f.BackendConfig())
 	require.NoError(t, err)
 
 	err = db.Update(func(tx walletdb.ReadWriteTx) error {
@@ -53,7 +53,7 @@ func TestAbortContext(t *testing.T) {
 
 	f := NewEtcdTestFixture(t)
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	config := f.BackendConfig()
 
@@ -83,7 +83,7 @@ func TestNewEtcdClient(t *testing.T) {
 	f := NewEtcdTestFixture(t)
 
 	client, ctx, cancel, err := NewEtcdClient(
-		context.Background(), f.BackendConfig(),
+		t.Context(), f.BackendConfig(),
 	)
 	require.NoError(t, err)
 	t.Cleanup(cancel)

kvdb/etcd/readwrite_tx_test.go

@@ -4,7 +4,6 @@
 package etcd
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcwallet/walletdb"
@@ -16,7 +15,7 @@ func TestChangeDuringManualTx(t *testing.T) {
 
 	f := NewEtcdTestFixture(t)
 
-	db, err := newEtcdBackend(context.Background(), f.BackendConfig())
+	db, err := newEtcdBackend(t.Context(), f.BackendConfig())
 	require.NoError(t, err)
 
 	tx, err := db.BeginReadWriteTx()
@@ -44,7 +43,7 @@ func TestChangeDuringUpdate(t *testing.T) {
 
 	f := NewEtcdTestFixture(t)
 
-	db, err := newEtcdBackend(context.Background(), f.BackendConfig())
+	db, err := newEtcdBackend(t.Context(), f.BackendConfig())
 	require.NoError(t, err)
 
 	count := 0

kvdb/etcd/stm_test.go

@@ -23,7 +23,7 @@ func TestPutToEmpty(t *testing.T) {
 	t.Parallel()
 
 	f := NewEtcdTestFixture(t)
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	txQueue := NewCommitQueue(ctx)
 	t.Cleanup(func() {
@@ -50,7 +50,7 @@ func TestGetPutDel(t *testing.T) {
 	t.Parallel()
 
 	f := NewEtcdTestFixture(t)
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	txQueue := NewCommitQueue(ctx)
 	t.Cleanup(func() {
@@ -151,7 +151,7 @@ func testFirstLastNextPrev(t *testing.T, prefetchKeys []string,
 	prefetchRange []string, expectedCallCount int) {
 
 	f := NewEtcdTestFixture(t)
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	txQueue := NewCommitQueue(ctx)
 	t.Cleanup(func() {
@@ -325,7 +325,7 @@ func TestCommitError(t *testing.T) {
 	t.Parallel()
 
 	f := NewEtcdTestFixture(t)
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	txQueue := NewCommitQueue(ctx)
 	t.Cleanup(func() {
@@ -374,7 +374,7 @@ func TestManualTxError(t *testing.T) {
 	t.Parallel()
 
 	f := NewEtcdTestFixture(t)
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	txQueue := NewCommitQueue(ctx)
 	t.Cleanup(func() {

kvdb/etcd/walletdb_interface_test.go

@@ -4,7 +4,6 @@
 package etcd
 
 import (
-	"context"
 	"testing"
 
 	"github.com/btcsuite/btcwallet/walletdb/walletdbtest"
@@ -15,5 +14,5 @@ import (
 func TestWalletDBInterface(t *testing.T) {
 	f := NewEtcdTestFixture(t)
 	cfg := f.BackendConfig()
-	walletdbtest.TestInterface(t, dbType, context.Background(), &cfg)
+	walletdbtest.TestInterface(t, dbType, t.Context(), &cfg)
 }

kvdb/go.mod

@@ -15,7 +15,6 @@ require (
 	go.etcd.io/etcd/client/pkg/v3 v3.5.12
 	go.etcd.io/etcd/client/v3 v3.5.12
 	go.etcd.io/etcd/server/v3 v3.5.12
-	golang.org/x/net v0.39.0
 	modernc.org/sqlite v1.29.10
 )
 
@@ -118,6 +117,7 @@ require (
 	golang.org/x/crypto v0.37.0 // indirect
 	golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8 // indirect
 	golang.org/x/mod v0.17.0 // indirect
+	golang.org/x/net v0.39.0 // indirect
 	golang.org/x/sync v0.13.0 // indirect
 	golang.org/x/sys v0.32.0 // indirect
 	golang.org/x/text v0.24.0 // indirect
@@ -147,4 +147,4 @@ replace github.com/ulikunitz/xz => github.com/ulikunitz/xz v0.5.11
 // https://deps.dev/advisory/OSV/GO-2021-0053?from=%2Fgo%2Fgithub.com%252Fgogo%252Fprotobuf%2Fv1.3.1
 replace github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
 
-go 1.23.12
+go 1.24.6

kvdb/postgres/db_test.go

@@ -9,7 +9,6 @@ import (
 	"github.com/btcsuite/btcwallet/walletdb"
 	"github.com/btcsuite/btcwallet/walletdb/walletdbtest"
 	"github.com/stretchr/testify/require"
-	"golang.org/x/net/context"
 )
 
 // TestInterface performs all interfaces tests for this database driver.
@@ -24,7 +23,7 @@ func TestInterface(t *testing.T) {
 	// dbType is the database type name for this driver.
 	const dbType = "postgres"
 
-	ctx := context.Background()
+	ctx := t.Context()
 	cfg := &Config{
 		Dsn: f.Dsn,
 	}

kvdb/sqlite/db_test.go

@@ -9,14 +9,13 @@ import (
 	"github.com/btcsuite/btcwallet/walletdb/walletdbtest"
 	"github.com/lightningnetwork/lnd/kvdb/sqlbase"
 	"github.com/stretchr/testify/require"
-	"golang.org/x/net/context"
 )
 
 // TestInterface performs all interfaces tests for this database driver.
 func TestInterface(t *testing.T) {
 	// dbType is the database type name for this driver.
 	dir := t.TempDir()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	sqlbase.Init(0)
 

lnrpc/Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.23.12-bookworm
+FROM golang:1.24.6-bookworm
 
 RUN apt-get update && apt-get install -y \
   git \

lnrpc/gen_protos_docker.sh

@@ -6,7 +6,7 @@ set -e
 DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # golang docker image version used in this script.
-GO_IMAGE=docker.io/library/golang:1.23.12-alpine
+GO_IMAGE=docker.io/library/golang:1.24.6-alpine
 
 PROTOBUF_VERSION=$(docker run --rm -v $DIR/../:/lnd -w /lnd $GO_IMAGE \
 	go list -f '{{.Version}}' -m google.golang.org/protobuf)

lnrpc/routerrpc/router_backend_test.go

@@ -2,7 +2,6 @@ package routerrpc
 
 import (
 	"bytes"
-	"context"
 	"encoding/hex"
 	"testing"
 	"time"
@@ -264,7 +263,7 @@ func testQueryRoutes(t *testing.T, useMissionControl bool, useMsat bool,
 		backend.MaxTotalTimelock = 1000
 	}
 
-	resp, err := backend.QueryRoutes(context.Background(), request)
+	resp, err := backend.QueryRoutes(t.Context(), request)
 
 	// If we're using both OutgoingChanId and OutgoingChanIds, we should get
 	// an error.

lnrpc/routerrpc/router_server_test.go

@@ -82,7 +82,7 @@ func TestTrackPaymentsReturnsOnCancelContext(t *testing.T) {
 	}
 	towerMock := makeControlTowerMock()
 
-	streamCtx, cancelStream := context.WithCancel(context.Background())
+	streamCtx, cancelStream := context.WithCancel(t.Context())
 	stream := makeStreamMock(streamCtx)
 
 	server := &Server{
@@ -110,7 +110,7 @@ func TestTrackPaymentsInflightUpdates(t *testing.T) {
 	}
 	towerMock := makeControlTowerMock()
 
-	streamCtx, cancelStream := context.WithCancel(context.Background())
+	streamCtx, cancelStream := context.WithCancel(t.Context())
 	stream := makeStreamMock(streamCtx)
 	defer cancelStream()
 
@@ -172,7 +172,7 @@ func TestTrackPaymentsNoInflightUpdates(t *testing.T) {
 	}
 	towerMock.queue.Start()
 
-	streamCtx, cancelStream := context.WithCancel(context.Background())
+	streamCtx, cancelStream := context.WithCancel(t.Context())
 	stream := makeStreamMock(streamCtx)
 	defer cancelStream()
 

lnrpc/websocket_proxy.go

@@ -5,6 +5,7 @@ package lnrpc
 
 import (
 	"bufio"
+	"context"
 	"io"
 	"net/http"
 	"net/textproto"
@@ -14,7 +15,6 @@ import (
 
 	"github.com/btcsuite/btclog/v2"
 	"github.com/gorilla/websocket"
-	"golang.org/x/net/context"
 )
 
 const (

lntest/fee_service.go

@@ -1,7 +1,6 @@
 package lntest
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -130,7 +129,7 @@ func (f *FeeService) handleRequest(w http.ResponseWriter, _ *http.Request) {
 
 // Stop stops the web server.
 func (f *FeeService) Stop() error {
-	err := f.srv.Shutdown(context.Background())
+	err := f.srv.Shutdown(f.Context())
 	require.NoError(f, err, "cannot stop fee api")
 
 	f.wg.Wait()

lntest/harness.go

@@ -147,7 +147,7 @@ func NewHarnessTest(t *testing.T, lndBinary string, feeService WebFeeService,
 	t.Helper()
 
 	// Create the run context.
-	ctxt, cancel := context.WithCancel(context.Background())
+	ctxt, cancel := context.WithCancel(t.Context())
 
 	manager := newNodeManager(lndBinary, dbBackend, nativeSQL)
 
@@ -435,9 +435,9 @@ func (h *HarnessTest) shutdownNodesNoAssert() {
 
 // shutdownAllNodes will shutdown all running nodes.
 func (h *HarnessTest) shutdownAllNodes() {
-	var err error
+	var lastErr error
 	for _, node := range h.manager.activeNodes {
-		err = h.manager.shutdownNode(node)
+		err := h.manager.shutdownNode(node)
 		if err == nil {
 			continue
 		}
@@ -446,9 +446,11 @@ func (h *HarnessTest) shutdownAllNodes() {
 		// is needed so other nodes can continue their shutdown
 		// processes.
 		h.Logf("unable to shutdown %s, got err: %v", node.Name(), err)
+
+		lastErr = err
 	}
 
-	require.NoError(h, err, "failed to shutdown all nodes")
+	require.NoError(h, lastErr, "failed to shutdown all nodes")
 }
 
 // cleanupStandbyNode is a function should be called with defer whenever a

lntest/node/harness_node.go

@@ -115,7 +115,7 @@ func NewHarnessNode(t *testing.T, cfg *BaseNodeConfig) (*HarnessNode, error) {
 	var dbName string
 	if cfg.DBBackend == BackendPostgres {
 		var err error
-		dbName, err = createTempPgDB()
+		dbName, err = createTempPgDB(t.Context())
 		if err != nil {
 			return nil, err
 		}
@@ -702,6 +702,11 @@ func (hn *HarnessNode) Stop() error {
 		// gets closed before a response is returned.
 		req := lnrpc.StopRequest{}
 
+		// We have to use context.Background(), because both hn.Context
+		// and hn.runCtx have been canceled by this point. We canceled
+		// hn.runCtx just few lines above. hn.Context() is canceled by
+		// Go before calling cleanup callbacks; HarnessNode.Stop() is
+		// called from shutdownAllNodes which is called from a cleanup.
 		ctxt, cancel := context.WithCancel(context.Background())
 		defer cancel()
 
@@ -841,8 +846,8 @@ func (hn *HarnessNode) BackupDB() error {
 		// Backup database.
 		backupDBName := hn.Cfg.postgresDBName + "_backup"
 		err := executePgQuery(
-			"CREATE DATABASE " + backupDBName + " WITH TEMPLATE " +
-				hn.Cfg.postgresDBName,
+			hn.Context(), "CREATE DATABASE "+backupDBName+
+				" WITH TEMPLATE "+hn.Cfg.postgresDBName,
 		)
 		if err != nil {
 			return err
@@ -872,14 +877,14 @@ func (hn *HarnessNode) RestoreDB() error {
 		// Restore database.
 		backupDBName := hn.Cfg.postgresDBName + "_backup"
 		err := executePgQuery(
-			"DROP DATABASE " + hn.Cfg.postgresDBName,
+			hn.Context(), "DROP DATABASE "+hn.Cfg.postgresDBName,
 		)
 		if err != nil {
 			return err
 		}
 		err = executePgQuery(
-			"ALTER DATABASE " + backupDBName + " RENAME TO " +
-				hn.Cfg.postgresDBName,
+			hn.Context(), "ALTER DATABASE "+backupDBName+
+				" RENAME TO "+hn.Cfg.postgresDBName,
 		)
 		if err != nil {
 			return err
@@ -924,7 +929,7 @@ func postgresDatabaseDsn(dbName string) string {
 }
 
 // createTempPgDB creates a temp postgres database.
-func createTempPgDB() (string, error) {
+func createTempPgDB(ctx context.Context) (string, error) {
 	// Create random database name.
 	randBytes := make([]byte, 8)
 	_, err := rand.Read(randBytes)
@@ -934,7 +939,7 @@ func createTempPgDB() (string, error) {
 	dbName := "itest_" + hex.EncodeToString(randBytes)
 
 	// Create database.
-	err = executePgQuery("CREATE DATABASE " + dbName)
+	err = executePgQuery(ctx, "CREATE DATABASE "+dbName)
 	if err != nil {
 		return "", err
 	}
@@ -943,17 +948,14 @@ func createTempPgDB() (string, error) {
 }
 
 // executePgQuery executes a SQL statement in a postgres db.
-func executePgQuery(query string) error {
-	pool, err := pgxpool.Connect(
-		context.Background(),
-		postgresDatabaseDsn("postgres"),
-	)
+func executePgQuery(ctx context.Context, query string) error {
+	pool, err := pgxpool.Connect(ctx, postgresDatabaseDsn("postgres"))
 	if err != nil {
 		return fmt.Errorf("unable to connect to database: %w", err)
 	}
 	defer pool.Close()
 
-	_, err = pool.Exec(context.Background(), query)
+	_, err = pool.Exec(ctx, query)
 	return err
 }
 

lnwallet/chancloser/rbf_coop_test.go

@@ -153,7 +153,7 @@ func assertUnknownEventFail(t *testing.T, startingState ProtocolState) {
 		defer closeHarness.stopAndAssert()
 
 		closeHarness.sendEventAndExpectFailure(
-			context.Background(), &unknownEvent{},
+			t.Context(), &unknownEvent{},
 			ErrInvalidStateTransition,
 		)
 	})
@@ -173,7 +173,7 @@ func assertSpendEventCloseFin(t *testing.T, startingState ProtocolState) {
 		defer closeHarness.stopAndAssert()
 
 		closeHarness.chanCloser.SendEvent(
-			context.Background(), &SpendEvent{},
+			t.Context(), &SpendEvent{},
 		)
 
 		closeHarness.assertStateTransitions(&CloseFin{})
@@ -539,7 +539,7 @@ func (r *rbfCloserTestHarness) expectHalfSignerIteration(
 	initEvent ProtocolEvent, balanceAfterClose, absoluteFee btcutil.Amount,
 	dustExpect dustExpectation, iteration bool) {
 
-	ctx := context.Background()
+	ctx := r.T.Context()
 	numFeeCalls := 2
 
 	// If we're using the SendOfferEvent as a trigger, we only need to call
@@ -645,7 +645,7 @@ func (r *rbfCloserTestHarness) assertSingleRbfIteration(
 	initEvent ProtocolEvent, balanceAfterClose, absoluteFee btcutil.Amount,
 	dustExpect dustExpectation, iteration bool) {
 
-	ctx := context.Background()
+	ctx := r.T.Context()
 
 	// We'll now send in the send offer event, which should trigger 1/2 of
 	// the RBF loop, ending us in the LocalOfferSent state.
@@ -686,7 +686,7 @@ func (r *rbfCloserTestHarness) assertSingleRemoteRbfIteration(
 	absoluteFee btcutil.Amount, sequence uint32, iteration bool,
 	sendInit bool) {
 
-	ctx := context.Background()
+	ctx := r.T.Context()
 
 	// When we receive the signature below, our local state machine should
 	// move to finalize the close.
@@ -744,7 +744,7 @@ func assertStateT[T ProtocolState](h *rbfCloserTestHarness) T {
 func newRbfCloserTestHarness(t *testing.T,
 	cfg *harnessCfg) *rbfCloserTestHarness {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	startingHeight := 200
 
@@ -850,7 +850,7 @@ func newCloser(t *testing.T, cfg *harnessCfg) *rbfCloserTestHarness {
 // TestRbfChannelActiveTransitions tests the transitions of from the
 // ChannelActive state.
 func TestRbfChannelActiveTransitions(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 	localAddr := lnwire.DeliveryAddress(bytes.Repeat([]byte{0x01}, 20))
 	remoteAddr := lnwire.DeliveryAddress(bytes.Repeat([]byte{0x02}, 20))
 
@@ -1001,7 +1001,7 @@ func TestRbfChannelActiveTransitions(t *testing.T) {
 // shutdown ourselves.
 func TestRbfShutdownPendingTransitions(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	startingState := &ShutdownPending{}
 
@@ -1229,7 +1229,7 @@ func TestRbfShutdownPendingTransitions(t *testing.T) {
 // transition to the negotiation state.
 func TestRbfChannelFlushingTransitions(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	localBalance := lnwire.NewMSatFromSatoshis(10_000)
 	remoteBalance := lnwire.NewMSatFromSatoshis(50_000)
@@ -1406,7 +1406,7 @@ func TestRbfChannelFlushingTransitions(t *testing.T) {
 // rate.
 func TestRbfCloseClosingNegotiationLocal(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	localBalance := lnwire.NewMSatFromSatoshis(40_000)
 	remoteBalance := lnwire.NewMSatFromSatoshis(50_000)
@@ -1687,7 +1687,7 @@ func TestRbfCloseClosingNegotiationLocal(t *testing.T) {
 func TestRbfCloseClosingNegotiationRemote(t *testing.T) {
 	t.Parallel()
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	localBalance := lnwire.NewMSatFromSatoshis(40_000)
 	remoteBalance := lnwire.NewMSatFromSatoshis(50_000)

lnwallet/chanfunding/coin_select_test.go

@@ -662,7 +662,7 @@ func TestCoinSelectSubtractFees(t *testing.T) {
 			if err != nil {
 				switch {
 				case test.expectErr == "":
-					t.Fatalf(err.Error())
+					t.Fatal(err)
 
 				case test.expectErr != removeAmounts(err.Error()):
 					t.Fatalf("expected error '%v', got '%v'",

lnwallet/channel_test.go

@@ -3836,7 +3836,7 @@ func TestQuitDuringSignNextCommitment(t *testing.T) {
 	)
 
 	quitDelay := time.Millisecond * 20
-	quit, quitFunc := context.WithCancel(context.Background())
+	quit, quitFunc := context.WithCancel(t.Context())
 
 	// Alice's channel will be stuck waiting for aux sig job responses until
 	// we send the quit signal. We add an explicit sleep here so that we can

macaroons/bake.go

@@ -2,9 +2,9 @@ package macaroons
 
 import (
 	"bytes"
+	"context"
 	"fmt"
 
-	"golang.org/x/net/context"
 	"gopkg.in/macaroon-bakery.v2/bakery"
 	"gopkg.in/macaroon.v2"
 )

macaroons/bake_test.go

@@ -1,7 +1,6 @@
 package macaroons_test
 
 import (
-	"context"
 	"encoding/hex"
 	"testing"
 
@@ -49,7 +48,7 @@ func TestBakeFromRootKey(t *testing.T) {
 	md := metadata.New(map[string]string{
 		"macaroon": hex.EncodeToString(macaroonBytes),
 	})
-	macCtx := metadata.NewIncomingContext(context.Background(), md)
+	macCtx := metadata.NewIncomingContext(t.Context(), md)
 
 	// The macaroon should be valid for the service, since the root key was
 	// the same.

macaroons/constraints.go

@@ -136,7 +136,8 @@ func IPLockChecker() (string, checkers.Func) {
 		// check.
 		pr, ok := peer.FromContext(ctx)
 		if !ok {
-			return fmt.Errorf("unable to get peer info from context")
+			return fmt.Errorf("unable to get peer info from " +
+				"context")
 		}
 		peerAddr, _, err := net.SplitHostPort(pr.Addr.String())
 		if err != nil {
@@ -144,8 +145,8 @@ func IPLockChecker() (string, checkers.Func) {
 		}
 
 		if !net.ParseIP(arg).Equal(net.ParseIP(peerAddr)) {
-			msg := "macaroon locked to different IP address"
-			return fmt.Errorf(msg)
+			return fmt.Errorf("macaroon locked to different IP " +
+				"address")
 		}
 		return nil
 	}

macaroons/fuzz_test.go

@@ -1,7 +1,6 @@
 package macaroons
 
 import (
-	"context"
 	"testing"
 
 	"gopkg.in/macaroon-bakery.v2/bakery"
@@ -17,7 +16,7 @@ func FuzzUnmarshalMacaroon(f *testing.F) {
 
 func FuzzAuthChecker(f *testing.F) {
 	rootKeyStore := bakery.NewMemRootKeyStore()
-	ctx := context.Background()
+	ctx := f.Context()
 
 	f.Fuzz(func(t *testing.T, location, entity, action, method string,
 		rootKey, id []byte) {

macaroons/service_test.go

@@ -1,7 +1,6 @@
 package macaroons_test
 
 import (
-	"context"
 	"encoding/hex"
 	"path"
 	"testing"
@@ -55,7 +54,7 @@ func setupTestRootKeyStorage(t *testing.T) kvdb.Backend {
 // TestNewService tests the creation of the macaroon service.
 func TestNewService(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, initialize a dummy DB file with a store that the service
 	// can read from. Make sure the file is removed in the end.
@@ -109,7 +108,7 @@ func TestNewService(t *testing.T) {
 // incoming context.
 func TestValidateMacaroon(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, initialize the service and unlock it.
 	db := setupTestRootKeyStorage(t)
@@ -157,7 +156,7 @@ func TestValidateMacaroon(t *testing.T) {
 // TestListMacaroonIDs checks that ListMacaroonIDs returns the expected result.
 func TestListMacaroonIDs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, initialize a dummy DB file with a store that the service
 	// can read from. Make sure the file is removed in the end.
@@ -192,7 +191,7 @@ func TestListMacaroonIDs(t *testing.T) {
 func TestDeleteMacaroonID(t *testing.T) {
 	t.Parallel()
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// First, initialize a dummy DB file with a store that the service
 	// can read from. Make sure the file is removed in the end.
@@ -308,7 +307,7 @@ func TestCloneMacaroons(t *testing.T) {
 func TestMacaroonVersionDecode(t *testing.T) {
 	t.Parallel()
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// First, initialize a dummy DB file with a store that the service
 	// can read from. Make sure the file is removed in the end.

macaroons/store_test.go

@@ -59,7 +59,7 @@ func openTestStore(t *testing.T, tempDir string) *macaroons.RootKeyStorage {
 // reading keys and closing it.
 func TestStore(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	tempDir, store := newTestStore(t)
 

make/builder.Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.23.12-bookworm
+FROM golang:1.24.6-bookworm
 
 MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>
 

msgmux/msg_router_test.go

@@ -34,7 +34,7 @@ func (m *mockEndpoint) SendMessage(ctx context.Context, msg PeerMsg) bool {
 // TestMessageRouterOperation tests the basic operation of the message router:
 // add new endpoints, route to them, remove, them, etc.
 func TestMessageRouterOperation(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 	msgRouter := NewMultiMsgRouter()
 	msgRouter.Start(ctx)
 	defer msgRouter.Stop()

payments/db/kv_store_test.go

@@ -2,7 +2,6 @@ package paymentsdb
 
 import (
 	"bytes"
-	"context"
 	"math"
 	"reflect"
 	"testing"
@@ -932,7 +931,7 @@ func TestQueryPayments(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
-			ctx := context.Background()
+			ctx := t.Context()
 
 			paymentDB := NewKVTestDB(t)
 

payments/db/payment_test.go

@@ -1,7 +1,6 @@
 package paymentsdb
 
 import (
-	"context"
 	"crypto/rand"
 	"crypto/sha256"
 	"errors"
@@ -304,7 +303,7 @@ func assertDBPayments(t *testing.T, paymentDB DB, payments []*payment) {
 	t.Helper()
 
 	response, err := paymentDB.QueryPayments(
-		context.Background(), Query{
+		t.Context(), Query{
 			IndexOffset:       0,
 			MaxPayments:       uint64(len(payments)),
 			IncludeIncomplete: true,

protofsm/state_machine_test.go

@@ -1,7 +1,6 @@
 package protofsm
 
 import (
-	"context"
 	"encoding/hex"
 	"fmt"
 	"sync/atomic"
@@ -410,7 +409,7 @@ func (d *dummyAdapters) RegisterSpendNtfn(outpoint *wire.OutPoint,
 // TestStateMachineOnInitDaemonEvent tests that the state machine will properly
 // execute any init-level daemon events passed into it.
 func TestStateMachineOnInitDaemonEvent(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create our state machine given the env, and our
 	// starting state.
@@ -464,7 +463,7 @@ func TestStateMachineOnInitDaemonEvent(t *testing.T) {
 // transition.
 func TestStateMachineInternalEvents(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create our state machine given the env, and our
 	// starting state.
@@ -513,7 +512,7 @@ func TestStateMachineInternalEvents(t *testing.T) {
 // daemon emitted as part of the state transition process.
 func TestStateMachineDaemonEvents(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create our state machine given the env, and our
 	// starting state.
@@ -598,7 +597,7 @@ func TestStateMachineDaemonEvents(t *testing.T) {
 // scenario where full block details are requested in the confirmation
 // notification.
 func testStateMachineConfMapperImpl(t *testing.T, fullBlock bool) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create the state machine.
 	env := &dummyEnv{}
@@ -722,7 +721,7 @@ func TestStateMachineConfMapper(t *testing.T) {
 // transition.
 func TestStateMachineSpendMapper(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// Create the state machine.
 	env := &dummyEnv{}
@@ -808,7 +807,7 @@ func (d *dummyMsgMapper) MapMsg(wireMsg msgmux.PeerMsg) fn.Option[dummyEvents] {
 // TestStateMachineMsgMapper tests that given a message mapper, we can properly
 // send in wire messages get mapped to FSM events.
 func TestStateMachineMsgMapper(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// First, we'll create our state machine given the env, and our
 	// starting state.

routing/localchans/manager_test.go

@@ -317,7 +317,7 @@ func TestManager(t *testing.T) {
 			expectedNumUpdates = test.expectedNumUpdates
 
 			failedUpdates, err := manager.UpdatePolicy(
-				context.Background(),
+				t.Context(),
 				test.newPolicy,
 				test.createMissingEdge,
 				test.specifiedChanPoints...)

routing/pathfind_test.go

@@ -184,7 +184,7 @@ func makeTestGraph(t *testing.T, useCache bool) (*graphdb.ChannelGraph,
 func parseTestGraph(t *testing.T, useCache bool, path string) (
 	*testGraphInstance, error) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	graphJSON, err := os.ReadFile(path)
 	if err != nil {
@@ -526,7 +526,7 @@ func createTestGraphFromChannels(t *testing.T, useCache bool,
 	testChannels []*testChannel, source string,
 	sourceFeatureBits ...lnwire.FeatureBit) (*testGraphInstance, error) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	// We'll use this fake address for the IP address of all the nodes in
 	// our tests. This value isn't needed for path finding so it doesn't
@@ -1090,7 +1090,7 @@ func runBasicGraphPathFinding(t *testing.T, useCache bool) {
 func testBasicGraphPathFindingCase(t *testing.T, graphInstance *testGraphInstance,
 	test *basicGraphPathFindingTestCase) {
 
-	ctx := context.Background()
+	ctx := t.Context()
 	aliases := graphInstance.aliasMap
 	expectedHops := test.expectedHops
 	expectedHopCount := len(expectedHops)
@@ -1235,7 +1235,7 @@ func runPathFindingWithAdditionalEdges(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
@@ -1320,7 +1320,7 @@ func runPathFindingWithBlindedPathDuplicateHop(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
@@ -1807,7 +1807,7 @@ func runPathNotAvailable(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
@@ -1865,7 +1865,7 @@ func runDestTLVGraphFallback(t *testing.T, useCache bool) {
 
 	ctx := newPathFindingTestContext(t, useCache, testChannels, "roasbeef")
 
-	sourceNode, err := ctx.graph.SourceNode(context.Background())
+	sourceNode, err := ctx.graph.SourceNode(t.Context())
 	require.NoError(t, err, "unable to fetch source node")
 
 	find := func(r *RestrictParams,
@@ -2083,7 +2083,7 @@ func runPathInsufficientCapacity(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
 
@@ -2114,7 +2114,7 @@ func runRouteFailMinHTLC(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
 
@@ -2179,7 +2179,7 @@ func runRouteFailMaxHTLC(t *testing.T, useCache bool) {
 	midEdge.MessageFlags = 1
 	midEdge.MaxHTLC = payAmt - 1
 	midEdge.LastUpdate = midEdge.LastUpdate.Add(time.Second)
-	err = graph.UpdateEdgePolicy(context.Background(), midEdge)
+	err = graph.UpdateEdgePolicy(t.Context(), midEdge)
 	require.NoError(t, err)
 
 	// We'll now attempt to route through that edge with a payment above
@@ -2199,7 +2199,7 @@ func runRouteFailDisabledEdge(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
 
@@ -2268,7 +2268,7 @@ func runPathSourceEdgesBandwidth(t *testing.T, useCache bool) {
 	graph, err := parseTestGraph(t, useCache, basicGraphFilePath)
 	require.NoError(t, err, "unable to create graph")
 
-	ctx := context.Background()
+	ctx := t.Context()
 	sourceNode, err := graph.graph.SourceNode(ctx)
 	require.NoError(t, err, "unable to fetch source node")
 
@@ -3202,7 +3202,7 @@ func newPathFindingTestContext(t *testing.T, useCache bool,
 	require.NoError(t, err, "unable to create graph")
 
 	sourceNode, err := testGraphInstance.graph.SourceNode(
-		context.Background(),
+		t.Context(),
 	)
 	require.NoError(t, err, "unable to fetch source node")
 

routing/payment_lifecycle_test.go

@@ -198,7 +198,7 @@ func sendPaymentAndAssertSucceeded(t *testing.T,
 	// We now make a call to `resumePayment` and expect it to return the
 	// preimage.
 	go func() {
-		preimage, _, err := p.resumePayment(context.Background())
+		preimage, _, err := p.resumePayment(t.Context())
 		resultChan <- &resumePaymentResult{
 			preimage: preimage,
 			err:      err,
@@ -294,7 +294,7 @@ func TestCheckTimeoutTimedOut(t *testing.T) {
 	t.Parallel()
 
 	deadline := time.Now().Add(time.Nanosecond)
-	ctx, cancel := context.WithDeadline(context.Background(), deadline)
+	ctx, cancel := context.WithDeadline(t.Context(), deadline)
 	defer cancel()
 
 	p := createTestPaymentLifecycle()
@@ -330,7 +330,7 @@ func TestCheckTimeoutTimedOut(t *testing.T) {
 
 	// Make the timeout happens instantly.
 	deadline = time.Now().Add(time.Nanosecond)
-	ctx, cancel = context.WithDeadline(context.Background(), deadline)
+	ctx, cancel = context.WithDeadline(t.Context(), deadline)
 	defer cancel()
 
 	// Sleep one millisecond to make sure it timed out.
@@ -349,7 +349,7 @@ func TestCheckTimeoutTimedOut(t *testing.T) {
 func TestCheckTimeoutOnRouterQuit(t *testing.T) {
 	t.Parallel()
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 	defer cancel()
 
 	p := createTestPaymentLifecycle()
@@ -795,7 +795,7 @@ func TestResumePaymentFailOnFetchPayment(t *testing.T) {
 	m.control.On("FetchPayment", p.identifier).Return(nil, errDummy)
 
 	// Send the payment and assert it failed.
-	sendPaymentAndAssertError(t, context.Background(), p, errDummy)
+	sendPaymentAndAssertError(t, t.Context(), p, errDummy)
 
 	// Expected collectResultAsync to not be called.
 	require.Zero(t, m.collectResultsCount)
@@ -831,7 +831,7 @@ func TestResumePaymentFailOnTimeout(t *testing.T) {
 	// 3. make the timeout happens instantly and sleep one millisecond to
 	// make sure it timed out.
 	deadline := time.Now().Add(time.Nanosecond)
-	ctx, cancel := context.WithDeadline(context.Background(), deadline)
+	ctx, cancel := context.WithDeadline(t.Context(), deadline)
 	defer cancel()
 	time.Sleep(1 * time.Millisecond)
 
@@ -882,7 +882,7 @@ func TestResumePaymentFailOnTimeoutErr(t *testing.T) {
 
 	// Send the payment and assert it failed when router is shutting down.
 	sendPaymentAndAssertError(
-		t, context.Background(), p, ErrRouterShuttingDown,
+		t, t.Context(), p, ErrRouterShuttingDown,
 	)
 
 	// Expected collectResultAsync to not be called.
@@ -900,7 +900,7 @@ func TestResumePaymentFailContextCancel(t *testing.T) {
 	p, m := setupTestPaymentLifecycle(t)
 
 	// Create the cancelable payment context.
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(t.Context())
 
 	paymentAmt := lnwire.MilliSatoshi(10000)
 
@@ -977,7 +977,7 @@ func TestResumePaymentFailOnStepErr(t *testing.T) {
 	m.payment.On("AllowMoreAttempts").Return(false, errDummy).Once()
 
 	// Send the payment and assert it failed.
-	sendPaymentAndAssertError(t, context.Background(), p, errDummy)
+	sendPaymentAndAssertError(t, t.Context(), p, errDummy)
 
 	// Expected collectResultAsync to not be called.
 	require.Zero(t, m.collectResultsCount)
@@ -1021,7 +1021,7 @@ func TestResumePaymentFailOnRequestRouteErr(t *testing.T) {
 	).Return(nil, errDummy).Once()
 
 	// Send the payment and assert it failed.
-	sendPaymentAndAssertError(t, context.Background(), p, errDummy)
+	sendPaymentAndAssertError(t, t.Context(), p, errDummy)
 
 	// Expected collectResultAsync to not be called.
 	require.Zero(t, m.collectResultsCount)
@@ -1081,7 +1081,7 @@ func TestResumePaymentFailOnRegisterAttemptErr(t *testing.T) {
 	).Return(nil, errDummy).Once()
 
 	// Send the payment and assert it failed.
-	sendPaymentAndAssertError(t, context.Background(), p, errDummy)
+	sendPaymentAndAssertError(t, t.Context(), p, errDummy)
 
 	// Expected collectResultAsync to not be called.
 	require.Zero(t, m.collectResultsCount)
@@ -1173,7 +1173,7 @@ func TestResumePaymentFailOnSendAttemptErr(t *testing.T) {
 	).Return(nil, errDummy).Once()
 
 	// Send the payment and assert it failed.
-	sendPaymentAndAssertError(t, context.Background(), p, errDummy)
+	sendPaymentAndAssertError(t, t.Context(), p, errDummy)
 
 	// Expected collectResultAsync to not be called.
 	require.Zero(t, m.collectResultsCount)

routing/router_test.go

@@ -132,7 +132,7 @@ func createTestCtxFromGraphInstanceAssumeValid(t *testing.T,
 	)
 	require.NoError(t, err)
 
-	sourceNode, err := graphInstance.graph.SourceNode(context.Background())
+	sourceNode, err := graphInstance.graph.SourceNode(t.Context())
 	require.NoError(t, err)
 	sessionSource := &SessionSource{
 		GraphSessionFactory: graphInstance.graph,
@@ -1202,7 +1202,7 @@ func TestFindPathFeeWeighting(t *testing.T) {
 	var preImage [32]byte
 	copy(preImage[:], bytes.Repeat([]byte{9}, 32))
 
-	sourceNode, err := ctx.graph.SourceNode(context.Background())
+	sourceNode, err := ctx.graph.SourceNode(t.Context())
 	require.NoError(t, err, "unable to fetch source node")
 
 	amt := lnwire.MilliSatoshi(100)
@@ -2706,7 +2706,7 @@ func TestNewRouteRequest(t *testing.T) {
 // announcements for the channel vertexes to be able to use the channel.
 func TestAddEdgeUnknownVertexes(t *testing.T) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	const startingBlockHeight = 101
 	ctx := createTestCtxFromFile(t, startingBlockHeight, basicGraphFilePath)

rpcserver.go

@@ -7986,7 +7986,7 @@ func (r *rpcServer) UpdateChannelPolicy(ctx context.Context,
 		errMsg := "cannot set both FeeRate and FeeRatePpm at the " +
 			"same time"
 
-		return nil, status.Errorf(codes.InvalidArgument, errMsg)
+		return nil, status.Errorf(codes.InvalidArgument, "%v", errMsg)
 
 	// If the request is using fee_rate.
 	case req.FeeRate != 0:

sqldb/go.mod

@@ -75,4 +75,4 @@ require (
 	modernc.org/token v1.1.0 // indirect
 )
 
-go 1.23.12
+go 1.24.6

sqldb/migrations_test.go

@@ -1,7 +1,6 @@
 package sqldb
 
 import (
-	"context"
 	"database/sql"
 	"fmt"
 	"path/filepath"
@@ -75,7 +74,7 @@ func TestMigrations(t *testing.T) {
 // 2592000 seconds for AMP invoices.
 func testInvoiceExpiryMigration(t *testing.T, makeDB makeMigrationTestDB) {
 	t.Parallel()
-	ctxb := context.Background()
+	ctxb := t.Context()
 
 	// Create a new database that already has the first version of the
 	// native invoice schema.
@@ -276,7 +275,7 @@ func TestCustomMigration(t *testing.T) {
 		},
 	}
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	for _, test := range tests {
 		// checkSchemaVersion checks the database schema version against
 		// the expected version.
@@ -391,7 +390,7 @@ func TestCustomMigration(t *testing.T) {
 				"migrations", dbName)
 
 			_, err := fixture.db.ExecContext(
-				context.Background(), "CREATE DATABASE "+dbName,
+				t.Context(), "CREATE DATABASE "+dbName,
 			)
 			require.NoError(t, err)
 
@@ -490,7 +489,7 @@ func TestSchemaMigrationIdempotency(t *testing.T) {
 				)
 			})
 
-			ctxb := context.Background()
+			ctxb := t.Context()
 			require.NoError(
 				t, db.ApplyAllMigrations(ctxb, GetMigrations()),
 			)
@@ -536,7 +535,7 @@ func TestSchemaMigrationIdempotency(t *testing.T) {
 			"migrations", dbName)
 
 		_, err := fixture.db.ExecContext(
-			context.Background(), "CREATE DATABASE "+dbName,
+			t.Context(), "CREATE DATABASE "+dbName,
 		)
 		require.NoError(t, err)
 
@@ -550,7 +549,7 @@ func TestSchemaMigrationIdempotency(t *testing.T) {
 			db, err = NewPostgresStore(cfg)
 			require.NoError(t, err)
 
-			ctxb := context.Background()
+			ctxb := t.Context()
 			require.NoError(
 				t, db.ApplyAllMigrations(ctxb, GetMigrations()),
 			)
@@ -601,7 +600,7 @@ func TestMigrationSucceedsAfterDirtyStateMigrationFailure19RC1(t *testing.T) {
 		failingSchemaVersion        = 3
 	)
 
-	ctxb := context.Background()
+	ctxb := t.Context()
 	migrations := GetMigrations()
 	migrations = migrations[:maxSchemaVersionBefore19RC1]
 	lastMigration := migrations[len(migrations)-1]
@@ -692,7 +691,7 @@ func TestMigrationSucceedsAfterDirtyStateMigrationFailure19RC1(t *testing.T) {
 			"migrations", dbName)
 
 		_, err := fixture.db.ExecContext(
-			context.Background(), "CREATE DATABASE "+dbName,
+			t.Context(), "CREATE DATABASE "+dbName,
 		)
 		require.NoError(t, err)
 

sqldb/paginate_test.go

@@ -18,7 +18,7 @@ import (
 func TestExecuteBatchQuery(t *testing.T) {
 	t.Parallel()
 
-	ctx := context.Background()
+	ctx := t.Context()
 
 	t.Run("empty input returns nil", func(t *testing.T) {
 		var (
@@ -245,7 +245,7 @@ func TestExecuteBatchQuery(t *testing.T) {
 // executing the query in pages.
 func TestSQLSliceQueries(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	db := NewTestDB(t)
 
@@ -327,7 +327,7 @@ func TestSQLSliceQueries(t *testing.T) {
 // page until all items are processed or an error occurs.
 func TestExecutePaginatedQuery(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 
 	type testItem struct {
 		id   int64
@@ -944,7 +944,7 @@ func TestExecuteCollectAndBatchWithSharedDataQuery(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			ctx := context.Background()
+			ctx := t.Context()
 			cfg := &QueryConfig{
 				MaxPageSize: tt.maxPageSize,
 			}

tlv/go.mod

@@ -22,4 +22,4 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
-go 1.23.12
+go 1.24.6

tools/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.23.12
+FROM golang:1.24.6
 
 RUN apt-get update && apt-get install -y git
 ENV GOCACHE=/tmp/build/.cache
@@ -10,8 +10,8 @@ RUN cd /tmp \
   && mkdir -p /tmp/build/.cache \
   && mkdir -p /tmp/build/.modcache \
   && cd /tmp/tools \
-  && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint \
-  && golangci-lint custom \
+  && CGO_ENABLED=0 go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint \
+  && CGO_ENABLED=0 golangci-lint custom \
   && mv ./custom-gcl /usr/local/bin/custom-gcl \
   && chmod -R 777 /tmp/build/ \
   && git config --global --add safe.directory /build

tools/go.mod

@@ -1,6 +1,6 @@
 module github.com/lightningnetwork/lnd/tools
 
-go 1.23.12
+go 1.24.6
 
 require (
 	github.com/btcsuite/btcd v0.24.2

tools/linters/go.mod

@@ -1,6 +1,6 @@
 module github.com/lightningnetwork/lnd/tools/linters
 
-go 1.22.6
+go 1.24.6
 
 require (
 	github.com/golangci/plugin-module-register v0.1.1

tor/controller.go

@@ -250,7 +250,7 @@ func (c *Controller) Reconnect() error {
 // sendCommand sends a command to the Tor server and returns its response, as a
 // single space-delimited string, and code.
 func (c *Controller) sendCommand(command string) (int, string, error) {
-	id, err := c.conn.Cmd(command)
+	id, err := c.conn.Cmd("%v", command)
 	if err != nil {
 		return 0, "", err
 	}

tor/go.mod

@@ -23,4 +23,4 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
-go 1.23.12
+go 1.24.6