lnrpc: rename FloatValue to FloatMetric

This commit renames lnrpc.FloatValue to lnrpc.FloatMetric as requested
in the final review of centrality PR.

lnrpc/rpc.proto

@@ -651,7 +651,6 @@ service Lightning {
         };
     }
 
-
     /** lncli: `getchaninfo`
     GetChanInfo returns the latest authenticated network announcement for the
     given channel identified by its channel ID: an 8-byte integer which
@@ -2527,13 +2526,14 @@ message ChannelGraph {
     repeated ChannelEdge edges = 2;
 }
 
-enum NodeMetricType {
+enum NodeMetricType { 
-    BETWEENNESS_CENTRALITY = 0;
+    UNKNOWN = 0;
+    BETWEENNESS_CENTRALITY = 1; 
 }
 
 message NodeMetricsRequest {
-  /// The requesteded node metrics.
+    /// The requested node metrics.
-  repeated NodeMetricType types = 1;
+    repeated NodeMetricType types = 1;
 }
 
 message NodeMetricsResponse {
@@ -2544,15 +2544,15 @@ message NodeMetricsResponse {
     Map of node pubkey to betweenness centrality of the node. Normalized
     values are in the [0,1] closed interval.
     */
-    map<string, FloatValue> betweenness_centrality = 1;
+    map<string, FloatMetric> betweenness_centrality = 1;
 }
 
-message FloatValue {
+message FloatMetric {
-  /// Arbitrary float value.
+    /// Arbitrary float value.
-  double value = 1;
+    double value = 1;
 
-  /// The value normalized to [0,1] or [-1,1].
+    /// The value normalized to [0,1] or [-1,1].
-  double normalized_value = 2;
+    double normalized_value = 2;
 }
 
 message ChanInfoRequest {

lnrpc/rpc.swagger.json

@@ -733,13 +733,14 @@
         "parameters": [
           {
             "name": "types",
-            "description": "/ The requesteded node metrics.",
+            "description": "/ The requested node metrics.",
             "in": "query",
             "required": false,
             "type": "array",
             "items": {
               "type": "string",
               "enum": [
+                "UNKNOWN",
                 "BETWEENNESS_CENTRALITY"
               ]
             },
@@ -2717,7 +2718,7 @@
         }
       }
     },
-    "lnrpcFloatValue": {
+    "lnrpcFloatMetric": {
       "type": "object",
       "properties": {
         "value": {
@@ -3625,9 +3626,10 @@
     "lnrpcNodeMetricType": {
       "type": "string",
       "enum": [
+        "UNKNOWN",
         "BETWEENNESS_CENTRALITY"
       ],
-      "default": "BETWEENNESS_CENTRALITY"
+      "default": "UNKNOWN"
     },
     "lnrpcNodeMetricsResponse": {
       "type": "object",
@@ -3635,7 +3637,7 @@
         "betweenness_centrality": {
           "type": "object",
           "additionalProperties": {
-            "$ref": "#/definitions/lnrpcFloatValue"
+            "$ref": "#/definitions/lnrpcFloatMetric"
           },
           "description": "*\nBetweenness centrality is the sum of the ratio of shortest paths that pass\nthrough the node for each pair of nodes in the graph (not counting paths\nstarting or ending at this node).\nMap of node pubkey to betweenness centrality of the node. Normalized\nvalues are in the [0,1] closed interval."
         }

rpcserver.go

@@ -4688,7 +4688,7 @@ func (r *rpcServer) GetNodeMetrics(ctx context.Context,
 	}
 
 	resp := &lnrpc.NodeMetricsResponse{
-		BetweennessCentrality: make(map[string]*lnrpc.FloatValue),
+		BetweennessCentrality: make(map[string]*lnrpc.FloatMetric),
 	}
 
 	// Obtain the pointer to the global singleton channel graph, this will
@@ -4712,9 +4712,10 @@ func (r *rpcServer) GetNodeMetrics(ctx context.Context,
 	// Fill normalized and non normalized centrality.
 	centrality := centralityMetric.GetMetric(true)
 	for nodeID, val := range centrality {
-		resp.BetweennessCentrality[hex.EncodeToString(nodeID[:])] = &lnrpc.FloatValue{
+		resp.BetweennessCentrality[hex.EncodeToString(nodeID[:])] =
-			NormalizedValue: val,
+			&lnrpc.FloatMetric{
-		}
+				NormalizedValue: val,
+			}
 	}
 
 	centrality = centralityMetric.GetMetric(false)