multi: rename nolint:lll to nolint:ll

Find and replace all nolint instances refering to the `lll` linter and
replace with `ll` which is the name of our custom version of the `lll`
linter which can be used to ignore log lines during linting.

The next commit will do the configuration of the custom linter and
disable the default one.
This commit is contained in:
Elle Mouton committed 2024-12-02 09:14:21 +02:00
1 parent 88f5369066
commit ab7aae0708
123 files changed
+286 -286

No files matched your search

+1 -1
View File
@@ -382,7 +382,7 @@ func testChannelBackupRestoreBasic(ht *lntest.HarnessTest) {
// create a new nodeRestorer that will restore
// using the on-disk channel.backup.
//
//nolint:lll
//nolint:ll
backup := &lnrpc.RestoreChanBackupRequest_MultiChanBackup{
MultiChanBackup: multi,
}
+2 -2
View File
@@ -609,7 +609,7 @@ func channelForceClosureTest(ht *lntest.HarnessTest,
// We expect alice to have a timeout tx resolution with
// an amount equal to the payment amount.
//nolint:lll
//nolint:ll
aliceReports[outpoint.String()] = &lnrpc.Resolution{
ResolutionType: lnrpc.ResolutionType_OUTGOING_HTLC,
Outcome: lnrpc.ResolutionOutcome_FIRST_STAGE,
@@ -622,7 +622,7 @@ func channelForceClosureTest(ht *lntest.HarnessTest,
// incoming htlc timeout which reflects the full amount
// of the htlc. It has no spend tx, because carol stops
// monitoring the htlc once it has timed out.
//nolint:lll
//nolint:ll
carolReports[outpoint.String()] = &lnrpc.Resolution{
ResolutionType: lnrpc.ResolutionType_INCOMING_HTLC,
Outcome: lnrpc.ResolutionOutcome_TIMEOUT,
+1 -1
View File
@@ -19,7 +19,7 @@ var (
probeAmt = int64(probeAmount) * 1_000
failureReasonNone = lnrpc.PaymentFailureReason_FAILURE_REASON_NONE
failureReasonNoRoute = lnrpc.PaymentFailureReason_FAILURE_REASON_NO_ROUTE //nolint:lll
failureReasonNoRoute = lnrpc.PaymentFailureReason_FAILURE_REASON_NO_ROUTE //nolint:ll
)
const (
+1 -1
View File
@@ -144,7 +144,7 @@ func testBasicChannelFunding(ht *lntest.HarnessTest) {
chansCommitType == lnrpc.CommitmentType_ANCHORS:
case expType == lnrpc.CommitmentType_STATIC_REMOTE_KEY &&
chansCommitType == lnrpc.CommitmentType_STATIC_REMOTE_KEY: //nolint:lll
chansCommitType == lnrpc.CommitmentType_STATIC_REMOTE_KEY: //nolint:ll
case expType == lnrpc.CommitmentType_LEGACY &&
chansCommitType == lnrpc.CommitmentType_LEGACY:
+1 -1
View File
@@ -21,7 +21,7 @@ func testHoldInvoicePersistence(ht *lntest.HarnessTest) {
const (
chanAmt = btcutil.Amount(1000000)
numPayments = 10
reason = lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS //nolint:lll
reason = lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS //nolint:ll
)
// Create carol, and clean up when the test finishes.
+1 -1
View File
@@ -114,7 +114,7 @@ func (h *holdSubscription) cancel(ht *lntest.HarnessTest) {
)
require.Equal(ht, lnrpc.Payment_FAILED, payUpdate.Status,
"expected payment failed")
require.Equal(ht, lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:lll
require.Equal(ht, lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:ll
payUpdate.FailureReason, "expected unknown details")
}
@@ -138,7 +138,7 @@ func testHtlcErrorPropagation(ht *lntest.HarnessTest) {
}
ht.SendPaymentAssertFail(
alice, sendReq,
lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:lll
lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:ll
)
ht.AssertLastHTLCError(
alice, lnrpc.Failure_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS,
@@ -207,7 +207,7 @@ func testHtlcErrorPropagation(ht *lntest.HarnessTest) {
}
ht.SendPaymentAssertFail(
alice, sendReq,
lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:lll
lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS, //nolint:ll
)
ht.AssertLastHTLCError(
alice, lnrpc.Failure_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS,
+1 -1
View File
@@ -1137,7 +1137,7 @@ func testSweepHTLCs(ht *lntest.HarnessTest) {
return incoming, outgoing
}
//nolint:lll
//nolint:ll
// For neutrino backend, we need to give it more time to sync the
// blocks. There's a potential bug we need to fix:
// 2024-04-18 23:36:07.046 [ERR] NTFN: unable to get missed blocks: starting height 487 is greater than ending height 486