mirror/lnd
1
0 Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

build: classify cmd/* as MEDIUM in PR severity bot

Browse Source 
The severity bot was misclassifying CLI client code as HIGH because
filenames like cmd_walletunlocker.go matched the walletunlocker/*
auth/security keyword. Add cmd/* explicitly to the MEDIUM tier and
add a classification rule to prevent filename-based false positives.
This commit is contained in:
ziggie committed 2026-02-10 10:48:09 +01:00
1 parent 3807c6c563
commit ad8b64417f
1 file changed
+8 -3
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/pr-severity.yml
+8 -3
View File
@@ -95,6 +95,7 @@ jobs:
- chainntnfs/*, chanacceptor/*, protofsm/*, sqldb/* - chainntnfs/*, chanacceptor/*, protofsm/*, sqldb/*
**MEDIUM** (severity-medium) - Focused review: **MEDIUM** (severity-medium) - Focused review:
- cmd/* - CLI client commands (do NOT inherit severity from server-side packages with similar names)
- payments/*, autopilot/*, lncfg/*, chanfitness/* - payments/*, autopilot/*, lncfg/*, chanfitness/*
- netann/*, kvdb/*, chanbackup/*, aezeed/*, tor/* - netann/*, kvdb/*, chanbackup/*, aezeed/*, tor/*
- zpay32/*, tlv/*, fn/*, record/*, amp/* - zpay32/*, tlv/*, fn/*, record/*, amp/*
@@ -110,12 +111,16 @@ jobs:
## Classification Rules ## Classification Rules
1. The HIGHEST severity file determines the PR severity 1. The HIGHEST severity file determines the PR severity
2. Bump severity UP one level if: 2. Classify files by their actual package path, NOT by filename keywords.
Files under cmd/* are CLI client code and should always be MEDIUM,
even if the filename contains a server-side package name (e.g.
cmd/commands/cmd_walletunlocker.go is MEDIUM, not HIGH).
3. Bump severity UP one level if:
- PR touches >20 files (excluding tests and auto-generated files) - PR touches >20 files (excluding tests and auto-generated files)
- PR has >500 lines changed (excluding tests and auto-generated files) - PR has >500 lines changed (excluding tests and auto-generated files)
- PR touches multiple distinct critical packages - PR touches multiple distinct critical packages
3. Check for override labels first (severity-override-*). If present, respect the override. 4. Check for override labels first (severity-override-*). If present, respect the override.
4. Database migrations (channeldb/migration*, sqldb/*, wtdb/*) are always CRITICAL 5. Database migrations (channeldb/migration*, sqldb/*, wtdb/*) are always CRITICAL
## Files to Exclude from Line/File Counting ## Files to Exclude from Line/File Counting
When calculating file count and lines changed for severity bumps, exclude: When calculating file count and lines changed for severity bumps, exclude: