From 90ed0fe54c103a00ec884d48941ddba490d8060d Mon Sep 17 00:00:00 2001
From: Elle Mouton <elle.mouton@gmail.com>
Date: Mon, 18 Nov 2024 21:06:06 +0200
Subject: [PATCH 1/2] lntest: nil check edges

---
 lntest/harness_assertion.go | 4 ++--
 lntest/node/state.go        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lntest/harness_assertion.go b/lntest/harness_assertion.go
index b487e7e32..1b079fea1 100644
--- a/lntest/harness_assertion.go
+++ b/lntest/harness_assertion.go
@@ -255,10 +255,10 @@ func (h *HarnessTest) AssertNumActiveEdges(hn *node.HarnessNode,
 	// filterDisabled is a helper closure that filters out disabled
 	// channels.
 	filterDisabled := func(edge *lnrpc.ChannelEdge) bool {
-		if edge.Node1Policy.Disabled {
+		if edge.Node1Policy != nil && edge.Node1Policy.Disabled {
 			return false
 		}
-		if edge.Node2Policy.Disabled {
+		if edge.Node2Policy != nil && edge.Node2Policy.Disabled {
 			return false
 		}
 
diff --git a/lntest/node/state.go b/lntest/node/state.go
index 6b9446240..a89ab7d2c 100644
--- a/lntest/node/state.go
+++ b/lntest/node/state.go
@@ -312,10 +312,10 @@ func (s *State) updateEdgeStats() {
 	// filterDisabled is a helper closure that filters out disabled
 	// channels.
 	filterDisabled := func(edge *lnrpc.ChannelEdge) bool {
-		if edge.Node1Policy.Disabled {
+		if edge.Node1Policy != nil && edge.Node1Policy.Disabled {
 			return false
 		}
-		if edge.Node2Policy.Disabled {
+		if edge.Node2Policy != nil && edge.Node2Policy.Disabled {
 			return false
 		}
 

From 9f72ce7dd43fbfe411bb2e7512628543be4b27a8 Mon Sep 17 00:00:00 2001
From: Elle Mouton <elle.mouton@gmail.com>
Date: Mon, 18 Nov 2024 13:48:35 +0200
Subject: [PATCH 2/2] config: remove default values for deprecated fields

These values have been deprecated but since we still set the default
values, the "please remove it" error still shows up.
---
 config.go | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/config.go b/config.go
index 9b9e9573e..dc9a1453c 100644
--- a/config.go
+++ b/config.go
@@ -562,8 +562,6 @@ func DefaultConfig() Config {
 		LetsEncryptDir:    defaultLetsEncryptDir,
 		LetsEncryptListen: defaultLetsEncryptListen,
 		LogDir:            defaultLogDir,
-		MaxLogFiles:       build.DefaultMaxLogFiles,
-		MaxLogFileSize:    build.DefaultMaxLogFileSize,
 		AcceptorTimeout:   defaultAcceptorTimeout,
 		WSPingInterval:    lnrpc.DefaultPingInterval,
 		WSPongWait:        lnrpc.DefaultPongWait,
@@ -1417,7 +1415,7 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
 		os.Exit(0)
 	}
 
-	if cfg.MaxLogFiles != build.DefaultMaxLogFiles {
+	if cfg.MaxLogFiles != 0 {
 		if cfg.LogConfig.File.MaxLogFiles !=
 			build.DefaultMaxLogFiles {
 
@@ -1427,7 +1425,7 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
 
 		cfg.LogConfig.File.MaxLogFiles = cfg.MaxLogFiles
 	}
-	if cfg.MaxLogFileSize != build.DefaultMaxLogFileSize {
+	if cfg.MaxLogFileSize != 0 {
 		if cfg.LogConfig.File.MaxLogFileSize !=
 			build.DefaultMaxLogFileSize {