Merge pull request #5650 from Roasbeef/go-1-17

build: upgrade all CI+build infra to Go 1.17

.github/pull_request_template.md

@@ -1,6 +1,6 @@
 #### Pull Request Checklist
 
-- [ ] All changes are Go version 1.15 compliant
+- [ ] All changes are Go version 1.16 compliant
 - [ ] Your PR passes all CI checks. If a check cannot be passed for a justifiable reason, that reason must be stated in the commit message and PR description.
 - [ ] If this is your first time contributing, we recommend you read the [Code Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md)
    - [ ] The code being submitted is commented according to [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation)

.github/workflows/main.yml

@@ -24,7 +24,7 @@ env:
   # /dev.Dockerfile
   # /make/builder.Dockerfile
   # /.github/workflows/release.yml
-  GO_VERSION: 1.16.3
+  GO_VERSION: 1.17.1
 
 jobs:
   ########################

.github/workflows/release.yaml

@@ -16,7 +16,7 @@ env:
   # /dev.Dockerfile
   # /make/builder.Dockerfile
   # /.github/workflows/main.yml
-  GO_VERSION: 1.16.3
+  GO_VERSION: 1.17.1
 
 jobs:
   main:

.travis.yml

@@ -21,7 +21,7 @@ go:
   # /make/builder.Dockerfile
   # /.github/workflows/main.yml
   # /.github/workflows/release.yml
-  - 1.16.3
+  - "1.17.x"
 
 env:
   global:

Dockerfile

@@ -4,7 +4,7 @@
 # /make/builder.Dockerfile
 # /.github/workflows/main.yml
 # /.github/workflows/release.yml
-FROM golang:1.16.3-alpine as builder
+FROM golang:1.17.1-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.

aezeed/cipherseed_rpctest.go

@@ -1,3 +1,4 @@
+//go:build rpctest
 // +build rpctest
 
 package aezeed

build/deployment_dev.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package build

build/deployment_prod.go

@@ -1,3 +1,4 @@
+//go:build !dev
 // +build !dev
 
 package build

build/log_default.go

@@ -1,3 +1,4 @@
+//go:build !stdlog && !nolog
 // +build !stdlog,!nolog
 
 package build

build/log_nolog.go

@@ -1,3 +1,4 @@
+//go:build nolog
 // +build nolog
 
 package build

build/log_stdlog.go

@@ -1,3 +1,4 @@
+//go:build stdlog
 // +build stdlog
 
 package build

build/loglevel_critical.go

@@ -1,3 +1,4 @@
+//go:build dev && critical
 // +build dev,critical
 
 package build

build/loglevel_debug.go

@@ -1,3 +1,4 @@
+//go:build dev && debug
 // +build dev,debug
 
 package build

build/loglevel_default.go

@@ -1,3 +1,4 @@
+//go:build !info && !debug && !trace && !warn && !error && !critical && !off
 // +build !info,!debug,!trace,!warn,!error,!critical,!off
 
 package build

build/loglevel_error.go

@@ -1,3 +1,4 @@
+//go:build dev && error
 // +build dev,error
 
 package build

build/loglevel_info.go

@@ -1,3 +1,4 @@
+//go:build dev && info
 // +build dev,info
 
 package build

build/loglevel_off.go

@@ -1,3 +1,4 @@
+//go:build dev && off
 // +build dev,off
 
 package build

build/loglevel_trace.go

@@ -1,3 +1,4 @@
+//go:build dev && trace
 // +build dev,trace
 
 package build

build/loglevel_warn.go

@@ -1,3 +1,4 @@
+//go:build dev && warn
 // +build dev,warn
 
 package build

chainntnfs/bitcoindnotify/bitcoind_dev.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package bitcoindnotify

chainntnfs/bitcoindnotify/bitcoind_test.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package bitcoindnotify

chainntnfs/btcdnotify/btcd_dev.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package btcdnotify

chainntnfs/btcdnotify/btcd_test.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package btcdnotify

chainntnfs/interface_dev.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package chainntnfs

chainntnfs/neutrinonotify/neutrino_dev.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package neutrinonotify

chainntnfs/test/bitcoind/bitcoind_test.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package bitcoind_test

chainntnfs/test/btcd/btcd_test.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package btcd_test

chainntnfs/test/neutrino/neutrino_test.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package neutrino_test

chainntnfs/test/test_interface.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package chainntnfstest

chainntnfs/test_utils.go

@@ -1,3 +1,4 @@
+//go:build dev
 // +build dev
 
 package chainntnfs

cluster/etcd_elector.go

@@ -1,3 +1,4 @@
+//go:build kvdb_etcd
 // +build kvdb_etcd
 
 package cluster

cluster/etcd_elector_factory.go

@@ -1,3 +1,4 @@
+//go:build kvdb_etcd
 // +build kvdb_etcd
 
 package cluster

cluster/etcd_elector_test.go

@@ -1,3 +1,4 @@
+//go:build kvdb_etcd
 // +build kvdb_etcd
 
 package cluster

cmd/lncli/autopilotrpc_active.go

@@ -1,3 +1,4 @@
+//go:build autopilotrpc
 // +build autopilotrpc
 
 package main

cmd/lncli/autopilotrpc_default.go

@@ -1,3 +1,4 @@
+//go:build !autopilotrpc
 // +build !autopilotrpc
 
 package main

cmd/lncli/invoicesrpc_active.go

@@ -1,3 +1,4 @@
+//go:build invoicesrpc
 // +build invoicesrpc
 
 package main

cmd/lncli/invoicesrpc_default.go

@@ -1,3 +1,4 @@
+//go:build !invoicesrpc
 // +build !invoicesrpc
 
 package main

cmd/lncli/walletrpc_active.go

@@ -1,3 +1,4 @@
+//go:build walletrpc
 // +build walletrpc
 
 package main

cmd/lncli/walletrpc_default.go

@@ -1,3 +1,4 @@
+//go:build !walletrpc
 // +build !walletrpc
 
 package main

cmd/lncli/watchtower_active.go

@@ -1,3 +1,4 @@
+//go:build watchtowerrpc
 // +build watchtowerrpc
 
 package main

cmd/lncli/watchtower_default.go

@@ -1,3 +1,4 @@
+//go:build !watchtowerrpc
 // +build !watchtowerrpc
 
 package main

dev.Dockerfile

@@ -4,7 +4,7 @@
 # /make/builder.Dockerfile
 # /.github/workflows/main.yml
 # /.github/workflows/release.yml
-FROM golang:1.16.3-alpine as builder
+FROM golang:1.17.1-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docker/btcd/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.16.3-alpine as builder
+FROM golang:1.17.1-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docker/ltcd/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.16.3-alpine as builder
+FROM golang:1.17.1-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docs/INSTALL.md

@@ -93,46 +93,46 @@ version if there are database migrations present.
   * **Go:** `lnd` is written in Go. To install, run one of the following commands:
 
 
-    **Note**: The minimum version of Go supported is Go 1.15. We recommend that
+    **Note**: The minimum version of Go supported is Go 1.16. We recommend that
     users use the latest version of Go, which at the time of writing is
-    [`1.16`](https://blog.golang.org/go1.16).
+    [`1.17.1`](https://blog.golang.org/go1.17.1).
 
 
     On Linux:
 
     (x86-64)
     ```
-    wget https://dl.google.com/go/go1.16.linux-amd64.tar.gz
-    sha256sum go1.16.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
+    wget https://dl.google.com/go/go1.17.1.linux-amd64.tar.gz
+    sha256sum go1.17.1.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
     ```
 
     The final output of the command above should be
-    `013a489ebb3e24ef3d915abe5b94c3286c070dfe0818d5bca8108f1d6e8440d2`. If it
+    `dab7d9c34361dc21ec237d584590d72500652e7c909bf082758fb63064fca0ef`. If it
     isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
     this version of Go. If it matches, then proceed to install Go:
     ```
-    sudo tar -C /usr/local -xzf go1.16.linux-amd64.tar.gz
+    sudo tar -C /usr/local -xzf go1.17.1.linux-amd64.tar.gz
     export PATH=$PATH:/usr/local/go/bin
     ```
 
     (ARMv6)
     ```
-    wget https://dl.google.com/go/go1.16.linux-armv6l.tar.gz
-    sha256sum go1.16.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
+    wget https://dl.google.com/go/go1.17.1.linux-armv6l.tar.gz
+    sha256sum go1.17.1.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
     ```
 
     The final output of the command above should be
-    `d1d9404b1dbd77afa2bdc70934e10fbfcf7d785c372efc29462bb7d83d0a32fd`. If it
+    `ed3e4dbc9b80353f6482c441d65b51808290e94ff1d15d56da5f4a7be7353758`. If it
     isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
     this version of Go. If it matches, then proceed to install Go:
     ```
-    tar -C /usr/local -xzf go1.16.linux-armv6l.tar.gz
+    tar -C /usr/local -xzf go1.17.1.linux-armv6l.tar.gz
     export PATH=$PATH:/usr/local/go/bin
     ```
 
     On Mac OS X:
     ```
-    brew install go@1.16
+    brew install go@1.17.1
     ```
 
     On FreeBSD:

docs/release-notes/release-notes-0.14.0.md

@@ -198,6 +198,10 @@ you.
 
 * [Fix Travis itest parallelism](https://github.com/lightningnetwork/lnd/pull/5734)
 
+* [All CI, containers, and automated release artifact building now all use Go
+  1.17.1](https://github.com/lightningnetwork/lnd/pull/5650). All build tags have
+  been updated accordingly to comply with the new Go 1.17.1 requirements.
+
 ## Documentation
 
 * [Outdated warning about unsupported pruning was replaced with clarification that LND **does**

funding/manager_test.go

@@ -1,3 +1,4 @@
+//go:build !rpctest
 // +build !rpctest
 
 package funding

fuzz/brontide/fuzz_utils.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_actone.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_actthree.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_acttwo.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_init_decrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_init_enc_dec.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_init_encrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_resp_decrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_resp_enc_dec.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/random_resp_encrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_actone.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_actthree.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_acttwo.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_init_decrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_init_enc_dec.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_init_encrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_resp_decrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_resp_enc_dec.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/brontide/static_resp_encrypt.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package brontidefuzz

fuzz/lnwire/accept_channel.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/announce_signatures.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/channel_announcement.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/channel_reestablish.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/channel_update.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/closing_signed.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/commit_sig.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/error.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/funding_created.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/funding_locked.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/funding_signed.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/fuzz_utils.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/gossip_timestamp_range.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/init.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/node_announcement.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/open_channel.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/ping.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/pong.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/query_channel_range.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/query_short_chan_ids.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/query_short_chan_ids_zlib.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/reply_channel_range.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/reply_channel_range_zlib.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/reply_short_chan_ids_end.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/revoke_and_ack.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/shutdown.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/update_add_htlc.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/update_fail_htlc.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/update_fail_malformed_htlc.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/update_fee.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/lnwire/update_fulfill_htlc.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package lnwirefuzz

fuzz/wtwire/create_session.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package wtwirefuzz

fuzz/wtwire/create_session_reply.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package wtwirefuzz

fuzz/wtwire/delete_session.go

@@ -1,3 +1,4 @@
+//go:build gofuzz
 // +build gofuzz
 
 package wtwirefuzz