graph/db: pass reset to ForEachNodeCacheable

graph/db/graph.go

@@ -170,7 +170,7 @@ func (c *ChannelGraph) populateCache(ctx context.Context) error {
 		c.graphCache.AddNodeFeatures(node, features)
 
 		return nil
-	})
+	}, func() {})
 	if err != nil {
 		return err
 	}

graph/db/graph_test.go

@@ -1469,6 +1469,8 @@ func TestGraphTraversalCacheable(t *testing.T) {
 		nodes = append(nodes, node)
 
 		return nil
+	}, func() {
+		nodes = nil
 	})
 	require.NoError(t, err)
 	require.Len(t, nodeMap, 0)
@@ -4227,6 +4229,8 @@ func BenchmarkForEachChannel(b *testing.B) {
 			nodes = append(nodes, node)
 
 			return nil
+		}, func() {
+			nodes = nil
 		})
 		require.NoError(b, err)
 

graph/db/interfaces.go

@@ -110,7 +110,7 @@ type V1Store interface { //nolint:interfacebloat
 	// encountered. If the callback returns an error, then the transaction
 	// is aborted and the iteration stops early.
 	ForEachNodeCacheable(ctx context.Context, cb func(route.Vertex,
-		*lnwire.FeatureVector) error) error
+		*lnwire.FeatureVector) error, reset func()) error
 
 	// LookupAlias attempts to return the alias as advertised by the target
 	// node.

graph/db/kv_store.go

@@ -857,9 +857,8 @@ func forEachNode(db kvdb.Backend,
 // callback returns an error, then the transaction is aborted and the iteration
 // stops early.
 func (c *KVStore) ForEachNodeCacheable(_ context.Context,
-	cb func(route.Vertex, *lnwire.FeatureVector) error) error {
+	cb func(route.Vertex, *lnwire.FeatureVector) error,
-
+	reset func()) error {
-	reset := func() {}
 
 	traversal := func(tx kvdb.RTx) error {
 		// First grab the nodes bucket which stores the mapping from

graph/db/sql_store.go

@@ -924,9 +924,8 @@ func (s *SQLStore) ForEachNodeDirectedChannel(nodePub route.Vertex,
 //
 // NOTE: This is a part of the V1Store interface.
 func (s *SQLStore) ForEachNodeCacheable(ctx context.Context,
-	cb func(route.Vertex, *lnwire.FeatureVector) error) error {
+	cb func(route.Vertex, *lnwire.FeatureVector) error,
-
+	reset func()) error {
-	reset := func() {}
 
 	err := s.db.ExecTx(ctx, sqldb.ReadTxOpt(), func(db SQLQueries) error {
 		return forEachNodeCacheable(ctx, db, func(nodeID int64,