From 35c9eecf4ead7eff48614a36c242208e651c958a Mon Sep 17 00:00:00 2001 From: Slyghtning Date: Mon, 24 Mar 2025 16:54:05 +0100 Subject: [PATCH 1/2] routerrpc: add nil check for MilliSat --- lnrpc/routerrpc/router_server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lnrpc/routerrpc/router_server.go b/lnrpc/routerrpc/router_server.go index 818464be7..58fa23622 100644 --- a/lnrpc/routerrpc/router_server.go +++ b/lnrpc/routerrpc/router_server.go @@ -519,7 +519,7 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string, return nil, err } - if *payReq.MilliSat <= 0 { + if payReq.MilliSat == nil || *payReq.MilliSat <= 0 { return nil, errors.New("payment request amount must be " + "greater than 0") } From d38ad174782f1e378f423bca991a5c2eedf37f81 Mon Sep 17 00:00:00 2001 From: Slyghtning Date: Mon, 24 Mar 2025 16:57:42 +0100 Subject: [PATCH 2/2] docs: update release notes --- docs/release-notes/release-notes-0.19.0.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/release-notes/release-notes-0.19.0.md b/docs/release-notes/release-notes-0.19.0.md index e4ce83116..de6a2aae0 100644 --- a/docs/release-notes/release-notes-0.19.0.md +++ b/docs/release-notes/release-notes-0.19.0.md @@ -68,6 +68,10 @@ `estimateroutefee` to assume probing an LSP when given an invoice with a route hint containing a public channel to the destination. +* [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/9634) that caused + lnd to crash due to a nil pointer dereference when `estimateroutefee` is + called for a payment request that contains a zero amount. + * [Fix a bug](https://github.com/lightningnetwork/lnd/pull/9474) where LND would fail to persist (and hence, propagate) node announcements containing address types (such as a DNS hostname) unknown to LND.