From a35031ca2e9f8fad354adb1bb43ed6b41f00dbf7 Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Wed, 28 Jul 2021 10:58:41 +0200 Subject: [PATCH 1/2] healthcheck: fix missing import --- docs/release-notes/release-notes-0.14.0.md | 1 + healthcheck/diskcheck_js.go | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/release-notes/release-notes-0.14.0.md b/docs/release-notes/release-notes-0.14.0.md index a752b1758..92e55519f 100644 --- a/docs/release-notes/release-notes-0.14.0.md +++ b/docs/release-notes/release-notes-0.14.0.md @@ -59,6 +59,7 @@ you. * [Bumped version of `github.com/miekg/dns` library to fix a Dependabot alert](https://github.com/lightningnetwork/lnd/pull/5576). * [Fixed timeout flakes in async payment benchmark tests](https://github.com/lightningnetwork/lnd/pull/5579). +* [Fixed a missing import and git tag in the healthcheck package](https://github.com/lightningnetwork/lnd/pull/5582). ## Database diff --git a/healthcheck/diskcheck_js.go b/healthcheck/diskcheck_js.go index 4a2f4f57f..57106444b 100644 --- a/healthcheck/diskcheck_js.go +++ b/healthcheck/diskcheck_js.go @@ -1,13 +1,15 @@ package healthcheck +import "fmt" + // AvailableDiskSpaceRatio returns ratio of available disk space to total // capacity. -func AvailableDiskSpaceRatio(path string) (float64, error) { +func AvailableDiskSpaceRatio(_ string) (float64, error) { return 0, fmt.Errorf("disk space check not supported in WebAssembly") } // AvailableDiskSpace returns the available disk space in bytes of the given // file system. -func AvailableDiskSpace(path string) (uint64, error) { +func AvailableDiskSpace(_ string) (uint64, error) { return 0, fmt.Errorf("disk space check not supported in WebAssembly") } From 417effd223eae90b0110839041304581598cf05f Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Wed, 28 Jul 2021 10:58:47 +0200 Subject: [PATCH 2/2] mod: bump healthcheck to next version We bump the version of the healthcheck module to a version that does not exist. But by doing so we can tag the merge commit of this PR with that actual version and have everything working. That is faster than merging the changes to the module, pushing a tag, then bumping the tag in go.mod. --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 63ffd1991..392a55a78 100644 --- a/go.mod +++ b/go.mod @@ -42,7 +42,7 @@ require ( github.com/lightningnetwork/lightning-onion v1.0.2-0.20210520211913-522b799e65b1 github.com/lightningnetwork/lnd/cert v1.0.3 github.com/lightningnetwork/lnd/clock v1.0.1 - github.com/lightningnetwork/lnd/healthcheck v1.0.0 + github.com/lightningnetwork/lnd/healthcheck v1.0.2 github.com/lightningnetwork/lnd/kvdb v1.0.1 github.com/lightningnetwork/lnd/queue v1.0.4 github.com/lightningnetwork/lnd/ticker v1.0.0