Merge pull request #9565 from guggero/bot-typo-fix-spam
GitHub+docs: no longer accept typo fixes to fight PR spam
This commit is contained in:
2 files changed
+17
-2
No files matched your search
@@ -11,8 +11,9 @@ Steps for reviewers to follow to test the change.
|
|||||||
- [ ] Bug fixes contain tests triggering the bug to prevent regressions.
|
- [ ] Bug fixes contain tests triggering the bug to prevent regressions.
|
||||||
|
|
||||||
### Code Style and Documentation
|
### Code Style and Documentation
|
||||||
- [ ] The change obeys the [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation) guidelines, and lines wrap at 80.
|
- [ ] The change is not [insubstantial](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#substantial-contributions-only). Typo fixes are not accepted to fight bot spam.
|
||||||
- [ ] Commits follow the [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#IdealGitCommitStructure).
|
- [ ] The change obeys the [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#code-documentation-and-commenting) guidelines, and lines wrap at 80.
|
||||||
|
- [ ] Commits follow the [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#ideal-git-commit-structure).
|
||||||
- [ ] Any new logging statements use an appropriate subsystem and logging level.
|
- [ ] Any new logging statements use an appropriate subsystem and logging level.
|
||||||
- [ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
|
- [ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
|
||||||
- [ ] [There is a change description in the release notes](https://github.com/lightningnetwork/lnd/tree/master/docs/release-notes), or `[skip ci]` in the commit message for small changes.
|
- [ ] [There is a change description in the release notes](https://github.com/lightningnetwork/lnd/tree/master/docs/release-notes), or `[skip ci]` in the commit message for small changes.
|
||||||
|
|||||||
@@ -98,6 +98,20 @@ Once the specification is finalized, it will be the most up-to-date
|
|||||||
comprehensive document explaining the Lightning Network. As a result, it will
|
comprehensive document explaining the Lightning Network. As a result, it will
|
||||||
be recommended for newcomers to read first in order to get up to speed.
|
be recommended for newcomers to read first in order to get up to speed.
|
||||||
|
|
||||||
|
# Substantial contributions only
|
||||||
|
|
||||||
|
Due to the prevalence of automated analysis and pull request authoring tools
|
||||||
|
and online competitions that incentivize creating commits in popular
|
||||||
|
repositories, the maintainers of this project are flooded with trivial pull
|
||||||
|
requests that only change some typos or other insubstantial content (e.g. the
|
||||||
|
year in the license file).
|
||||||
|
If you are an honest user that wants to contribute to this project, please
|
||||||
|
consider that every pull request takes precious time from the maintainers to
|
||||||
|
review and consider the impact of changes. Time that could be spent writing
|
||||||
|
features or fixing bugs.
|
||||||
|
If you really want to contribute, consider reviewing and testing other users'
|
||||||
|
pull requests instead. Or add value to the project by writing unit tests.
|
||||||
|
|
||||||
# Development Practices
|
# Development Practices
|
||||||
|
|
||||||
Developers are expected to work in their own trees and submit pull requests when
|
Developers are expected to work in their own trees and submit pull requests when
|
||||||
|
|||||||
Reference in new issue
Block a user