20399 Commits
Author SHA1 Message Date
Oliver Gugger baa3b0dea3 Merge pull request #9425 from yyforyongyu/flake-fix
itest: fix flake in `testSweepHTLCs`
2025-01-17 10:36:55 -06:00
Oliver Gugger 27df4af53e Merge pull request #9359 from NishantBansal2003/fix-timeout
routerrpc: add a default value for timeout_seconds in SendPaymentV2
2025-01-17 09:43:38 -06:00
yyforyongyu c24f839fbe itest: fix flake in testSweepHTLCs
We need to make sure Caarol finishes settling her invoice with Bob
before shutting down, so we make sure `AssertHTLCNotActive` on Bob
happens before shutting node Carol.
2025-01-17 22:58:37 +08:00
Yong fb91b04906 Merge pull request #9405 from yyforyongyu/fix-unused-params
discovery+lnd: make param `ProofMatureDelta` configurable
2025-01-17 22:57:26 +08:00
yyforyongyu ae2bcfe3d8 docs: add release notes 2025-01-17 21:44:23 +08:00
yyforyongyu 27a05694cb multi: make ProofMatureDelta configurable
We add a new config option to set the `ProofMatureDelta` so the users
can tune their graphs based on their own preference over the num of
confs found in the announcement signatures.
2025-01-17 21:44:23 +08:00
yyforyongyu 56ff6d1fe0 docs: update release notes 2025-01-17 18:58:20 +08:00
yyforyongyu 772a9d5f42 discovery: fix mocked peer in unit tests
The mocked peer used here blocks on `sendToPeer`, which is not the
behavior of the `SendMessageLazy` of `lnpeer.Peer`. To reflect the
reality, we now make sure the `sendToPeer` is non-blocking in the tests.
2025-01-17 17:59:06 +08:00
yyforyongyu 9fecfed3b5 discovery: fix race access to syncer's state
This commit fixes the following race,
1. syncer(state=syncingChans) sends QueryChannelRange
2. remote peer replies ReplyChannelRange
3. ProcessQueryMsg fails to process the remote peer's msg as its state
   is neither waitingQueryChanReply nor waitingQueryRangeReply.
4. syncer marks its new state waitingQueryChanReply, but too late.

The historical sync will now fail, and the syncer will be stuck at this
state. What's worse is it cannot forward channel announcements to other
connected peers now as it will skip the broadcasting during initial
graph sync.

This is now fixed to make sure the following two steps are atomic,
1. syncer(state=syncingChans) sends QueryChannelRange
2. syncer marks its new state waitingQueryChanReply.
2025-01-17 02:39:07 +08:00
yyforyongyu 4b30b09d1c discovery: add new method handleSyncingChans
This is a pure refactor to add a dedicated handler when the gossiper is
in state syncingChans.
2025-01-17 00:22:22 +08:00
yyforyongyu eb2b0c783f graph: fix staticcheck suggestion
From staticcheck: QF1002 - Convert untagged switch to tagged switch.
2025-01-17 00:21:45 +08:00
yyforyongyu 001e5599b6 multi: add debug logs for edge policy flow
This commit adds more logs around the ChannelUpdate->edge policy process
flow.
2025-01-17 00:17:23 +08:00
Yong e0a920af44 Merge pull request #9420 from yyforyongyu/assert-channel-graph
itest+lntest: make sure to assert edge in both graph db and cache
2025-01-17 00:13:02 +08:00
yyforyongyu faa1f67480 lntest: assert channel edge in both graph db and cache
We need to make sure the channel edge has been updated in both the graph
DB and cache.
2025-01-16 23:00:22 +08:00
yyforyongyu e576d661ef itest: fix docs 2025-01-16 23:00:21 +08:00
yyforyongyu 848f42ea1d itest: fix flake in graph_topology_notifications
We need to make sure to wait for the `ListPeers` to give us the latest
response.
2025-01-16 16:19:37 +08:00
Nishant Bansal 3a3002e281 docs: add release notes.
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 19:46:09 +05:30
Nishant Bansal 23efbef946 itest: update tests with timeout_seconds
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 19:46:09 +05:30
Nishant Bansal b577ad4661 routerrpc: default timeout_seconds to 60 in SendPaymentV2
If timeout_seconds is not set or is 0, the default value
of 60 seconds will be used.

Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 19:45:44 +05:30
Oliver Gugger 572784a6a1 Merge pull request #9390 from NishantBansal2003/append-channel
Enhance `lncli` listchannels command with the chan_id and short_chan_id (human readable format)
2025-01-15 07:19:27 -06:00
Nishant Bansal c2897a4c78 docs: add release notes.
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 17:58:40 +05:30
Nishant Bansal 103a194e5c cmd/lncli: update listchannels output fields
Added scid_str as a string representation of chan_id,
replacing chan_id with scid, and including chan_id(BOLT02)
in lncli listchannels output.

Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 17:58:06 +05:30
Nishant Bansal 7f8e89f3b4 lnwire: add 'x' separator in ShortChannelID method
Add the `AltString` method for `ShortChannelID` to produce a
human-readable format with 'x' as a separator
(block x transaction x output).

Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
2025-01-15 15:25:40 +05:30
Yong 4b16c2902e Merge pull request #9383 from ziggie1984/bugfix-createmissingedge
bugfix createmissingedge
2025-01-14 16:20:15 +08:00
ziggie e008190a85 localchans: bugfix so that we always use the correct chanID 2025-01-14 08:14:02 +01:00
Elle e9dd01b60d Merge pull request #9274 from ziggie1984/remove-2x-value
The sweeper subsystem uses now also the configured budget values for HTLCs
2025-01-13 19:09:11 +02:00
Oliver Gugger b958667811 Merge pull request #9355 from Roasbeef/rapid-fuzz-htlc-blobs
contractcourt: add rapid derived fuzz test for HtlcAuxBlob
2025-01-13 10:35:53 -06:00
Oliver Gugger 1b0f41da48 Merge pull request #9378 from yyforyongyu/fix-unit-test
chainntnfs: fix test `testSingleConfirmationNotification`
2025-01-13 03:13:02 -06:00
Oliver Gugger 67a8c7cf51 Merge pull request #9391 from mohamedawnallah/choreRegisterToRegisteredInStartingDebugLogs
chore: change 'register' to 'registered' in lnrpc starting debug logs [skip ci]
2025-01-13 03:11:03 -06:00
Elle 98033f876d Merge pull request #9344 from ellemouton/useUpdatedContextGuard
htlcswitch+go.mod: use updated fn.ContextGuard
2025-01-11 12:28:45 +02:00
Elle Mouton 950194a2da htlcswitch+go.mod: use updated fn.ContextGuard
This commit updates the fn dep to the version containing the updates to
the ContextGuard implementation. Only the htlcswitch/link uses the guard
at the moment so this is updated to make use of the new implementation.
2025-01-11 06:17:43 +02:00
Elle 77848c402d Merge pull request #9342 from ellemouton/slogProtofsm
protofsm: update GR Manager usage and start using structured logging
2025-01-10 19:55:18 +02:00
Elle Mouton 42ce9d639f docs: add release notes entry 2025-01-10 18:34:26 +02:00
Elle Mouton 65c4c2c4d0 protofsm: use pointer to GoroutineManager 2025-01-10 18:25:19 +02:00
Elle Mouton dfddeec8d4 protofsm: use structured logging 2025-01-10 18:25:19 +02:00
Elle Mouton 575ea7af83 protofsm: use prefixed logger for StateMachine
So that we dont have to remember to add the `FSM(%v)` prefix each time
we write a log line.
2025-01-10 18:25:19 +02:00
Elle Mouton b887c1cc5d protofsm: use updated GoroutineManager API
Update to use the latest version of the GoroutineManager which takes a
context via the `Go` method instead of the constructor.
2025-01-10 18:23:28 +02:00
Elle Mouton 4e0498faa4 go.mod: update btclog dep
This bump includes a fix which prevents attribute value quoting if the
value string contains a newline character. This is so that if we call
spew.DumpS(), the output will stay nicely formatted.

The update also includes a couple more Hex helpers which we can make use
of now.
2025-01-10 18:23:28 +02:00
Oliver Gugger dd25e6eb22 Merge pull request #9361 from starius/optimize-context-guard
fn: optimize context guard
2025-01-10 09:33:21 -06:00
Oliver Gugger 70e7b56713 Merge pull request #9388 from chloefeal/fix
Fix some typos
2025-01-10 09:30:50 -06:00
Oliver Gugger e449adb03a Merge pull request #9404 from peicuiping/master
chore: fix some typos
2025-01-10 09:28:37 -06:00
Oliver Gugger 83a2100810 Merge pull request #9386 from ellemouton/updateElleKey
scripts/keys: update pub key for ellemouton
2025-01-10 09:25:37 -06:00
Oliver Gugger 1d9b30f139 Merge pull request #9411 from ellemouton/bumpUploadArtifactAction
.github: bump upload-artifact action to v4
2025-01-10 09:17:31 -06:00
Elle Mouton a7a01f684d .github: bump upload-artifact action to v4 2025-01-10 08:31:57 +02:00
ziggie f36f7c1d84 docs: add release-notes 2025-01-09 07:56:40 +01:00
ziggie 5cd88f7e48 contractcourt: remove 2xamount requirement for the sweeper. 2025-01-08 08:57:50 +01:00
chloefeal 852a8d8746 chore: fix typo 2025-01-05 20:45:35 +08:00
peicuiping 06fef749a7 chore: fix some typos
Signed-off-by: peicuiping <ezc5@sina.cn>
2025-01-03 21:48:29 +08:00
Boris Nagaev 07c46680e9 fn/ContextGuard: use context.AfterFunc to wait
Simplifies context cancellation handling by using context.AfterFunc instead of a
goroutine to wait for context cancellation. This approach avoids the overhead of
a goroutine during the waiting period.

For ctxQuitUnsafe, since g.quit is closed only in the Quit method (which also
cancels all associated contexts), waiting on context cancellation ensures the
same behavior without unnecessary dependency on g.quit.

Added a test to ensure that the Create method does not launch any goroutines.
2025-01-02 10:38:26 -03:00
Boris Nagaev e9ab603735 fn/ContextGuard: clear store of cancel funcs
If ContextGuard lives for some time after Quit method is called, the map won't
be collected by GC. Optimization.
2025-01-02 10:38:26 -03:00