mirror/lnd
1
0 Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
19,310 Commits 1 Branch 0 Tags
e72e414091ddb1c1d0ccdcee0e527541d7700a71
Commit Graph
65 Commits
Author SHA1 Message Date
yyforyongyu 45029d9b6c docs: add development_guidelines.md 
This file focuses on the requirements and steps needed to make an
acceptable PR.
 2025-04-14 17:08:56 +08:00
Oliver Gugger d0032b1251 README+docs: add code review checklist 
We want to encourage new contributors to review code instead of creating
their own PRs as a first contribution.
 2025-03-28 09:53:15 -05:00
Oliver Gugger a78f9f6c0a GitHub+docs: no longer accept typo fixes to fight PR spam 2025-02-28 13:02:49 +01:00
chloefeal 852a8d8746 chore: fix typo 2025-01-05 20:45:35 +08:00
Gijs van Dam 42a1d5e22b docs: clarify skipping the CI checks 
[skip ci]
 2024-12-03 18:16:13 +01:00
Leonhard Weese e494d7401a Fix links to resolve issue in Builder's Guide (https and redirect) 
There are some links in this document that cause issues for pull request [#670](https://github.com/lightninglabs/docs.lightning.engineering/pull/670) in the Builder's Guide Repo.
 2024-09-18 03:18:45 +08:00
Marcia Waite e6dca0ce6e multi: Fix typos and grammar in multiple docs 2024-07-22 20:08:12 -07:00
João Thallis 805c1c0d59 docs: fix contribution guide links [skip ci] 2024-02-17 21:48:01 -03:00
Afanti c0ef879b8c fix: rectify the typos in the docs 2023-12-20 08:21:57 +08:00
yyforyongyu 0bc86a3b4b multi: move itest out of lntest 
This commit moves all the test cases living in `itest` out of `lntest`,
further making `lntest` an independent package for general testing.
 2023-02-23 21:56:08 +08:00
habibitcoin 0b1e881d18 scripted-diff: replace ⛰ emoji with $ [skip ci] 
-BEGIN VERIFY SCRIPT-
sed -i 's/⛰/$/g' $(git grep -l '⛰')
-END VERIFY SCRIPT-
 2022-10-28 12:06:49 -04:00
Oliver Gugger f268786a87 docs: extract formatting rules 2022-07-06 13:33:02 +02:00
Oliver Gugger bdda2aa059 docs+github+scripts: remove submodule update check 
Because we want to avoid local replace directives (as they make it easy
to screw up things for external applications that use lnd as a library
without us noticing), we're going to switch over to a new process.
See section "Use of Golang submodules" in the code contribution
guideline.
 2022-03-22 14:17:26 +01:00
Oliver Gugger 04bbbea9a7 Merge pull request #6228 from guggero/contribution-guidelines 
docs: rewrite and regroup formatting rules [skip ci]
 2022-02-03 10:02:02 +01:00
Neil-LL b398d64393 Tiny Formatting Change 2022-02-02 16:14:42 +02:00
Oliver Gugger b667f7a89c docs: rewrite and regroup formatting rules [skip ci] 2022-02-02 15:11:43 +01:00
Oliver Gugger 3c324ad058 docs: remove protobuf compilation section from guidelines 
Since we're now enforcing the formatting of the protobuf files through a
CI step, this explicit mention in the docs is no longer needed.
 2022-02-02 15:10:24 +01:00
positiveblue d2143bd40f docs: add guidelines for func declarations [skip ci] 2022-02-01 08:31:19 -08:00
carla 0f8d314ee7 github: simplify PR template and add more sections [skip ci] 2022-01-28 09:50:02 +02:00
Dimitris Apostolou 530a2059e5 multi: Fix typos [skip ci] 2022-01-24 12:19:02 +02:00
3nprob 258c1987e8 docs: Fix broken link to lnd_test.go 2022-01-11 14:08:19 +01:00
Naveen 4de2ec1264 docs: sign your git commits [skip-ci] 
https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2014-May/005877.html
 2022-01-11 14:08:18 +01:00
Elle Mouton b829be133a docs: add review bot commands to guidelines [skip ci] 
Add the review bot commands to the contribution guidelines so that we
can link to these commands from the bots readme.
 2021-12-15 10:36:36 +02:00
Olaoluwa Osuntokun 26169e8e16 Merge pull request #5627 from Zero-1729/patch-3 
trivial: minor grammar and typo fix [skip ci]
 2021-08-30 19:23:43 -07:00
yyforyongyu 81df01acca docs: explicitly set line wrap rules for error messages [skip ci] 2021-08-16 11:48:33 +08:00
Abubakar Nur Khalil e70349644b trivial: minor grammar and typo fix [skip ci] 2021-08-13 03:36:40 +01:00
Oliver Gugger 07fa98fca5 Merge pull request #5614 from yyforyongyu/skip-release-note 
trivial: skip release note for trivial fixes
 2021-08-11 11:50:15 +02:00
Olaoluwa Osuntokun 85e3dd3e45 docs: add release notes to PR checklist and contributor guidelines 2021-08-10 15:56:17 -07:00
yyforyongyu b64f413718 trivial: skip release note for trivial fixes [skip ci] 2021-08-11 00:17:10 +08:00
Oliver Gugger dd749fe580 lnrpc: update grpc-gateway library to v2 2021-07-27 13:09:59 +02:00
Zero-1729 712643e2aa docs: minor fixes to contribution guidelines 2021-07-20 14:58:45 +01:00
Oliver Gugger 9642012643 docs: clean up code contribution guideline syntax 2021-01-22 09:14:12 +01:00
Oliver Gugger 2c634bfaf3 docs: unify code and shell cmd blocks 2021-01-22 09:14:09 +01:00
Joost Jager d1e049fa68 docs: describe log levels 2020-06-12 11:22:35 +02:00
Oliver Gugger ce4591437b docs: link to lnrpc README, remove json_name 2020-05-08 14:34:03 +02:00
Sebastian Falbesoner 11638845e4 docs: fix tab size (8 spaces) in contribution guidelines 2020-05-01 20:25:53 +02:00
Vignesh Karthikeyan 2520d0a996 Fix Formatting of *Wrong* 
There is a spacing issues, and thus a formatting 
issue, in the file, code_contribution_guidelines.md
 2019-10-19 16:48:32 +05:30
Wilmer Paulino 73791e15a1 Merge pull request #2830 from philippgille/feature/update-contribution-checklist 
docs: update contribution checklist
 2019-04-05 15:46:34 -07:00
Philipp Gille dd3f48eda5 docs: update contribution checklist 
- Update Go version 1.11 to 1.12
- Fix broken link in GitHub PR template
- Fix inconsistent number of spaces after checkbox
- Add proper link to "Ideal Git Commit structure"
 2019-03-24 11:37:57 +01:00
Philipp Gillé 8b568296df docs: fix typo 2019-03-23 17:03:40 +01:00
Olaoluwa Osuntokun 9cda05ee8a docs: add new section to contribution guidelines for go mod replace 
In this commit, we add a new section to the code contribution guidelines
explaining how to use `go mod replace`. This will be a common procedure
for any developer that needs to make a change in any of our sister
projects, so it's nice to have this outlined in a single place.
 2019-01-17 16:50:06 -08:00
Olaoluwa Osuntokun af306e2360 docs: expand contributor checklist w/ commit structure 2018-12-19 17:02:25 -08:00
Olaoluwa Osuntokun 49da4a60aa docs: update contribution guidelines with new merge commit policy 2018-12-18 20:59:58 -08:00
Olaoluwa Osuntokun a76affae91 docs: replace golint with make lint in contributor guidelines 2018-12-18 20:59:56 -08:00
Olaoluwa Osuntokun 0d5eef4f30 docs: in contributor guidelines, use make check not go test 2018-12-18 20:59:54 -08:00
Olaoluwa Osuntokun ce39910f96 docs: add section in contribution guidelines describing fixup commits 2018-12-18 20:59:53 -08:00
Olaoluwa Osuntokun d1571badaf docs: add section in contribution guidelines for unique lnd code style 2018-12-18 20:59:52 -08:00
Olaoluwa Osuntokun 0dc9b35a1a docs: add section in testing pointing towards Makefile docs 2018-12-18 20:59:51 -08:00
Olaoluwa Osuntokun 516a48741f docs: update contribution guidelines to add section on commit structure 2018-12-18 20:59:46 -08:00
Olaoluwa Osuntokun e6c22d658d docs: update contribution guidelines to reference latest version of Go 
with '#' will be ignored, and an empty message aborts the commit.
 2018-11-28 20:13:50 -08:00