Elle Mouton
ba6222b521
This makes it clear what fields must/can be set for a V1 channel. Introduce NewV1Channel constructor to create v1 channel edges with proper initialization and validation. The constructor: - Takes required fields (chanID, chainHash, node keys) as parameters - Takes v1-specific fields (bitcoin keys, extra opaque data) via ChannelV1Fields struct - Accepts optional fields (capacity, channel point, features, proof) via functional options (WithCapacity, WithChannelPoint, etc.) - Validates that if an AuthProof is provided, its version matches the channel version This makes it clear which fields are required vs optional for v1 channels and prevents incorrectly initialized channel edges. All tests and production code updated to use the constructor.
115 lines
3.2 KiB
Go
115 lines
3.2 KiB
Go
package graphdb
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/btcsuite/btcd/chaincfg/chainhash"
|
|
"github.com/lightningnetwork/lnd/graph/db/models"
|
|
"github.com/lightningnetwork/lnd/routing/route"
|
|
)
|
|
|
|
// TestChannelCache checks the behavior of the channelCache with respect to
|
|
// insertion, eviction, and removal of cache entries.
|
|
func TestChannelCache(t *testing.T) {
|
|
const cacheSize = 100
|
|
|
|
// Create a new channel cache with the configured max size.
|
|
c := newChannelCache(cacheSize)
|
|
|
|
// As a sanity check, assert that querying the empty cache does not
|
|
// return an entry.
|
|
_, ok := c.get(0)
|
|
if ok {
|
|
t.Fatalf("channel cache should be empty")
|
|
}
|
|
|
|
// Now, fill up the cache entirely.
|
|
for i := uint64(0); i < cacheSize; i++ {
|
|
c.insert(i, channelForInt(i))
|
|
}
|
|
|
|
// Assert that the cache has all of the entries just inserted, since no
|
|
// eviction should occur until we try to surpass the max size.
|
|
assertHasChanEntries(t, c, 0, cacheSize)
|
|
|
|
// Now, insert a new element that causes the cache to evict an element.
|
|
c.insert(cacheSize, channelForInt(cacheSize))
|
|
|
|
// Assert that the cache has this last entry, as the cache should evict
|
|
// some prior element and not the newly inserted one.
|
|
assertHasChanEntries(t, c, cacheSize, cacheSize)
|
|
|
|
// Iterate over all inserted elements and construct a set of the evicted
|
|
// elements.
|
|
evicted := make(map[uint64]struct{})
|
|
for i := uint64(0); i < cacheSize+1; i++ {
|
|
_, ok := c.get(i)
|
|
if !ok {
|
|
evicted[i] = struct{}{}
|
|
}
|
|
}
|
|
|
|
// Assert that exactly one element has been evicted.
|
|
numEvicted := len(evicted)
|
|
if numEvicted != 1 {
|
|
t.Fatalf("expected one evicted entry, got: %d", numEvicted)
|
|
}
|
|
|
|
// Remove the highest item which initially caused the eviction and
|
|
// reinsert the element that was evicted prior.
|
|
c.remove(cacheSize)
|
|
for i := range evicted {
|
|
c.insert(i, channelForInt(i))
|
|
}
|
|
|
|
// Since the removal created an extra slot, the last insertion should
|
|
// not have caused an eviction and the entries for all channels in the
|
|
// original set that filled the cache should be present.
|
|
assertHasChanEntries(t, c, 0, cacheSize)
|
|
|
|
// Finally, reinsert the existing set back into the cache and test that
|
|
// the cache still has all the entries. If the randomized eviction were
|
|
// happening on inserts for existing cache items, we expect this to fail
|
|
// with high probability.
|
|
for i := uint64(0); i < cacheSize; i++ {
|
|
c.insert(i, channelForInt(i))
|
|
}
|
|
assertHasChanEntries(t, c, 0, cacheSize)
|
|
|
|
}
|
|
|
|
// assertHasEntries queries the edge cache for all channels in the range [start,
|
|
// end), asserting that they exist and their value matches the entry produced by
|
|
// entryForInt.
|
|
func assertHasChanEntries(t *testing.T, c *channelCache, start, end uint64) {
|
|
t.Helper()
|
|
|
|
for i := start; i < end; i++ {
|
|
entry, ok := c.get(i)
|
|
if !ok {
|
|
t.Fatalf("channel cache should contain chan %d", i)
|
|
}
|
|
|
|
expEntry := channelForInt(i)
|
|
if !reflect.DeepEqual(entry, expEntry) {
|
|
t.Fatalf("entry mismatch, want: %v, got: %v",
|
|
expEntry, entry)
|
|
}
|
|
}
|
|
}
|
|
|
|
// channelForInt generates a unique ChannelEdge given an integer.
|
|
func channelForInt(i uint64) ChannelEdge {
|
|
info, err := models.NewV1Channel(
|
|
i, chainhash.Hash{}, route.Vertex{}, route.Vertex{},
|
|
&models.ChannelV1Fields{},
|
|
)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return ChannelEdge{
|
|
Info: info,
|
|
}
|
|
}
|