util: Document why ArgsManager (con/de)structor is not inline

This commit is contained in:
MarcoFalke committed 2020-04-16 12:26:09 -04:00
1 parent fae00a77e2
commit faf989f936
3 files changed
+7 -5

No files matched your search

+1 -1
View File
@@ -9,7 +9,7 @@
#include <string>
#include <vector>
#include <univalue.h> // For util::SettingsValue = UniValue
class UniValue;
namespace util {
+5 -4
View File
@@ -226,10 +226,11 @@ static bool CheckValid(const std::string& key, const util::SettingsValue& val, u
return true;
}
ArgsManager::ArgsManager()
{
// nothing to do
}
// Define default constructor and destructor that are not inline, so code instantiating this class doesn't need to
// #include class definitions for all members.
// For example, m_settings has an internal dependency on univalue.
ArgsManager::ArgsManager() {}
ArgsManager::~ArgsManager() {}
const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const
{
+1
View File
@@ -192,6 +192,7 @@ protected:
public:
ArgsManager();
~ArgsManager();
/**
* Select the network in use