mirror/ioccc
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #278 from xexyl/bugs

Browse Source 
Fix to bugs.md for 1986/hague
This commit is contained in:
Landon Curt Noll authored and GitHub committed 2023-04-04 11:29:21 -07:00
2 parents c8298d9aaa 7832ef5e46
commit ea65c4cff3
1 file changed
+8 -3
Download Patch File Download Diff File Expand all files Collapse all files
bugs.md
+8 -3
View File
@@ -298,10 +298,15 @@ the judges and shouldn't be fixed.
## [1986/hague](1986/hague/hague.c) ([README.md](1986/hague/README.md)) ## [1986/hague](1986/hague/hague.c) ([README.md](1986/hague/README.md))
## STATUS: uses gets() - change to fgets() if possible ## STATUS: uses gets() - change to fgets() if possible
This entry uses `gets()` which is unsafe. In particular the buffer size is 81. This entry uses `gets()` which is unsafe. In particular the buffer size is a
`gets()` does not store the `'\n'` but it does store the `'\0'`. mere 81 and it does not read a single string at command invocation but instead
until the program is terminated. This size can be increased to start out but it
would be better if it used `fgets()`. This will be addressed in time but is
noted here as a reminder.
The way this entry is formed has made it not as simple as some of the others
that have been addressed.
The latter fact
## [1986/holloway](1986/holloway/holloway.c) ([README.md](1986/holloway/README.md)) ## [1986/holloway](1986/holloway/holloway.c) ([README.md](1986/holloway/README.md))
## STATUS: INABIAF - please **DO NOT** fix ## STATUS: INABIAF - please **DO NOT** fix