bitcoindnotify: fix subtest closure in unit tests

This commit is contained in:
yyforyongyu committed 2023-01-19 21:06:23 +08:00
1 parent 48c8c1bf48
commit 1f67d6a548
3 files changed
+30 -6

No files matched your search

+18 -4
View File
@@ -105,8 +105,15 @@ func syncNotifierWithMiner(t *testing.T, notifier *BitcoindNotifier,
// TestHistoricalConfDetailsTxIndex ensures that we correctly retrieve
// historical confirmation details using the backend node's txindex.
func TestHistoricalConfDetailsTxIndex(t *testing.T) {
testHistoricalConfDetailsTxIndex(t, true)
testHistoricalConfDetailsTxIndex(t, false)
t.Run("txindex enabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsTxIndex(st, true)
})
t.Run("txindex disabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsTxIndex(st, false)
})
}
func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) {
@@ -193,8 +200,15 @@ func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) {
// historical confirmation details using the set of fallback methods when the
// backend node's txindex is disabled.
func TestHistoricalConfDetailsNoTxIndex(t *testing.T) {
testHistoricalConfDetailsNoTxIndex(t, true)
testHistoricalConfDetailsNoTxIndex(t, false)
t.Run("txindex enabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, true)
})
t.Run("txindex disabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, false)
})
}
func testHistoricalConfDetailsNoTxIndex(t *testing.T, rpcpolling bool) {
+9 -2
View File
@@ -12,6 +12,13 @@ import (
// TestInterfaces executes the generic notifier test suite against a bitcoind
// powered chain notifier.
func TestInterfaces(t *testing.T) {
chainntnfstest.TestInterfaces(t, "bitcoind")
chainntnfstest.TestInterfaces(t, "bitcoind-rpc-polling")
t.Run("bitcoind", func(st *testing.T) {
st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind")
})
t.Run("bitcoind rpc polling", func(st *testing.T) {
st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind-rpc-polling")
})
}
@@ -300,6 +300,9 @@ data.
* Payment related code [has been
refactored](https://github.com/lightningnetwork/lnd/pull/7174) to allow the
usage of new payment statuses.
* [Fixed a test closure](https://github.com/lightningnetwork/lnd/pull/7337)
issue found in `bitcoindnotify/bitcoind_test.go`.
## Watchtowers