Commit Graph
100 Commits
Author SHA1 Message Date
Oliver Gugger 5bf9b710fc config_builder+rpcwallet: add full net params
As a preparation for parsing addresses, we need the full network
parameters and not just the coin type in the RPC wallet.
2022-03-24 14:13:05 +01:00
Oliver Gugger efa36ce8f2 lntest+lnwallet: add AddressInfo to WalletController
We need to be able to query the watch-only wallet about a public key
when trying to sign with a key that we don't know the family or index
of. The easiest way to do that is to leverage the wallet's address index
to query the derivation path for a public key.
To give the RPC wallet access to that functionality, we need to expose
the method on the WalletController interface.
2022-03-24 14:13:05 +01:00
Oliver Gugger e86a0ba197 itest: add new test for SignOutputRaw RPC 2022-03-24 14:13:04 +01:00
Oliver Gugger 1670000fd8 walletrpc: add debug log statement for invalid PSBT
To help debug remote signing issues, it's helpful to get the raw PSBT
that failed to be parsed. This is necessary since serializing an invalid
PSBT is allowed and the checks only fail when trying to de-serialize
such an invalid packet.
2022-03-24 09:28:27 +01:00
Oliver Gugger c0a282bc4a Merge pull request #6353 from bhandras/interceptor-race-fix
switch+test: fix race condition in the interceptor unit test
2022-03-23 18:16:13 +01:00
Oliver Gugger ba99d22f3c docs: update release notes 2022-03-23 17:46:58 +01:00
Oliver Gugger 1dc2a394e6 lnd: disable REST proxy HTTP method fallback
It turns out that when a REST call to an endpoint (in this specific
example /v1/payments, which for GET returns all payments but for DELETE
removes all payments) is made with POST instead of the correct
registered method, the grpc-gateway tried to find a fallback method.
That resulted in randomly choosing between any of the calls with the
same URI pattern.
This is of course catasrophic if the user attempts to query the list of
payments (but using POST instead of GET by accident) and then ending up
calling the DELETE endpoint instead.
2022-03-23 17:40:35 +01:00
Oliver Gugger 802544b62a Merge pull request #5476 from LN-Zap/upstream/feat/dest-outputs
lnrpc: Add destination output information (pkScript, output index, amount and if output belongs to the node)
2022-03-23 12:51:04 +01:00
Oliver Gugger 929a5654ee Merge pull request #6356 from guggero/remove-healthcheck-replace
go module cleanup [3/3]: remove local replace for healthcheck module
2022-03-22 16:34:34 +01:00
Oliver Gugger 58a47845c1 docs: update release notes 2022-03-22 14:48:43 +01:00
Oliver Gugger 9ecc439266 mod: remove local replace for healthcheck module
With the new healthcheck/v1.2.2 tag pushed, we can finally remove the
local replace directive.
2022-03-22 14:46:19 +01:00
Oliver Gugger db4831ab69 Merge pull request #6355 from guggero/remove-tags
go module cleanup [2/3]: remove local replace for `tor` package
2022-03-22 14:41:56 +01:00
Oliver Gugger bdda2aa059 docs+github+scripts: remove submodule update check
Because we want to avoid local replace directives (as they make it easy
to screw up things for external applications that use lnd as a library
without us noticing), we're going to switch over to a new process.
See section "Use of Golang submodules" in the code contribution
guideline.
2022-03-22 14:17:26 +01:00
Oliver Gugger 2b34c1e7ed mod+healthcheck: remove local replace directive 2022-03-22 14:06:05 +01:00
Oliver Gugger a14f1208d7 Merge pull request #6350 from guggero/tor-gomodule
mod: turn tor into its own submodule
2022-03-22 14:01:45 +01:00
Oliver Gugger e8528b060a build: bump version of master branch to v0.14.99-beta 2022-03-21 20:41:42 +01:00
Oliver Gugger 3ee8d25a29 docs: add release notes 2022-03-21 20:41:41 +01:00
Oliver Gugger 5116cfc255 mod: bump aez library that points to GitLab
The newest version of aez points directly to
gitlab.com/yawning/bsaes.git instead of the unreachable
git.schwanenlied.me/yawning/bsaes.git that required the replace
directive.
2022-03-21 20:41:40 +01:00
Oliver Gugger 973c95369f mod: remove local replaces 2022-03-21 20:41:38 +01:00
Oliver Gugger 1b48681bba mod: remove replace for github.com/onsi/ginkgo
With the recent PR #6285 merged that bumped the btcd dependency, we no
longer need to bump the github.com/onsi/ginkgo package with a replace
directive. Instead it was bumped indirectly by merging
https://github.com/btcsuite/btcd/pull/1780 which is included in the btcd
version we reference.
2022-03-21 20:41:37 +01:00
Oliver Gugger fddcb6669c mod: remove replace for go.mongodb.org/mongo-driver
With the dependency to lnd@v0.14.2-beta removed, we no longer depend on
the mongo-driver indirectly so we can remove the security related
replace directive.
2022-03-21 20:41:36 +01:00
Oliver Gugger fa919781e2 mod+healthcheck: use new tor submodule
Using the tor module instead of whole lnd in healthcheck allows us to
get rid of a lot of indirect dependencies.
2022-03-21 20:41:34 +01:00
Oliver Gugger c5f3110616 tor: make tor its own submodule 2022-03-21 20:41:33 +01:00
Oliver Gugger 57840bba36 Merge pull request #6232 from bottlepay/require-interceptor
htlcswitch: add an always on mode to htlc interceptor
2022-03-19 10:47:22 +01:00
Oliver Gugger d287884ff4 Merge pull request #6332 from bhandras/invoice_registry_deadlock
invoices: fix deadlock in invoice registry
2022-03-17 15:55:08 +01:00
Oliver Gugger 6c80a30da2 Merge pull request #6278 from Crypt-iQ/network_ann_refactor
discovery: refactor processNetworkAnnouncement into smaller functions
2022-03-16 11:23:46 +01:00
Oliver Gugger 95c270d1f8 Merge pull request #6217 from liviu-ln/psbt-finalize-check
walletrpc: return an error when finalizing an already complete PSBT
2022-03-14 10:45:24 +01:00
Oliver Gugger 41b91bd5be Merge pull request #6314 from yyforyongyu/fix-sig-len
lnwire: add length validation in NewSigFromRawSignature
2022-03-11 09:44:11 +01:00
Oliver Gugger 262591c333 Merge pull request #6285 from guggero/btcec-v2-upgrade
Bump btcec to v2, use integrated btcutil module
2022-03-09 19:55:10 +01:00
Oliver Gugger e84c7fb71c docs: add release notes 2022-03-09 19:05:44 +01:00
Oliver Gugger 4554c306fa mod: bump submodules after changes to them 2022-03-09 19:05:44 +01:00
Oliver Gugger 7dfe4018ce multi: use btcd's btcec/v2 and btcutil modules
This commit was previously split into the following parts to ease
review:
 - 2d746f68: replace imports
 - 4008f0fd: use ecdsa.Signature
 - 849e33d1: remove btcec.S256()
 - b8f6ebbd: use v2 library correctly
 - fa80bca9: bump go modules
2022-03-09 19:02:37 +01:00
Oliver Gugger 8ee9fc837b Merge pull request #6136 from bhandras/forall_etcd
etcd: add ForAll to speed up graph operations
2022-03-07 16:44:43 +01:00
Oliver Gugger 1d3d70b0ab Merge pull request #6066 from bitromortac/2111-graph-diameter
autopilot+lnrpc: add graph diameter calculation to getnetworkinfo
2022-03-07 14:18:36 +01:00
Oliver Gugger 72aec1722b Merge pull request #6300 from 3nprob/docker-custom-source
docker: add git_url build-arg
2022-03-05 11:42:41 +01:00
Oliver Gugger e7505c3e6b Merge pull request #6284 from guggero/tlv-1.0.1
mod: bump tlv version to v1.0.1 [skip ci]
2022-02-22 09:16:39 +01:00
Oliver Gugger 0db2c6a244 Merge pull request #6289 from yyforyongyu/fix-fee-service-panic
itest: check feeService against nil upon shutdown [skip ci]
2022-02-22 09:12:19 +01:00
Oliver Gugger b4b524903c mod: bump tlv version to v1.0.1 [skip ci]
Apparently we already pushed a tag named tlv/v1.0.0 a while ago (which
points to a commit not in master)...
We need to bump the version of the tag to v1.0.1 since we cannot replace
old tags (without causing a lot of caching problems).
2022-02-21 15:30:07 +01:00
Oliver Gugger 4df7dbdc58 Merge pull request #6283 from guggero/tlv-module
mod+tlv: refactor tlv package into its own submodule
2022-02-21 15:24:52 +01:00
Oliver Gugger d9b657ccb6 docs: update release notes 2022-02-21 13:49:30 +01:00
Oliver Gugger 96b960455f mod+tlv: make tlv its own submodule 2022-02-21 13:49:30 +01:00
Oliver Gugger 67f5957c5e tlv+watchtower: move bench test
The benchmark tests import both the tlv and watchtower packages. To make
it possible to extract the tlv package into its own submodule, this test
is better located in the watchtower package.
2022-02-21 13:48:31 +01:00
Oliver Gugger 3ed8b90c21 Merge pull request #6280 from guggero/remove-halseth
Remove expired or soon to expire PGP keys from signing script
2022-02-21 12:54:30 +01:00
Oliver Gugger a6282ab08e scripts: remove expiring key for cfromknecht [skip ci]
The user cfromknecht isn't an active contributor anymore and the key
will expire in less than two weeks.
2022-02-21 10:26:48 +01:00
Oliver Gugger d46e9d2d29 scripts: remove expired key for halseth
Fixes #6272.
The user halseth isn't an active contributor anymore and the key
expired.
2022-02-21 10:21:54 +01:00
Oliver Gugger 0aa0831619 Merge pull request #6270 from guggero/enable-whitespace-linter
ci: enable whitespace linter
2022-02-15 18:21:04 +01:00
Oliver Gugger eb366a64e6 docs: add release notes 2022-02-15 18:13:03 +01:00
Oliver Gugger 13f187046b multi: fix issues reported by whitespace linter 2022-02-15 16:26:08 +01:00
Oliver Gugger 8d83778314 tools+golangci-lint: enable fixed version of whitespace linter 2022-02-15 11:16:19 +01:00
Oliver Gugger 2891dc7399 Merge pull request #6248 from guggero/lint-dockerize
make+tools: dockerize linting [skip ci]
2022-02-11 10:10:56 +01:00
Oliver Gugger 09406f613a make+tools: dockerize linting 2022-02-10 16:03:00 +01:00
Oliver Gugger 28ea2736a0 Merge pull request #6244 from guggero/linter-upgrade
Move tools dependencies into submodule, upgrade `golangci-lint`
2022-02-10 15:11:20 +01:00
Oliver Gugger 67eae60bcc docs: add release notes 2022-02-10 11:04:54 +01:00
Oliver Gugger 895a2e497b multi: formatting and comment fixes 2022-02-10 11:02:02 +01:00
Oliver Gugger ffee7d1bcf multi: fix newly detected linter issues 2022-02-10 11:02:02 +01:00
Oliver Gugger 369627901f lint+tools: bump version of golangci-lint 2022-02-10 11:02:01 +01:00
Oliver Gugger dfdc2bff8b multi: run gosimports 2022-02-10 11:02:01 +01:00
Oliver Gugger d1b512ff92 mod+make: replace goimports with gosimports 2022-02-10 11:02:00 +01:00
Oliver Gugger 3107c807a9 Merge pull request #6239 from BTCparadigm/UpdateLicenses
multi: Update licenses to 2022 [skip ci]
2022-02-09 14:31:45 +01:00
Oliver Gugger 0bef42e93c Merge pull request #6233 from guggero/sign-psbt-utxo-error-message
rpcwallet: disallow empty UTXO pk script [skip ci]
2022-02-08 09:39:09 +01:00
Oliver Gugger 75016a176c rpcwallet: disallow empty UTXO pk script [skip ci]
If we're signing for an UTXO that isn't known to the wallet, then the
UTXO's pk script _must_ be set in the sign descriptor. Otherwise we run
into a generic PSBT serialization error when running in a remote signing
setup.
2022-02-03 17:34:14 +01:00
Oliver Gugger 04bbbea9a7 Merge pull request #6228 from guggero/contribution-guidelines
docs: rewrite and regroup formatting rules [skip ci]
2022-02-03 10:02:02 +01:00
Oliver Gugger 84c8c18a9e docs: update release notes 2022-02-02 17:29:55 +01:00
Oliver Gugger d252653624 lncli: use amount based default routing fee 2022-02-02 17:29:52 +01:00
Oliver Gugger 30367d50c7 Merge pull request #6229 from Neil-LL/patch-1
Tiny Formatting Change
2022-02-02 15:48:04 +01:00
Oliver Gugger b667f7a89c docs: rewrite and regroup formatting rules [skip ci] 2022-02-02 15:11:43 +01:00
Oliver Gugger 3c324ad058 docs: remove protobuf compilation section from guidelines
Since we're now enforcing the formatting of the protobuf files through a
CI step, this explicit mention in the docs is no longer needed.
2022-02-02 15:10:24 +01:00
Oliver Gugger d22f543906 lnrpc: use amount based default routing fee 2022-02-02 14:24:53 +01:00
Oliver Gugger bfa1cf17b9 lnwallet: introduce default routing fee calculation 2022-02-02 14:24:52 +01:00
Oliver Gugger 4a6e4d283e Merge pull request #6222 from positiveblue/code-guidelines
docs: add guidelines for func declarations [skip ci]
2022-02-01 17:43:16 +01:00
Oliver Gugger 60625b6c1a Merge pull request #6213 from blakejakopovic/master
docs: fixed typos in mobile readme
2022-01-31 15:16:59 +01:00
Oliver Gugger 91f93f161d Merge pull request #6218 from guggero/dev-rpc-fix
devrpc: remove lncli API docs tag [skip ci]
2022-01-31 13:35:05 +01:00
Oliver Gugger a5849bb189 devrpc: remove lncli API docs tag [skip ci]
The API doc generator failed after merging #6149 because of the `lncli
importgraph` tag in the proto file.
We could also fix the API doc generator by adding the "dev" build tag,
but not including any dev only features in the API docs is probably the
preferred path.
2022-01-31 13:05:27 +01:00
Oliver Gugger 8d40c8904e Merge pull request #6207 from lightningnetwork/ci-rpc-check
makefile: fail rpc-check after finding any changes
2022-01-31 11:15:35 +01:00
Oliver Gugger 9e0f7e73db Merge pull request #6211 from carlaKC/github-prtemplate
github: simplify PR template and add more sections
2022-01-28 10:46:22 +01:00
Oliver Gugger b77c1fb200 Merge pull request #6149 from bhandras/graph_import_rpc
lnd: add `devrpc` sub server and `devrpc.ImportGraph` to import graph dumps
2022-01-28 10:24:59 +01:00
Oliver Gugger 065412b948 Merge pull request #6182 from carlaKC/454-loop-hophintsrefactor
invoicerpc: refactor SelectHopHints to allow external use
2022-01-28 09:44:29 +01:00
Oliver Gugger 8d3d8580f9 Merge pull request #6197 from carlaKC/itest-policy-ensureconnected
lntest/test: ensure nodes connected before disconnecting
2022-01-27 13:20:13 +01:00
Oliver Gugger 0dae2d47f2 Merge pull request #6202 from guggero/itest-lnddir
lntest: set --lnddir instead of --datadir
2022-01-26 16:12:29 +01:00
Oliver Gugger cc1f91b4d3 docs: add release notes 2022-01-26 11:38:44 +01:00
Oliver Gugger bc3319a7d2 lntest: set --lnddir instead of --datadir
If we only set the --datadir flag then lnd will create empty directories
(for letsencrypt and watchtower client) in the default user's home .lnd
directory and will also pick up a config file from there if one exists.
To instruct lnd to only act within the temp itest directory, we need to
use the --lnddir flag instead.
Using the --lnddir flag also overwrites the TLS cert/key path and the
log dir, so we don't need to explicitly set those anymore.
But we need to make sure the node's variables point to the correct
default files/directories.
2022-01-26 11:37:10 +01:00
Oliver Gugger f0e2a20d67 Merge pull request #6181 from schjonhaug/general-improvements-to-mobile-instructions
General improvements to mobile instructions
2022-01-24 16:52:52 +01:00
Oliver Gugger 1482e5e20a Merge pull request #6156 from rex4539/typos
multi: Fix typos
2022-01-24 13:24:49 +01:00
Oliver Gugger bf4b47caa9 Merge pull request #6194 from zdebra/master
itest: fix documentation for LookupNodeByPub [skip ci]
2022-01-24 10:14:31 +01:00
Oliver Gugger f50950640f Merge pull request #6188 from yyforyongyu/timeout-7z
github: add timeout when zipping log files
2022-01-21 12:28:21 +01:00
Oliver Gugger 717c7c59a0 Merge pull request #6183 from guggero/github-daily-docker-build
GitHub: fix daily docker build
2022-01-20 21:17:57 +01:00
Oliver Gugger 6680d27d6f Merge pull request #6184 from carlaKC/healthcheck-nochainbackend
server: disable chain health check if we're running without backend
2022-01-20 15:18:24 +01:00
Oliver Gugger 5ead5ec4b6 GitHub: fix daily docker build 2022-01-20 10:27:42 +01:00
Oliver Gugger ddaba02558 Merge pull request #6178 from BTCparadigm/GitIgnore
Ignore .vs/ folder
2022-01-20 09:34:20 +01:00
Oliver Gugger 431ef6c4c3 Merge pull request #6160 from guggero/docker-nightly-build
github: add schedule for nightly docker build
2022-01-18 13:11:14 +01:00
Oliver Gugger 264b3b00cd github: add schedule for daily build 2022-01-18 12:46:27 +01:00
Oliver Gugger 3ff849d15b Merge pull request #6167 from madskrogh/pendingchannels-private-status
lnrpc: add Private field to PendingChannelsResponse
2022-01-18 10:48:00 +01:00
Oliver Gugger f84825e441 Merge pull request #6152 from madskrogh/closechannel-with-point
lncli: closechannel chan_point flag
2022-01-17 10:29:46 +01:00
Oliver Gugger ed511bb37f Merge pull request #6146 from yyforyongyu/add-closing-txid
rpcserver: add closing txid in PendingChannels' WaitingCloseChannel
2022-01-12 13:23:16 +01:00
Oliver Gugger 2560e2c69f Merge pull request #6142 from sangaman/externalhosts-desc
docs: clarify --externalhosts usage
2022-01-12 11:57:16 +01:00
Oliver Gugger d3faef5691 Merge pull request #6080 from guggero/pr-consolidation
multi: consolidate trivial PRs that are stuck on CI pipeline steps
2022-01-11 16:04:40 +01:00
Oliver Gugger 1795c1f686 docs: add release notes 2022-01-11 14:08:20 +01:00
Oliver Gugger 617be6f994 Merge pull request #6140 from bottlepay/fix-duplicate-close
htlcswitch: fix duplicate close
2022-01-11 11:08:30 +01:00
Oliver Gugger f788f9286e Merge pull request #6088 from arshbot/export-backend-credentials
Export backend credentials
2022-01-11 11:02:37 +01:00
Oliver Gugger 5282c9acf9 docs: update remote signing doc and release notes 2022-01-06 14:35:26 +01:00