Commit Graph
100 Commits
Author SHA1 Message Date
Oliver Gugger 8a2999c789 Merge pull request #7500 from yyforyongyu/coverage-test-flags
Makefile: add testing_flags to coverage test
2023-03-16 10:07:20 +01:00
Oliver Gugger 51680c5677 Merge pull request #7490 from yyforyongyu/replace-6417
Return FEE_INSUFFICIENT before checking balance for incoming low-fee HTLCs
2023-03-16 10:05:58 +01:00
Oliver Gugger dbf667d8fc Merge pull request #7511 from yyforyongyu/fix-state-check-itest
itest+lntest: make sure states are cleaned when tests end
2023-03-14 18:58:59 +01:00
Oliver Gugger 098bb36114 Merge pull request #7510 from guggero/fund-psbt-unconfirmed
lncli: allow specifying `--min_confs` in `wallet psbt fund` to select unconfirmed inputs
2023-03-14 13:45:05 +01:00
Oliver Gugger 1ed63a85b3 docs: add release notes 2023-03-13 12:46:05 +01:00
Oliver Gugger 1a3be78471 cmd/lncli: add --num_confs to wallet psbt fund command 2023-03-13 12:45:58 +01:00
Oliver Gugger fe24f195b8 Merge pull request #7508 from positiveblue/fix-linter
multi: make linter happy
2023-03-13 10:04:26 +01:00
Oliver Gugger dcf69169e5 Merge pull request #7492 from yyforyongyu/gossip-add-log
Add trace logs for `discovery` to catch test flakes
2023-03-09 12:52:01 +01:00
Oliver Gugger d5942bf692 Merge pull request #7499 from Roasbeef/bump-go-version
build: bump min Go version to 1.19
2023-03-09 10:35:47 +01:00
Oliver Gugger a28fbd4690 Merge pull request #7491 from ellemouton/fillInTowerToSessionIDIndex
watchtower/wtdb: add tower-to-session index entry for all towers
2023-03-08 13:17:05 +01:00
Oliver Gugger ca3debf351 Merge pull request #7483 from ellemouton/fixNoErrorFunc
multi: fix wait.NoError and sub-test names
2023-03-08 10:42:41 +01:00
Oliver Gugger 54a1661c45 Merge pull request #7451 from CRex15/walletkit+labeltransaction
Add note to LabelTransaction [skip ci]
2023-03-06 18:54:23 +01:00
Oliver Gugger 5330b3e414 Merge pull request #7475 from lightningnetwork/dependabot/go_modules/tor/golang.org/x/net-0.7.0
build(deps): bump golang.org/x/net from 0.0.0-20211015210444-4f30a5c0130f to 0.7.0 in /tor
2023-03-03 13:41:19 +01:00
Oliver Gugger 2e9ceb2ceb Merge pull request #7471 from hieblmi/peer-alias-remove-error
rpc: assign peer alias lookup error string
2023-03-03 11:48:13 +01:00
Oliver Gugger c4e0927960 Merge pull request #7453 from lightningnetwork/dependabot/go_modules/healthcheck/golang.org/x/sys-0.1.0
build(deps): bump golang.org/x/sys from 0.0.0-20211216021012-1d35b9e2eb4e to 0.1.0 in /healthcheck
2023-03-03 10:15:29 +01:00
Oliver Gugger 880dfd74d8 Merge pull request #7455 from lightningnetwork/dependabot/go_modules/tor/golang.org/x/sys-0.1.0
build(deps): bump golang.org/x/sys from 0.0.0-20211216021012-1d35b9e2eb4e to 0.1.0 in /tor
2023-03-03 10:15:06 +01:00
Oliver Gugger 1136643917 Merge pull request #7469 from yyforyongyu/fix-itest-network-timeout
itest: use unreachable URL in `testNetworkConnectionTimeout`
2023-03-02 09:15:04 +01:00
Oliver Gugger ffef78a4e5 Merge pull request #7462 from guggero/createwatchonly-stateless
remote signer: allow stateless init of watch-only node
2023-02-27 22:36:32 +01:00
Oliver Gugger 610fc0d927 docs: add release notes 2023-02-27 21:59:45 +01:00
Oliver Gugger 04376b3b23 cmd/lncli: add --stateless_init to createwatchonly command 2023-02-27 21:59:45 +01:00
Oliver Gugger d321182220 Merge pull request #7322 from hieblmi/cmd-listchannels-peer-alias
lncli: remote peer alias in `listchannels`
2023-02-24 22:16:43 +01:00
Oliver Gugger 73596ceac2 Merge pull request #7447 from Roasbeef/v0-16-0-branch-rc1
build: bump version to v0.16.0-rc1
2023-02-24 09:56:19 +01:00
Oliver Gugger b3e27f9ba7 Merge pull request #7415 from bitromortac/2302-max-htlc
routing+discovery: fail non-maxHTLC channel updates in validation
2023-02-22 08:45:56 +01:00
Oliver Gugger d44823f6e8 Merge pull request #7431 from Crypt-iQ/remove_res_ids
lnwallet: remove from reservationIDs
2023-02-21 12:36:10 +01:00
Oliver Gugger 0f079729c1 Merge pull request #7418 from lightningnetwork/dependabot/go_modules/kvdb/golang.org/x/net-0.7.0
build(deps): bump golang.org/x/net from 0.4.0 to 0.7.0 in /kvdb
2023-02-20 08:35:45 +01:00
Oliver Gugger 581e195bfe Merge pull request #7414 from guggero/merge-queue-fix
github: fix merge group directive
2023-02-17 16:59:44 +01:00
Oliver Gugger a257e6203d github: fix merge group directive 2023-02-17 11:14:38 +01:00
Oliver Gugger 4d7ac82773 Merge pull request #7412 from Roasbeef/merge-queue-fix
build: use the new merge_group selector for the merge queue
2023-02-17 11:08:51 +01:00
Oliver Gugger ccb00741df Merge pull request #7324 from hieblmi/openchannel-fix-line-length
lncli: fix line length issues
2023-02-17 09:30:00 +01:00
Oliver Gugger 93b7821df3 Merge pull request #7408 from carlaKC/bugfix-updatenodeanncli
bugfix/trivial: fix update node announcement feature bit add /remove
2023-02-16 21:40:36 +01:00
Oliver Gugger 38dc67e1ef Merge pull request #6815 from bitromortac/2205-bimodal
pathfinding: probability for bimodal distribution
2023-02-15 14:19:32 +01:00
Oliver Gugger f245591e4b Merge pull request #7386 from guggero/remote-signer-p2tr-inputs
remote signer: fix channel funding with mixed funding input types
2023-02-14 12:34:11 +01:00
Oliver Gugger c79b0799bf Merge pull request #7402 from bottlepay/final-resolution-info
rpcserver: expose store final htlc resolutions flag on info call
2023-02-13 23:12:32 +01:00
Oliver Gugger 8ade1acba3 Merge pull request #7399 from prusnak/sample-conf-whitespace
docs: fix whitespace in sample-lnd.conf
2023-02-13 12:54:42 +01:00
Oliver Gugger 0c5971ba9e Merge pull request #7392 from adiabat/hltcinterceptfix
HTLC Interceptor: Fix nil pointer dereference
2023-02-13 11:43:29 +01:00
Oliver Gugger 939614b70d Merge pull request #7395 from yyforyongyu/fix-unit-test-db
channeldb+invoices: fix unit test flakes
2023-02-10 14:27:17 +01:00
Oliver Gugger f94500281f Merge pull request #7348 from Torakushi/psbt
Add possibility to define a change scope in FundPsbt
2023-02-08 16:27:58 +01:00
Oliver Gugger e7fb48ff73 docs: add release notes 2023-02-07 22:15:14 +01:00
Oliver Gugger df1ea46d9e rpcwallet: fix p2tr inputs in remote signing
The SendOutputs method isn't used very often in our code so the missing
Taproot sighash type wasn't detected before.
Also, a P2TR input will never have a sigScript, so we can explicitly set
that parameter to nil instead of relying on it being nil anyway.
2023-02-07 22:15:13 +01:00
Oliver Gugger 8bc16b4fb2 rpcwallet: fix np2wkh inputs in remote signing
There is a one byte difference between the sigScript and the
witnessScript in case of a np2wkh input. The remote signer actually
needs the witness script and not the sig script to produce a valid
signature.
2023-02-07 22:15:12 +01:00
Oliver Gugger c6c52b8eb3 itest: add coverage for np2wkh in remote signing 2023-02-07 22:15:11 +01:00
Oliver Gugger a2a96c7712 lnwallet: don't re-use sign descriptor
Fixes an issue where re-using a sign descriptor in a loop carried over
signing information from one call to the next, which caused the remote
signing issue.
2023-02-07 22:15:10 +01:00
Oliver Gugger e4f3a35c0c funding: fix peer key serialization in log message 2023-02-07 22:15:09 +01:00
Oliver Gugger 5d18fccd42 itest: reproduce remote signing issue
This commit attempts to reproduce the issue as described in #7276.
2023-02-07 22:15:08 +01:00
Oliver Gugger a233df99c4 Merge pull request #7388 from bhandras/cert-fixup-lnd
lnd: bump lnd/cert version to v1.2.1
2023-02-07 17:23:25 +01:00
Oliver Gugger 17d7e84b26 Merge pull request #7387 from bhandras/cert-fixup
cert: removed unused args from `cert.GenCertPair` [no-itest]
2023-02-06 22:52:42 +01:00
Oliver Gugger 3ba975b4db Merge pull request #7384 from guggero/close-mac-db
walletunlocker: fix unit test flake by closing DB
2023-02-06 16:57:42 +01:00
Oliver Gugger ad6fe6a78e Merge pull request #7385 from guggero/github-label-trigger
GitHub: allow skipping itest and changelog check with labels
2023-02-06 15:50:16 +01:00
Oliver Gugger 6874582ed4 GitHub: allow skipping itest and changelog check with labels 2023-02-06 14:11:59 +01:00
Oliver Gugger aa3647de82 docs: add release notes 2023-02-06 14:08:09 +01:00
Oliver Gugger 2086f09489 walletunlocker: fix unit test flake by closing DB
This fixes a unit test flake that occurred sometimes if the temporary
directory was attempted to be deleted but the wallet or macaroon DB
hasn't been closed yet.

````
--- FAIL: TestChangeWalletPasswordNewRootkey (1.63s)
    testing.go:1097: TempDir RemoveAll cleanup: unlinkat /tmp/TestChangeWalletPasswordNewRootkey3063283009/001/mainnet: directory not empty
FAIL
FAIL	github.com/lightningnetwork/lnd/walletunlocker	6.171s
FAIL
````
2023-02-06 14:08:08 +01:00
Oliver Gugger 0cf0a7dd3b Merge pull request #7341 from bottlepay/final-settle-opt-in
channeldb: final htlc resolution storage opt-in
2023-02-06 13:21:40 +01:00
Oliver Gugger 75a39da01a Merge pull request #7171 from guggero/musig2-versioned-rpc
signrpc: Upgrade to MuSig2 BIP draft v1.0.0rc2, add version flag to RPC
2023-02-06 12:35:49 +01:00
Oliver Gugger 1e13bb8e32 docs: add release notes, update musig2 doc 2023-02-06 10:50:30 +01:00
Oliver Gugger 58d0707a77 itest: test both MuSig2 versions 2023-02-06 10:50:30 +01:00
Oliver Gugger dcf21e506a lnwallet: fix linter issues in signer 2023-02-06 10:50:30 +01:00
Oliver Gugger 13252aec1d lnrpc+rpcwallet: add version to MuSig2 RPC calls 2023-02-06 10:50:29 +01:00
Oliver Gugger ce5fa2e043 multi: add version to MuSig2 API, bump btcd/btcec to v2.3.2
With this commit we bump the github.com/btcd/btcec/v2 library to v2.3.2
which implements the MuSig2 BIP version v1.0.0rc2. With this the
github.com/btcsuite/btcd/btcec/v2/schnorr/musig2 package becomes
v1.0.0rc2 and the github.com/lightningnetwork/lnd/internal/musig2v040
stays at the old v0.4.0 version.
2023-02-03 18:30:10 +01:00
Oliver Gugger 0e5ce71b33 input+lnwallet: put MuSig2 types behind interface
We put the calls that don't use musig2 package specific types as
parameters or return values behind an interface so we can easily call
those directly in the RPC without needing to know the underlying
implementation version. Some calls can't be used in the interface
because they use the specific package version's types. These calls are
implemented in helper functions in the input package instead that do the
necessary type switches.
2023-02-03 18:30:10 +01:00
Oliver Gugger cb9f2d0398 input+lnrpc: make key sorting optional in input pkg
To allow us to properly test all test vectors, we can't default to true
on key sorting. Instead we add a parameter to the input package and move
the default value to the RPC server.
2023-02-03 18:30:09 +01:00
Oliver Gugger 13789f5d95 input+lnwallet: move some MuSig2 calls to input pkg
As a preparation for making it possible to version switch calls to the
MuSig2 API, we move some of the calls to the input package where in a
future commit we'll call the corresponding code in the correct package.
2023-02-03 18:30:09 +01:00
Oliver Gugger 4f5ede84c6 lnwallet: fix variable names 2023-02-03 18:30:09 +01:00
Oliver Gugger 0154226233 internal/musig2: rename to musig2v040 to avoid confusion
Since we explicitly keep an old version of a library in lnd for backward
compatibility we want to make sure the purpose and version of it is
clear and not misleading.
2023-02-03 18:30:09 +01:00
Oliver Gugger 3012f5e17d mod+internal: copy MuSig2 v0.4.0 code from btcd/btcec/v2
With this commit we copy the exact code of the MuSig2 code as found in
github.com/btcsuite/btcec/v2/schnorr/musig2 at the tag btcec/v2.2.2.
This corresponds to the MuSig2 BIP specification version of v0.4.0.
2023-02-03 18:30:09 +01:00
Oliver Gugger ff8f1371b5 itest: add itest for MuSig2 CombineKey
Before we change anything in the MuSig2 API, we first add an integration
test that makes sure the current version of the API combines keys
according to the v0.4.0 test vectors.
2023-02-03 18:25:56 +01:00
Oliver Gugger a4c3e50ca5 Merge pull request #7375 from yyforyongyu/fix-linter
ci: fix lint VSC permissions error
2023-01-31 18:31:33 +01:00
Oliver Gugger 5b354c6598 Merge pull request #6527 from voltagecloud/encrypt-tls-key-2
tls: Add ability to encrypt TLS key on disk
2023-01-27 14:08:09 +01:00
Oliver Gugger 33a0cbe634 Merge pull request #7292 from Crypt-iQ/disconnectblock_patch
aliasmgr+channeldb: stop deleting zero-conf edges from graph if reorg occurs
2023-01-26 16:26:28 +01:00
Oliver Gugger fe5254510e multi: warn user if they try to switch db types
Warn a user if they attempt to initialise a new db type (sqlite or
postgres) if an old bbolt db file is found.
2023-01-25 14:16:56 +02:00
Oliver Gugger 9187d4679b Merge pull request #7231 from ziggie1984/sign_verify_message_with_addr
Sign/Verify messages and signatures for single addresses
2023-01-24 20:30:15 +01:00
Oliver Gugger 97f139b617 Merge pull request #7353 from bottlepay/bump-kvdb-etcd
kvdb: bump etcd to v3.5.7
2023-01-24 15:58:15 +01:00
Oliver Gugger f4400eabe4 Merge pull request #7352 from ellemouton/removeEtcdCleanups
kvdb: remove etcd test fixture cleanup calls
2023-01-24 13:52:37 +01:00
Oliver Gugger 3a6aaf6275 Merge pull request #7303 from ziggie1984/fuzz_tests_custommessages
Add Custom Message to Fuzz Testing
2023-01-23 10:13:39 +01:00
Oliver Gugger 35caaf3c53 Merge pull request #7334 from positiveblue/invoice-type-helper
channeldb/invoices: add `IsAMP` and `IsKeysend` helpers
2023-01-20 16:34:20 +01:00
Oliver Gugger 0eb07c944c Merge pull request #7330 from yyforyongyu/routing-rm-mtx
routing: remove the mutex lock inside `ChannelRouter`
2023-01-19 16:15:02 +01:00
Oliver Gugger b5bf658780 Merge pull request #7337 from yyforyongyu/fix-unit-test
bitcoindnotify: fix subtest closure in unit tests
2023-01-19 14:54:25 +01:00
Oliver Gugger 48c8c1bf48 Merge pull request #6824 from yyforyongyu/5-new-itest
itest: continued itest refactor and fix - IV
2023-01-18 22:14:29 +01:00
Oliver Gugger c38be044d3 Merge pull request #7335 from guggero/disable-gomnd
lint: disable gomnd
2023-01-18 10:43:00 +01:00
Oliver Gugger 716febc6c7 Merge pull request #7336 from positiveblue/fix-race-condition
routing: fix reace condition in `TestUpdatePaymentState`
2023-01-18 09:26:28 +01:00
Oliver Gugger de94a4ea5e Merge pull request #7157 from yyforyongyu/fix-peer
brontide: retry enabling channels
2023-01-17 23:37:44 +01:00
Oliver Gugger d960fcd68a multi: remove gomnd disable directives 2023-01-17 19:43:26 +01:00
Oliver Gugger a306cbdec9 lint: disable gomnd 2023-01-17 19:20:57 +01:00
Oliver Gugger 04447927ea Merge pull request #7055 from ellemouton/wtclientMigrations
watchtower: reduce AckedUpdate storage footprint
2023-01-17 10:37:52 +01:00
Oliver Gugger b4febb382a Merge pull request #6823 from yyforyongyu/4-new-itest
itest: continued itest refactor and fix - III
2023-01-17 09:38:31 +01:00
Oliver Gugger be77572fa0 Merge pull request #7115 from C-Otto/log
lnwallet: add log message for edge case
2023-01-16 18:18:10 +01:00
Oliver Gugger 681da4b2b5 Merge pull request #7321 from bshramin/fix-selfsigned-typos
Fix typos in selfsigned.go
2023-01-16 09:54:08 +01:00
Oliver Gugger e953034b83 Merge pull request #7325 from ellemouton/fixGomndLintError
lncli+docs: skip gomnd check in switch statement
2023-01-16 09:46:28 +01:00
Oliver Gugger 143eba82ea Merge pull request #7314 from yyforyongyu/fix-unit-test-mailbox
htlcswitch: fix test flake in `TestMailBoxAddExpiry`
2023-01-13 15:05:17 +01:00
Oliver Gugger d108d7f741 Merge pull request #7315 from sputn1ck/lncli_ordinal_numbers
lncli/sendpayment: more descriptive failure log
2023-01-13 10:28:42 +01:00
Oliver Gugger 6f0383bb4f Merge pull request #7308 from hieblmi/code-sytle-cleanup
funding: code style cleanup in the funding package
2023-01-12 15:01:42 +01:00
Oliver Gugger b1645ec46d Merge pull request #6783 from ErikEk/itest-neutrino-sub-server
itest: neutrino sub-server
2023-01-12 12:20:58 +01:00
Oliver Gugger 3dd9e04b8b Merge pull request #7306 from YusukeShimizu/docs-invoice-default-expiry
Docs invoice default expiry
2023-01-12 10:29:07 +01:00
Oliver Gugger 79d5a01a81 Merge pull request #7310 from bitromortac/2301-queryprob-docs
routerrpc: update QueryProbability documentation
2023-01-12 10:23:09 +01:00
Oliver Gugger b1d6991b27 Merge pull request #7153 from carlaKC/7093-custommessage
multi: Add ability to handle protocol-range messages in Custom Message APIs
2023-01-11 09:52:40 +01:00
Oliver Gugger ef8cf73d4c Merge pull request #7295 from guggero/build-cache
GitHub: fix Golang build cache in actions
2023-01-06 14:11:34 +01:00
Oliver Gugger f16a2f11df docs: add release notes 2023-01-06 09:18:28 +01:00
Oliver Gugger a074c801d1 GitHub: add job ID to cache key
To avoid the problem where multiple jobs try to create the same cache
entry, we add the GitHub job ID to the cache key.
The two restore keys make it possible that a job can also restore a
cache entry from another job if none for the current job exist yet.
2023-01-06 09:18:28 +01:00
Oliver Gugger 984fc3a2ec GitHub: make setup-go action more versatile
With this commit we allow the Go version that is set up to be
configurable and not dependent on a specific environment variable. This
will allow us to eventually extract the action into a tooling
repository.
2023-01-06 09:18:26 +01:00
Oliver Gugger c4ca7b99e2 GitHub: remove Go env variable override
For some reason we used to override the GOCACHE and GOPATH variables
earlier. This now causes the updated cache action not to pick up any
caches. As the overrides shouldn't be needed anymore, we remove them.
2023-01-06 09:18:16 +01:00
Oliver Gugger cfc48bd81c Merge pull request #7272 from positiveblue/fix-7270
rpc: check that closing address matches the current network for open channel requests
2023-01-05 17:15:55 +01:00