Commit Graph
100 Commits
Author SHA1 Message Date
Oliver Gugger ebf11bc2f1 itest: move lnd_custom_{message => message_test}.go
This recently added file didn't follow the golang naming convention for
tests.
2023-04-18 09:40:18 +02:00
Oliver Gugger af70af2710 funding+server: update switch after sending channel update
With this commit we give the funding manager the ability to inform the
switch about custom channel policies, right after we've announced the
channel to the network.
This change is necessary because before #6753 a channel could only be
opened with the default forwarding policies, so the switch automatically
had the "correct" default values. Since #6753 added the ability to
specify forwarding policies at channel open time, we announced those
policies to the network but never updated the switch to inform it about
the changed policies (previously changing the policies was only possible
through the UpdateChannelPolicy RPC which did call the switch).
2023-04-18 09:40:18 +02:00
Oliver Gugger 68881f5c20 funding: refactor manager test 2023-04-18 09:40:17 +02:00
Oliver Gugger b875084cbe docs: update remote signing docs
With this commit we update the docs according to the latest changes that
were necessary to support loop and pool (which requires all 255
internally used accounts to be imported at wallet creation time).

Fixes #7567.
2023-04-11 20:44:01 +02:00
Oliver Gugger b6b536a1b9 Merge pull request #7550 from ardevd/proto-gen-dockerize-go
lnrpc: fully dockerize protobuf generation
2023-04-11 18:57:02 +02:00
Oliver Gugger 5046399991 Merge pull request #7588 from Roasbeef/simnet-walletrpc-cointype-fix
config: fix bug in walletrpc interaction due to mismatched coin type
2023-04-11 13:46:43 +02:00
Oliver Gugger 559cb47ec2 Merge pull request #7513 from guggero/publish-tx-logging
wallet: improve logging around transaction broadcast failures
2023-04-11 12:53:06 +02:00
Oliver Gugger 154e654dc0 docs: add release notes 2023-04-11 12:49:27 +02:00
Oliver Gugger 26254d0730 docs: add release notes 2023-04-11 11:15:37 +02:00
Oliver Gugger 3beaf7c4c1 channeldb: use input.GenMultiSigScript 2023-04-11 11:15:36 +02:00
Oliver Gugger 79c275253c input: set initial script allocation size
The default allocation of 500 bytes for the script that is
used in NewScriptBuilder is way too much for most of our scripts.
With the new functional option we can tune the allocation to exactly
what we need.
2023-04-11 11:15:36 +02:00
Oliver Gugger a47345bd6f input: add script size unit and benchmark tests 2023-04-11 11:15:36 +02:00
Oliver Gugger 4bf97477ee mod: bump btcd version 2023-04-11 10:33:19 +02:00
Oliver Gugger 9b3e4bd5c2 Merge pull request #7584 from lightningnetwork/dependabot/go_modules/golang.org/x/net-0.7.0
build(deps): bump golang.org/x/net from 0.4.0 to 0.7.0
2023-04-11 09:32:17 +02:00
Oliver Gugger 4fcd5a0ab0 Merge pull request #7366 from djkazic/feature/listchannels-peer-scid-alias
Add `peer_scid_alias` field to lnrpc.Channel
2023-03-31 19:29:03 +02:00
Oliver Gugger 9c16d199d7 Merge pull request #7541 from ellemouton/statusClientBehind
watchtower: let client recover after data loss
2023-03-31 15:16:07 +02:00
Oliver Gugger 21dd2cf61d Merge pull request #7529 from ziggie1984/psbt-bug
Check for nonWitness UTXO or witness UTXO data in the psbt inputs
2023-03-31 11:58:45 +02:00
Oliver Gugger c31698b59b docker+docs: bump btcd version 2023-03-31 11:04:47 +02:00
Oliver Gugger ec5b95c9a9 Merge pull request #7517 from yyforyongyu/fix-funding-locked
Replace `FundingLocked` with `ChannelReady`
2023-03-30 17:22:17 +02:00
Oliver Gugger 2e9795f26a Merge pull request #7556 from ellemouton/addrIterFix
wtclient: address iterator fix
2023-03-30 16:55:15 +02:00
Oliver Gugger 51df3e5b1e Merge pull request #7546 from guggero/lnd-0-16-0-final
build: bump to version v0.16.0-beta final
2023-03-29 14:59:12 +02:00
Oliver Gugger 218cff41b7 build: bump to version v0.16.0-beta final 2023-03-29 14:30:11 +02:00
Oliver Gugger 5477428525 Merge pull request #7528 from guggero/p2tr-psbt-decoration
itest: assert change output type
2023-03-28 20:10:36 +02:00
Oliver Gugger 5272e9140e Merge pull request #7437 from ardevd/7436-chanbackup-writer-fix
lncli: Added support for backup/verify/restore of single chanpoint to/from file
2023-03-27 10:56:00 +02:00
Oliver Gugger 8dc409ee66 Merge pull request #7537 from guggero/0-16-0-rc5
build: bump version to v0.16.0-rc5
2023-03-23 17:40:13 +01:00
Oliver Gugger e9b21c5f64 build: bump version to v0.16.0-rc5
Because a tag for RC4 was previously pushed but without bumping the
version first, we need to skip RC4 as we can't replace already pushed
git tags without causing issues.
2023-03-23 16:43:38 +01:00
Oliver Gugger 1052b139bd Merge pull request #7520 from bitromortac/2303-bimodal-fixes
routing: prevent retrials for failed channels in bimodal pathfinding
2023-03-23 16:32:14 +01:00
Oliver Gugger b9143c1623 Merge pull request #7350 from eval-exec/fix/time_lock_delta-overflow
[rpcServer]: add time_lock_delta overflow check for UpdateChannelPolicy
2023-03-23 16:21:57 +01:00
Oliver Gugger 3dc4ab736f Merge pull request #7526 from yyforyongyu/enhanced-logging
multi: add more trace logs regarding link activate flow
2023-03-23 10:37:13 +01:00
Oliver Gugger 78351e1730 Merge pull request #7531 from yyforyongyu/fix-web-fee-estimator
Fix web fee estimator test flake and increase retry timeout for channel close
2023-03-22 20:56:49 +01:00
Oliver Gugger 4ab00fb16e Merge pull request #7533 from guggero/travis-timeout
travis: increase timeout to 120 minutes
2023-03-22 17:58:46 +01:00
Oliver Gugger 0dbb709929 travis: increase timeout to 120 minutes 2023-03-22 13:42:39 +01:00
Oliver Gugger dcc7421b5b Merge pull request #7405 from ellemouton/filterOutExhaustedSessions
multi: Filter out exhausted sessions
2023-03-22 10:00:15 +01:00
Oliver Gugger d019c82f07 itest: assert change output type of SendCoins 2023-03-20 20:15:43 +01:00
Oliver Gugger a266c3a4a9 itest: add assertion for PSBT change outputs
With this commit we add more specific assertions to our PSBT signing
test in order to make sure change outputs have the proper PSBT metadata
associated with them, depending on their address type.
2023-03-20 19:22:37 +01:00
Oliver Gugger c4c1f1ac92 Merge pull request #7069 from ellemouton/deleteSessions
watchtower: start using the DeleteSession message
2023-03-20 18:45:36 +01:00
Oliver Gugger ae39cd9e91 Merge pull request #7514 from yyforyongyu/rpc-verbose-log
itest+rpcserver: fix itest flake in `3rd_party_anchor_spend`
2023-03-17 08:48:40 +01:00
Oliver Gugger 2e8dc7bf94 Merge pull request #7439 from ellemouton/bolt3-test-vectors
lnwallet: update Bolt3 test vectors
2023-03-16 18:47:19 +01:00
Oliver Gugger 2869b70808 Merge pull request #7059 from ellemouton/sessionFiltering
multi+towers: add ClientSessionFilterFn option
2023-03-16 16:58:04 +01:00
Oliver Gugger b7697a7257 Merge pull request #7377 from positiveblue/split-update-invoice
channeldb: split `UpdateInvoice` logic
2023-03-16 16:39:29 +01:00
Oliver Gugger 8a2999c789 Merge pull request #7500 from yyforyongyu/coverage-test-flags
Makefile: add testing_flags to coverage test
2023-03-16 10:07:20 +01:00
Oliver Gugger 51680c5677 Merge pull request #7490 from yyforyongyu/replace-6417
Return FEE_INSUFFICIENT before checking balance for incoming low-fee HTLCs
2023-03-16 10:05:58 +01:00
Oliver Gugger dbf667d8fc Merge pull request #7511 from yyforyongyu/fix-state-check-itest
itest+lntest: make sure states are cleaned when tests end
2023-03-14 18:58:59 +01:00
Oliver Gugger 098bb36114 Merge pull request #7510 from guggero/fund-psbt-unconfirmed
lncli: allow specifying `--min_confs` in `wallet psbt fund` to select unconfirmed inputs
2023-03-14 13:45:05 +01:00
Oliver Gugger 1ed63a85b3 docs: add release notes 2023-03-13 12:46:05 +01:00
Oliver Gugger 1a3be78471 cmd/lncli: add --num_confs to wallet psbt fund command 2023-03-13 12:45:58 +01:00
Oliver Gugger fe24f195b8 Merge pull request #7508 from positiveblue/fix-linter
multi: make linter happy
2023-03-13 10:04:26 +01:00
Oliver Gugger dcf69169e5 Merge pull request #7492 from yyforyongyu/gossip-add-log
Add trace logs for `discovery` to catch test flakes
2023-03-09 12:52:01 +01:00
Oliver Gugger d5942bf692 Merge pull request #7499 from Roasbeef/bump-go-version
build: bump min Go version to 1.19
2023-03-09 10:35:47 +01:00
Oliver Gugger a28fbd4690 Merge pull request #7491 from ellemouton/fillInTowerToSessionIDIndex
watchtower/wtdb: add tower-to-session index entry for all towers
2023-03-08 13:17:05 +01:00
Oliver Gugger ca3debf351 Merge pull request #7483 from ellemouton/fixNoErrorFunc
multi: fix wait.NoError and sub-test names
2023-03-08 10:42:41 +01:00
Oliver Gugger 54a1661c45 Merge pull request #7451 from CRex15/walletkit+labeltransaction
Add note to LabelTransaction [skip ci]
2023-03-06 18:54:23 +01:00
Oliver Gugger 5330b3e414 Merge pull request #7475 from lightningnetwork/dependabot/go_modules/tor/golang.org/x/net-0.7.0
build(deps): bump golang.org/x/net from 0.0.0-20211015210444-4f30a5c0130f to 0.7.0 in /tor
2023-03-03 13:41:19 +01:00
Oliver Gugger 2e9ceb2ceb Merge pull request #7471 from hieblmi/peer-alias-remove-error
rpc: assign peer alias lookup error string
2023-03-03 11:48:13 +01:00
Oliver Gugger c4e0927960 Merge pull request #7453 from lightningnetwork/dependabot/go_modules/healthcheck/golang.org/x/sys-0.1.0
build(deps): bump golang.org/x/sys from 0.0.0-20211216021012-1d35b9e2eb4e to 0.1.0 in /healthcheck
2023-03-03 10:15:29 +01:00
Oliver Gugger 880dfd74d8 Merge pull request #7455 from lightningnetwork/dependabot/go_modules/tor/golang.org/x/sys-0.1.0
build(deps): bump golang.org/x/sys from 0.0.0-20211216021012-1d35b9e2eb4e to 0.1.0 in /tor
2023-03-03 10:15:06 +01:00
Oliver Gugger 1136643917 Merge pull request #7469 from yyforyongyu/fix-itest-network-timeout
itest: use unreachable URL in `testNetworkConnectionTimeout`
2023-03-02 09:15:04 +01:00
Oliver Gugger ffef78a4e5 Merge pull request #7462 from guggero/createwatchonly-stateless
remote signer: allow stateless init of watch-only node
2023-02-27 22:36:32 +01:00
Oliver Gugger 610fc0d927 docs: add release notes 2023-02-27 21:59:45 +01:00
Oliver Gugger 04376b3b23 cmd/lncli: add --stateless_init to createwatchonly command 2023-02-27 21:59:45 +01:00
Oliver Gugger d321182220 Merge pull request #7322 from hieblmi/cmd-listchannels-peer-alias
lncli: remote peer alias in `listchannels`
2023-02-24 22:16:43 +01:00
Oliver Gugger 73596ceac2 Merge pull request #7447 from Roasbeef/v0-16-0-branch-rc1
build: bump version to v0.16.0-rc1
2023-02-24 09:56:19 +01:00
Oliver Gugger b3e27f9ba7 Merge pull request #7415 from bitromortac/2302-max-htlc
routing+discovery: fail non-maxHTLC channel updates in validation
2023-02-22 08:45:56 +01:00
Oliver Gugger d44823f6e8 Merge pull request #7431 from Crypt-iQ/remove_res_ids
lnwallet: remove from reservationIDs
2023-02-21 12:36:10 +01:00
Oliver Gugger 0f079729c1 Merge pull request #7418 from lightningnetwork/dependabot/go_modules/kvdb/golang.org/x/net-0.7.0
build(deps): bump golang.org/x/net from 0.4.0 to 0.7.0 in /kvdb
2023-02-20 08:35:45 +01:00
Oliver Gugger 581e195bfe Merge pull request #7414 from guggero/merge-queue-fix
github: fix merge group directive
2023-02-17 16:59:44 +01:00
Oliver Gugger a257e6203d github: fix merge group directive 2023-02-17 11:14:38 +01:00
Oliver Gugger 4d7ac82773 Merge pull request #7412 from Roasbeef/merge-queue-fix
build: use the new merge_group selector for the merge queue
2023-02-17 11:08:51 +01:00
Oliver Gugger ccb00741df Merge pull request #7324 from hieblmi/openchannel-fix-line-length
lncli: fix line length issues
2023-02-17 09:30:00 +01:00
Oliver Gugger 93b7821df3 Merge pull request #7408 from carlaKC/bugfix-updatenodeanncli
bugfix/trivial: fix update node announcement feature bit add /remove
2023-02-16 21:40:36 +01:00
Oliver Gugger 38dc67e1ef Merge pull request #6815 from bitromortac/2205-bimodal
pathfinding: probability for bimodal distribution
2023-02-15 14:19:32 +01:00
Oliver Gugger f245591e4b Merge pull request #7386 from guggero/remote-signer-p2tr-inputs
remote signer: fix channel funding with mixed funding input types
2023-02-14 12:34:11 +01:00
Oliver Gugger c79b0799bf Merge pull request #7402 from bottlepay/final-resolution-info
rpcserver: expose store final htlc resolutions flag on info call
2023-02-13 23:12:32 +01:00
Oliver Gugger 8ade1acba3 Merge pull request #7399 from prusnak/sample-conf-whitespace
docs: fix whitespace in sample-lnd.conf
2023-02-13 12:54:42 +01:00
Oliver Gugger 0c5971ba9e Merge pull request #7392 from adiabat/hltcinterceptfix
HTLC Interceptor: Fix nil pointer dereference
2023-02-13 11:43:29 +01:00
Oliver Gugger 939614b70d Merge pull request #7395 from yyforyongyu/fix-unit-test-db
channeldb+invoices: fix unit test flakes
2023-02-10 14:27:17 +01:00
Oliver Gugger f94500281f Merge pull request #7348 from Torakushi/psbt
Add possibility to define a change scope in FundPsbt
2023-02-08 16:27:58 +01:00
Oliver Gugger e7fb48ff73 docs: add release notes 2023-02-07 22:15:14 +01:00
Oliver Gugger df1ea46d9e rpcwallet: fix p2tr inputs in remote signing
The SendOutputs method isn't used very often in our code so the missing
Taproot sighash type wasn't detected before.
Also, a P2TR input will never have a sigScript, so we can explicitly set
that parameter to nil instead of relying on it being nil anyway.
2023-02-07 22:15:13 +01:00
Oliver Gugger 8bc16b4fb2 rpcwallet: fix np2wkh inputs in remote signing
There is a one byte difference between the sigScript and the
witnessScript in case of a np2wkh input. The remote signer actually
needs the witness script and not the sig script to produce a valid
signature.
2023-02-07 22:15:12 +01:00
Oliver Gugger c6c52b8eb3 itest: add coverage for np2wkh in remote signing 2023-02-07 22:15:11 +01:00
Oliver Gugger a2a96c7712 lnwallet: don't re-use sign descriptor
Fixes an issue where re-using a sign descriptor in a loop carried over
signing information from one call to the next, which caused the remote
signing issue.
2023-02-07 22:15:10 +01:00
Oliver Gugger e4f3a35c0c funding: fix peer key serialization in log message 2023-02-07 22:15:09 +01:00
Oliver Gugger 5d18fccd42 itest: reproduce remote signing issue
This commit attempts to reproduce the issue as described in #7276.
2023-02-07 22:15:08 +01:00
Oliver Gugger a233df99c4 Merge pull request #7388 from bhandras/cert-fixup-lnd
lnd: bump lnd/cert version to v1.2.1
2023-02-07 17:23:25 +01:00
Oliver Gugger 17d7e84b26 Merge pull request #7387 from bhandras/cert-fixup
cert: removed unused args from `cert.GenCertPair` [no-itest]
2023-02-06 22:52:42 +01:00
Oliver Gugger 3ba975b4db Merge pull request #7384 from guggero/close-mac-db
walletunlocker: fix unit test flake by closing DB
2023-02-06 16:57:42 +01:00
Oliver Gugger ad6fe6a78e Merge pull request #7385 from guggero/github-label-trigger
GitHub: allow skipping itest and changelog check with labels
2023-02-06 15:50:16 +01:00
Oliver Gugger 6874582ed4 GitHub: allow skipping itest and changelog check with labels 2023-02-06 14:11:59 +01:00
Oliver Gugger aa3647de82 docs: add release notes 2023-02-06 14:08:09 +01:00
Oliver Gugger 2086f09489 walletunlocker: fix unit test flake by closing DB
This fixes a unit test flake that occurred sometimes if the temporary
directory was attempted to be deleted but the wallet or macaroon DB
hasn't been closed yet.

````
--- FAIL: TestChangeWalletPasswordNewRootkey (1.63s)
    testing.go:1097: TempDir RemoveAll cleanup: unlinkat /tmp/TestChangeWalletPasswordNewRootkey3063283009/001/mainnet: directory not empty
FAIL
FAIL	github.com/lightningnetwork/lnd/walletunlocker	6.171s
FAIL
````
2023-02-06 14:08:08 +01:00
Oliver Gugger 0cf0a7dd3b Merge pull request #7341 from bottlepay/final-settle-opt-in
channeldb: final htlc resolution storage opt-in
2023-02-06 13:21:40 +01:00
Oliver Gugger 75a39da01a Merge pull request #7171 from guggero/musig2-versioned-rpc
signrpc: Upgrade to MuSig2 BIP draft v1.0.0rc2, add version flag to RPC
2023-02-06 12:35:49 +01:00
Oliver Gugger 1e13bb8e32 docs: add release notes, update musig2 doc 2023-02-06 10:50:30 +01:00
Oliver Gugger 58d0707a77 itest: test both MuSig2 versions 2023-02-06 10:50:30 +01:00
Oliver Gugger dcf21e506a lnwallet: fix linter issues in signer 2023-02-06 10:50:30 +01:00
Oliver Gugger 13252aec1d lnrpc+rpcwallet: add version to MuSig2 RPC calls 2023-02-06 10:50:29 +01:00
Oliver Gugger ce5fa2e043 multi: add version to MuSig2 API, bump btcd/btcec to v2.3.2
With this commit we bump the github.com/btcd/btcec/v2 library to v2.3.2
which implements the MuSig2 BIP version v1.0.0rc2. With this the
github.com/btcsuite/btcd/btcec/v2/schnorr/musig2 package becomes
v1.0.0rc2 and the github.com/lightningnetwork/lnd/internal/musig2v040
stays at the old v0.4.0 version.
2023-02-03 18:30:10 +01:00
Oliver Gugger 0e5ce71b33 input+lnwallet: put MuSig2 types behind interface
We put the calls that don't use musig2 package specific types as
parameters or return values behind an interface so we can easily call
those directly in the RPC without needing to know the underlying
implementation version. Some calls can't be used in the interface
because they use the specific package version's types. These calls are
implemented in helper functions in the input package instead that do the
necessary type switches.
2023-02-03 18:30:10 +01:00
Oliver Gugger cb9f2d0398 input+lnrpc: make key sorting optional in input pkg
To allow us to properly test all test vectors, we can't default to true
on key sorting. Instead we add a parameter to the input package and move
the default value to the RPC server.
2023-02-03 18:30:09 +01:00